[Predator] clean up intricacies of crash_pipeline.py |
|||
Issue descriptionThe crash_pipeline.py file has a lot of tricky issues about needing the ``__init__`` and ``run`` methods to all take the same arguments. stgao suggests that this may be because the pipeline class doesn't expect/allow subclasses to implement their own ``__init__``. The only reason we define ``__init__`` is because we need to cache some things for ``finalized`` to use (both for logging, and for setting the status in the ndb.Model). We should see if there's some way to clean all this up, simplifying the code to avoid triggering so many design constraints.
,
Nov 4 2016
We can always construct the Findit object inside the ``run`` method (assuming client_id is an argument to ``run``). The ``finalized`` methods want access to the Findit object (as well as the crash_identifiers), but that's part of the problem it'd be nice to try and fix if we can.
,
Apr 24 2017
,
Oct 31 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by kateso...@chromium.org
, Nov 3 2016