New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662145 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 662088

Blocking:
issue 644372



Sign in to add a comment

[Predator] clean up intricacies of crash_pipeline.py

Project Member Reported by wrengr@chromium.org, Nov 3 2016

Issue description

The crash_pipeline.py file has a lot of tricky issues about needing the ``__init__`` and ``run`` methods to all take the same arguments. stgao suggests that this may be because the pipeline class doesn't expect/allow subclasses to implement their own ``__init__``. The only reason we define ``__init__`` is because we need to cache some things for ``finalized`` to use (both for logging, and for setting the status in the ndb.Model).

We should see if there's some way to clean all this up, simplifying the code to avoid triggering so many design constraints.
 
I think we have another reason to define ``__init__`` - to create self._findit based on parameters passed in.
We can always construct the Findit object inside the ``run`` method (assuming client_id is an argument to ``run``). The ``finalized`` methods want access to the Findit object (as well as the crash_identifiers), but that's part of the problem it'd be nice to try and fix if we can.

Comment 3 by st...@chromium.org, Apr 24 2017

Components: -Tools>Test>FindIt Tools>Test>Predator
Summary: [Predator] clean up intricacies of crash_pipeline.py (was: [Findit] clean up intricacies of crash_pipeline.py)
Status: Archived (was: Available)

Sign in to add a comment