New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662136 link

Starred by 0 users

Issue metadata

Status: Duplicate
Merged: issue 643026
Owner: ----
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , All
Pri: 3
Type: Bug



Sign in to add a comment

We should switch codesearch.chromium.org to index the android configuration by default.

Project Member Reported by dpranke@chromium.org, Nov 3 2016

Issue description

Currently the index on codesearch is built by doing a desktop linux build (and also a cros build?). This means that none of the android code is getting indexed.

Given that it's just as easy to do an android build as a linux build, we should probably do android instead since it covers more code (I think, unless it turns out that we lose all of the desktop UI coverage by doing so).

Obviously, ideally we'd index all of the platforms and merge them, but I don't know if that's on the roadmap or for when?
 

Comment 1 by emso@chromium.org, Nov 4 2016

Labels: Platform Xrefs OS-Android
Status: Available (was: Untriaged)
The current setup builds on Linux and ChromeOS. All files get Linux Xrefs, and files unique to ChromeOS get ChromeOS Xrefs. However, there is no merging of Xrefs, and any file with Xrefs for both platforms only get the Linux Xrefs. 

Getting support for more platforms is on the roadmap, starting with better integration between the two platforms we currently are building for (crbug/652215). Next after that we plan to add more platforms and merge them in as well. Android would likely be the platform after ChromeOS given that there is already some started work on this by akuegel@. Then after that, there it would be Windows and then Mac. 

With the current setup, adding a new builder for a platform will provide Xrefs for files unique to that platform.
I don't know much about how the Xrefs work, so I don't think I followed comment #1.

Are you saying that if a file is only used on CrOS, the xrefs in that file work, but if a file is used on both desktop Linux and CrOS, only the xrefs that apply to both platforms or the ones that are desktop-only (not CrOS) work? So, no xref in something #ifdef'ed OS_CHROMEOS ? It seemed like the latter also worked for me just now.

Comment 3 by emso@chromium.org, Nov 7 2016

Sorry about to confusion. 

The recipe for the code search builder has this filtering step: https://cs.chromium.org/chromium/build/scripts/slave/recipes/chromium_codesearch.py?rcl=0&l=174 calling https://cs.chromium.org/chromium/build/scripts/slave/chromium/filter_compilations.py?dr=C&q=filter_compilations&sq=package:chromium&l=1. For ChromeOS, the set of compilation units for Linux is subtracted from the set of compilation units for ChromeOS. Xrefs are computed for the remaining set of compilation units, resulting in Xrefs on only ChromeOS specific compilation units. 

All this is because there is currently no support for merging of Xrefs, but I'll be investigating if we can support this.

I'm curious about the Xrefs in "#ifdef OS_CHROMEOS"-code you mentioned. Could you give an example?
> I'm curious about the Xrefs in "#ifdef OS_CHROMEOS"-code you mentioned. 
> Could you give an example?

Of course, now I can't remember what I was looking at :). I tried a few examples and they don't seem cross-referenced now, so maybe I was just confused.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/e6aead043608dd9e421106eaf4d1ba7b1a295f70

commit e6aead043608dd9e421106eaf4d1ba7b1a295f70
Author: Adam Chyb <achyb@chromium.org>
Date: Mon Jan 16 03:46:48 2017

Added a builder to create index packs for the Android build of Chromium

BUG= 662136 ,  643026 , 526154

Change-Id: Icc2f8bc57c5fa7d49dacfd9fd22476d768311b04
Reviewed-on: https://chromium-review.googlesource.com/426284
Reviewed-by: Dave Sansome <dsansome@chromium.org>
Reviewed-by: Phil Wright <philwright@chromium.org>
Commit-Queue: Adam Chyb <achyb@chromium.org>

[modify] https://crrev.com/e6aead043608dd9e421106eaf4d1ba7b1a295f70/masters/master.chromium.infra.cron/master.cfg
[modify] https://crrev.com/e6aead043608dd9e421106eaf4d1ba7b1a295f70/masters/master.chromium.infra.cron/slaves.cfg

Mergedinto: 643026
Status: Duplicate (was: Available)

Sign in to add a comment