This issue tracks the move of background_sync from /content/child to Blink (third_party/WebKit/Source).
This issue tracks the move of background_sync from /content to Blink (third_party/WebKit/Source).
Issue 610374 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5b9f3648b7b5008dfadd7929d84e2e8c329c214 commit c5b9f3648b7b5008dfadd7929d84e2e8c329c214 Author: adithyas <adithyas@chromium.org> Date: Fri Nov 18 04:39:55 2016 Move content/child/background_sync to Blink. - Moves background_sync_provider to third_party/WebKit/Source/modules/background_sync - Renames background_sync_provider.(h|cc) to BackgroundSyncProvider.(h|cpp) - Removes WebSyncProvider.h - Removes WebSyncRegistration.h - Changes all files to directly use SyncRegistration instead - Removes unneeded type converters - Remove unneeded tests in background_sync_type_converters_unittest and add 2 new tests NOTE: content/child/background_sync isn't completely removed as background_sync_type_converters.h is still used in content/renderer BUG= 662134 Review-Url: https://codereview.chromium.org/2473483012 Cr-Commit-Position: refs/heads/master@{#433109} [modify] https://crrev.com/c5b9f3648b7b5008dfadd7929d84e2e8c329c214/content/child/BUILD.gn [modify] https://crrev.com/c5b9f3648b7b5008dfadd7929d84e2e8c329c214/content/child/background_sync/OWNERS [delete] https://crrev.com/ece04082b79fd30261b48ad895e7f05beeda7823/content/child/background_sync/background_sync_provider.cc [delete] https://crrev.com/ece04082b79fd30261b48ad895e7f05beeda7823/content/child/background_sync/background_sync_provider.h [modify] https://crrev.com/c5b9f3648b7b5008dfadd7929d84e2e8c329c214/content/child/background_sync/background_sync_type_converters.cc [modify] https://crrev.com/c5b9f3648b7b5008dfadd7929d84e2e8c329c214/content/child/background_sync/background_sync_type_converters.h [delete] https://crrev.com/ece04082b79fd30261b48ad895e7f05beeda7823/content/child/background_sync/background_sync_type_converters_unittest.cc [modify] https://crrev.com/c5b9f3648b7b5008dfadd7929d84e2e8c329c214/content/child/blink_platform_impl.cc [modify] https://crrev.com/c5b9f3648b7b5008dfadd7929d84e2e8c329c214/content/child/blink_platform_impl.h [modify] https://crrev.com/c5b9f3648b7b5008dfadd7929d84e2e8c329c214/content/child/service_worker/web_service_worker_registration_impl.cc [modify] https://crrev.com/c5b9f3648b7b5008dfadd7929d84e2e8c329c214/content/child/service_worker/web_service_worker_registration_impl.h [modify] https://crrev.com/c5b9f3648b7b5008dfadd7929d84e2e8c329c214/content/renderer/background_sync/background_sync_client_impl.cc [modify] https://crrev.com/c5b9f3648b7b5008dfadd7929d84e2e8c329c214/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/c5b9f3648b7b5008dfadd7929d84e2e8c329c214/content/test/BUILD.gn [modify] https://crrev.com/c5b9f3648b7b5008dfadd7929d84e2e8c329c214/third_party/WebKit/Source/modules/background_sync/BUILD.gn [add] https://crrev.com/c5b9f3648b7b5008dfadd7929d84e2e8c329c214/third_party/WebKit/Source/modules/background_sync/BackgroundSyncProvider.cpp [add] https://crrev.com/c5b9f3648b7b5008dfadd7929d84e2e8c329c214/third_party/WebKit/Source/modules/background_sync/BackgroundSyncProvider.h [modify] https://crrev.com/c5b9f3648b7b5008dfadd7929d84e2e8c329c214/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp [modify] https://crrev.com/c5b9f3648b7b5008dfadd7929d84e2e8c329c214/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.h [modify] https://crrev.com/c5b9f3648b7b5008dfadd7929d84e2e8c329c214/third_party/WebKit/Source/modules/background_sync/SyncManager.cpp [modify] https://crrev.com/c5b9f3648b7b5008dfadd7929d84e2e8c329c214/third_party/WebKit/Source/modules/background_sync/SyncManager.h [modify] https://crrev.com/c5b9f3648b7b5008dfadd7929d84e2e8c329c214/third_party/WebKit/public/BUILD.gn [modify] https://crrev.com/c5b9f3648b7b5008dfadd7929d84e2e8c329c214/third_party/WebKit/public/platform/modules/background_sync/WebSyncClient.h [delete] https://crrev.com/ece04082b79fd30261b48ad895e7f05beeda7823/third_party/WebKit/public/platform/modules/background_sync/WebSyncProvider.h [delete] https://crrev.com/ece04082b79fd30261b48ad895e7f05beeda7823/third_party/WebKit/public/platform/modules/background_sync/WebSyncRegistration.h [modify] https://crrev.com/c5b9f3648b7b5008dfadd7929d84e2e8c329c214/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af8916be3799b8cbb9f45992564e69ca53f23b85 commit af8916be3799b8cbb9f45992564e69ca53f23b85 Author: adithyas <adithyas@chromium.org> Date: Fri Nov 18 18:41:13 2016 Replace registration_id() with registrationId() - Follow up to http://crrev.com/2473483012 BUG= 662134 Review-Url: https://codereview.chromium.org/2489883006 Cr-Commit-Position: refs/heads/master@{#433249} [modify] https://crrev.com/af8916be3799b8cbb9f45992564e69ca53f23b85/content/child/notifications/notification_manager.cc [modify] https://crrev.com/af8916be3799b8cbb9f45992564e69ca53f23b85/content/child/push_messaging/push_provider.cc [modify] https://crrev.com/af8916be3799b8cbb9f45992564e69ca53f23b85/content/child/service_worker/service_worker_dispatcher_unittest.cc [modify] https://crrev.com/af8916be3799b8cbb9f45992564e69ca53f23b85/content/child/service_worker/web_service_worker_registration_impl.cc [modify] https://crrev.com/af8916be3799b8cbb9f45992564e69ca53f23b85/content/child/service_worker/web_service_worker_registration_impl.h [modify] https://crrev.com/af8916be3799b8cbb9f45992564e69ca53f23b85/content/renderer/push_messaging/push_messaging_dispatcher.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/958b47bdc79d4636041ee59a0ac7874dfca84bba commit 958b47bdc79d4636041ee59a0ac7874dfca84bba Author: adithyas <adithyas@chromium.org> Date: Mon Nov 21 18:03:49 2016 [background-sync] Remove WebSyncError and SyncCallbacks - Follow up to http://crrev.com/2473483012 - Remove WebSyncError and SyncError - Remove SyncCallbacks and put all functionality inside BackgroundSyncProvider directly - Remove WebSyncClient.h (file was not being used anywhere) BUG= 662134 Review-Url: https://codereview.chromium.org/2481393002 Cr-Commit-Position: refs/heads/master@{#433584} [modify] https://crrev.com/958b47bdc79d4636041ee59a0ac7874dfca84bba/content/child/background_sync/background_sync_type_converters.h [modify] https://crrev.com/958b47bdc79d4636041ee59a0ac7874dfca84bba/third_party/WebKit/Source/modules/background_sync/BUILD.gn [modify] https://crrev.com/958b47bdc79d4636041ee59a0ac7874dfca84bba/third_party/WebKit/Source/modules/background_sync/BackgroundSyncProvider.cpp [modify] https://crrev.com/958b47bdc79d4636041ee59a0ac7874dfca84bba/third_party/WebKit/Source/modules/background_sync/BackgroundSyncProvider.h [delete] https://crrev.com/e433c7369c43f6278d0effa8ad6903073dafcc70/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp [delete] https://crrev.com/e433c7369c43f6278d0effa8ad6903073dafcc70/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.h [delete] https://crrev.com/e433c7369c43f6278d0effa8ad6903073dafcc70/third_party/WebKit/Source/modules/background_sync/SyncError.cpp [delete] https://crrev.com/e433c7369c43f6278d0effa8ad6903073dafcc70/third_party/WebKit/Source/modules/background_sync/SyncError.h [modify] https://crrev.com/958b47bdc79d4636041ee59a0ac7874dfca84bba/third_party/WebKit/Source/modules/background_sync/SyncManager.cpp [modify] https://crrev.com/958b47bdc79d4636041ee59a0ac7874dfca84bba/third_party/WebKit/public/BUILD.gn [delete] https://crrev.com/e433c7369c43f6278d0effa8ad6903073dafcc70/third_party/WebKit/public/platform/modules/background_sync/WebSyncClient.h [delete] https://crrev.com/e433c7369c43f6278d0effa8ad6903073dafcc70/third_party/WebKit/public/platform/modules/background_sync/WebSyncError.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34efa35374cb3073a3cfb364e4a2cf9aa3273f0a commit 34efa35374cb3073a3cfb364e4a2cf9aa3273f0a Author: adithyas <adithyas@chromium.org> Date: Mon Nov 21 22:07:15 2016 [background-sync] Merge SyncManager and BackgroundSyncProvider - Follow up to http://crrev.com/2481393002 - Move BackgroundSyncProvider code into SyncManger - A seperate mojo IPC connection with the browser's BackgroundSyncService is now created per SyncManager object as opposed to per thread - Remove BackgroundSyncProvider.(h|cpp) BUG= 662134 Review-Url: https://codereview.chromium.org/2515353002 Cr-Commit-Position: refs/heads/master@{#433667} [modify] https://crrev.com/34efa35374cb3073a3cfb364e4a2cf9aa3273f0a/third_party/WebKit/Source/modules/background_sync/BUILD.gn [delete] https://crrev.com/aaf0f3966ce45a662c6ddc940fb48cf2174be35c/third_party/WebKit/Source/modules/background_sync/BackgroundSyncProvider.cpp [delete] https://crrev.com/aaf0f3966ce45a662c6ddc940fb48cf2174be35c/third_party/WebKit/Source/modules/background_sync/BackgroundSyncProvider.h [modify] https://crrev.com/34efa35374cb3073a3cfb364e4a2cf9aa3273f0a/third_party/WebKit/Source/modules/background_sync/SyncManager.cpp [modify] https://crrev.com/34efa35374cb3073a3cfb364e4a2cf9aa3273f0a/third_party/WebKit/Source/modules/background_sync/SyncManager.h
https://crrev.com/317dd7b50bd2f138715fac044dcc44ce070ccbfc refactors out /content/renderer/background_sync into service_worker. /content/child/background_sync was moved to Blink in https://crrev.com/c5b9f3648b7b5008dfadd7929d84e2e8c329c214. I think there's no more work to be done for this issue so I'm closing it.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/397ae6590bdb938c77156c9218b79c286b4bb5cd commit 397ae6590bdb938c77156c9218b79c286b4bb5cd Author: Peter Beverloo <peter@chromium.org> Date: Wed Dec 13 12:14:06 2017 Remove the BackgroundSyncEventLastChance enum We're converting from a boolean to this enum on the browser side, and then converting it back to a boolean once received on the renderer side. Let's simplify and just pass the boolean -- its name is clear. This also removes the remaining Background Sync code from //content/renderer/. Bug: 662134 Change-Id: Idd871f44f13e6804b48f83c6f4987572b1b7f125 Reviewed-on: https://chromium-review.googlesource.com/822530 Reviewed-by: Josh Karlin <jkarlin@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#523751} [modify] https://crrev.com/397ae6590bdb938c77156c9218b79c286b4bb5cd/content/browser/background_sync/background_sync_manager.cc [modify] https://crrev.com/397ae6590bdb938c77156c9218b79c286b4bb5cd/content/browser/background_sync/background_sync_manager.h [modify] https://crrev.com/397ae6590bdb938c77156c9218b79c286b4bb5cd/content/browser/background_sync/background_sync_manager_unittest.cc [modify] https://crrev.com/397ae6590bdb938c77156c9218b79c286b4bb5cd/content/browser/service_worker/embedded_worker_test_helper.cc [modify] https://crrev.com/397ae6590bdb938c77156c9218b79c286b4bb5cd/content/common/service_worker/service_worker_event_dispatcher.mojom [modify] https://crrev.com/397ae6590bdb938c77156c9218b79c286b4bb5cd/content/renderer/BUILD.gn [delete] https://crrev.com/05e053f3aece950d379f1fe874c1cf37d089ee80/content/renderer/background_sync/OWNERS [delete] https://crrev.com/05e053f3aece950d379f1fe874c1cf37d089ee80/content/renderer/background_sync/background_sync_type_converters.cc [delete] https://crrev.com/05e053f3aece950d379f1fe874c1cf37d089ee80/content/renderer/background_sync/background_sync_type_converters.h [modify] https://crrev.com/397ae6590bdb938c77156c9218b79c286b4bb5cd/content/renderer/service_worker/service_worker_context_client.cc [modify] https://crrev.com/397ae6590bdb938c77156c9218b79c286b4bb5cd/content/renderer/service_worker/service_worker_context_client.h [modify] https://crrev.com/397ae6590bdb938c77156c9218b79c286b4bb5cd/content/renderer/service_worker/service_worker_context_client_unittest.cc [modify] https://crrev.com/397ae6590bdb938c77156c9218b79c286b4bb5cd/content/test/test_background_sync_manager.cc [modify] https://crrev.com/397ae6590bdb938c77156c9218b79c286b4bb5cd/content/test/test_background_sync_manager.h [modify] https://crrev.com/397ae6590bdb938c77156c9218b79c286b4bb5cd/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.cpp [modify] https://crrev.com/397ae6590bdb938c77156c9218b79c286b4bb5cd/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.h [modify] https://crrev.com/397ae6590bdb938c77156c9218b79c286b4bb5cd/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextProxy.h
Comment 1 by jbroman@chromium.org
, Nov 17 2016