New issue
Advanced search Search tips

Issue 662122 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocked on:
issue 660930
issue 684080

Blocking:
issue 706512
issue 653916



Sign in to add a comment

Add Single-Threaded COM support to TaskScheduler

Project Member Reported by gab@chromium.org, Nov 3 2016

Issue description

Tracking STA COM feature work for TaskScheduler.

 

Comment 1 by gab@chromium.org, Nov 7 2016

Components: Internals>TaskScheduler

Comment 2 by gab@chromium.org, Nov 18 2016

Labels: -M-56 M-57
Blockedon: 684080
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1af04705b43547c1b6fef0080c092aae06b1dca8

commit 1af04705b43547c1b6fef0080c092aae06b1dca8
Author: robliao <robliao@chromium.org>
Date: Mon Mar 20 23:26:41 2017

Add WaitForWork to SchedulerWorker::Delegate

This will allow the COM delegate to wait on both the Windows message
queue and the SchedulerWorker WakeUp event a la
MsgWaitForMultipleObjects.

Reference Changelist:
https://codereview.chromium.org/2762703002

BUG= 662122 

Review-Url: https://codereview.chromium.org/2759203002
Cr-Commit-Position: refs/heads/master@{#458233}

[modify] https://crrev.com/1af04705b43547c1b6fef0080c092aae06b1dca8/base/task_scheduler/scheduler_worker.cc
[modify] https://crrev.com/1af04705b43547c1b6fef0080c092aae06b1dca8/base/task_scheduler/scheduler_worker.h

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80891393a521ee82efb1d9c513e540baa270dd02

commit 80891393a521ee82efb1d9c513e540baa270dd02
Author: robliao <robliao@chromium.org>
Date: Wed Mar 22 22:30:15 2017

Add the COM STA Task Runner

The COM STA Task Runner executes tasks in a COM STA. Task runners in
the future may share STAs, so callers should not assume STAs are shared
or are dedicated.

Callers requiring tasks to run in the same STA should post to the same
task runner.

BUG= 662122 

Review-Url: https://codereview.chromium.org/2765703002
Cr-Commit-Position: refs/heads/master@{#458900}

[modify] https://crrev.com/80891393a521ee82efb1d9c513e540baa270dd02/base/task_scheduler/scheduler_single_thread_task_runner_manager.cc
[modify] https://crrev.com/80891393a521ee82efb1d9c513e540baa270dd02/base/task_scheduler/scheduler_single_thread_task_runner_manager.h
[modify] https://crrev.com/80891393a521ee82efb1d9c513e540baa270dd02/base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75dd50b325a709221dd971e61eb3e6f53de1a8aa

commit 75dd50b325a709221dd971e61eb3e6f53de1a8aa
Author: robliao <robliao@chromium.org>
Date: Wed Mar 29 17:11:17 2017

Add Support to Get a COM STA Task Runner from the Task Scheduler API

This also adds support for COM STA Task Runner for TaskSchedulerImpl as
well as ScopedTaskScheduler.

BUG= 662122 

Review-Url: https://codereview.chromium.org/2768873007
Cr-Commit-Position: refs/heads/master@{#460430}

[modify] https://crrev.com/75dd50b325a709221dd971e61eb3e6f53de1a8aa/base/task_scheduler/post_task.cc
[modify] https://crrev.com/75dd50b325a709221dd971e61eb3e6f53de1a8aa/base/task_scheduler/post_task.h
[modify] https://crrev.com/75dd50b325a709221dd971e61eb3e6f53de1a8aa/base/task_scheduler/task_scheduler.h
[modify] https://crrev.com/75dd50b325a709221dd971e61eb3e6f53de1a8aa/base/task_scheduler/task_scheduler_impl.cc
[modify] https://crrev.com/75dd50b325a709221dd971e61eb3e6f53de1a8aa/base/task_scheduler/task_scheduler_impl.h
[modify] https://crrev.com/75dd50b325a709221dd971e61eb3e6f53de1a8aa/base/task_scheduler/task_scheduler_impl_unittest.cc
[modify] https://crrev.com/75dd50b325a709221dd971e61eb3e6f53de1a8aa/base/test/scoped_task_scheduler.cc
[modify] https://crrev.com/75dd50b325a709221dd971e61eb3e6f53de1a8aa/base/test/scoped_task_scheduler.h
[modify] https://crrev.com/75dd50b325a709221dd971e61eb3e6f53de1a8aa/base/test/scoped_task_scheduler_unittest.cc

Description: Show this description
Description: Show this description
Status: Fixed (was: Started)
Summary: Add Single-Threaded COM support to TaskScheduler (was: Add COM support to TaskScheduler)

Comment 11 by gab@chromium.org, Mar 29 2017

Can you open a bug to get rid of SchedulerBackwardCompatibility::INIT_COM_STA usage now (especially outside of redirection use cases -- e.g. I'm thinking of the recent addition to service process which would be better served by an explicit STATaskRunner request from the printing code).
Blocking: 706512
Done: http://crbug.com/706512

Sign in to add a comment