New issue
Advanced search Search tips

Issue 662118 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

pipeline_integration_tests don't handle nonzero media start or unknown duration media.

Project Member Reported by liber...@chromium.org, Nov 3 2016

Issue description

PipelineIntegrationTestBase gets mad if more than one call to Pipeline::Client::OnDurationChanged occurs.  However, this can happen legitimately if the media duration is unknown, but later inferred when the end of media is reached.

It also should expose the media start time, so that one can seek to the beginning of the media rather than to 0.  Otherwise, PipelineIntegrationTestBase::Seek will get mad if one seeks earlier than the media start time, when it notices that the media time after the seek isn't exactly the seek time that the caller requested.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc29809b850a2dcd2f803d4f25238085f64d7906

commit bc29809b850a2dcd2f803d4f25238085f64d7906
Author: liberato <liberato@chromium.org>
Date: Thu Nov 03 20:45:08 2016

Fix pipeline integration tests for seek / duration changes.

PipelineIntegrationTestBase now exposes GetMediaDuration(), so that
tests can seek to the start of the media, rather than assuming it to
be zero.  The ffmpeg_regression_tests would fail, previously, if the
media's start time wasn't zero, since they would seek to 0 and then
get mad that the media time was something else.

Also, this permits the pipeline to notify the client about an
indefinite duration, then notify it about a smaller one.  This
happens if the media duration isn't known initially, but then
becomes known when the end of media is found.  Previously, the
second call to Pipeline::Client::OnDurationChanged would cause
the integration test base to get mad.

Added a test case to ffmpeg_regression_tests which hits both of
these cases.

BUG= 662118 
TEST=ffmpeg_regression_tests

Review-Url: https://codereview.chromium.org/2479633002
Cr-Commit-Position: refs/heads/master@{#429690}

[modify] https://crrev.com/bc29809b850a2dcd2f803d4f25238085f64d7906/media/ffmpeg/ffmpeg_regression_tests.cc
[modify] https://crrev.com/bc29809b850a2dcd2f803d4f25238085f64d7906/media/test/pipeline_integration_test_base.cc
[modify] https://crrev.com/bc29809b850a2dcd2f803d4f25238085f64d7906/media/test/pipeline_integration_test_base.h

Status: Fixed (was: Started)

Sign in to add a comment