New issue
Advanced search Search tips

Issue 662115 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

After CC scan, the billing address is being incorrectly populated

Project Member Reported by zkoch@chromium.org, Nov 3 2016

Issue description

Version: Canary

What steps will reproduce the problem?
(1) Open add card flow
(2) Choose scan card
(3) Scan the card
(4) See data from card populated

What is the expected output?

Billing address remains unselected

What do you see instead?

Billing address is being populated with the first set in the list

Please use labels and text to provide additional information.

 

Comment 1 by zkoch@chromium.org, Nov 3 2016

Status: Assigned (was: ass)
:D
Components: UI>Browser>Autofill>Payments
Labels: M-56 OS-Android
Owner: se...@chromium.org
sebsg, this is due to moving the "select" item from position 0 to position "n". Can you change this line:

https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java?rcl=0&l=151

...to be "return dropdownKeyValues.size();" instead and see if the issue is fixed?

You can simulate card-scanning on your local dev build by hard-coding mCanScan=true and changing mCardScanner.scan() call to be onScanCompleted() instead. (Only for your local testing, of course.)

https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java?rcl=0&l=400

Comment 3 by se...@chromium.org, Nov 3 2016

Status: Started (was: Assigned)
Yeah this would work now but will probably not once the multiple "Select" fix has landed. I'll investigate, thanks for the tips :)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d128a135ff5b12e0c581a1e137b7d852cb96a5d

commit 7d128a135ff5b12e0c581a1e137b7d852cb96a5d
Author: sebsg <sebsg@chromium.org>
Date: Fri Nov 04 22:18:30 2016

[Payments] Fix credit card scanning billing address bug.

BUG= 662115 

Review-Url: https://codereview.chromium.org/2475323003
Cr-Commit-Position: refs/heads/master@{#430034}

[modify] https://crrev.com/7d128a135ff5b12e0c581a1e137b7d852cb96a5d/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java

Comment 5 by se...@chromium.org, Nov 8 2016

Status: Fixed (was: Started)

Comment 6 by zkoch@chromium.org, Nov 8 2016

Seb, can you merge this into M55, since CC scanning is available in M55?

Comment 7 by se...@chromium.org, Nov 8 2016

Labels: -M-56 M-55 Merge-Request-55
Sure!

Comment 8 by se...@chromium.org, Nov 8 2016

Labels: -M-55 -Merge-Request-55 M-56

Comment 9 by se...@chromium.org, Nov 8 2016

Oh wait, I think the issue was introduced in a M56 feature (hide the select option from the dropdown) So the issue should be inexistant in M55
OK, SG :)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment