Feedback from TAG review changed the Web Bluetooth spec [1] to use a descriptive term. Change all of Web Bluetooth in content/*/bluetooth and webkit/modules/bluetooth to use 'blocklist' instead of 'blacklist'. This code search [2] is a good start at finding all instances, likely with few if any false positives. [1] https://github.com/WebBluetoothCG/web-bluetooth/issues/327 [2] https://cs.chromium.org/search/?sq=package:chromium&type=cs&q=f:/bluetooth/+blacklist
Feedback from TAG review changed the Web Bluetooth spec [1] to use a descriptive term. Change all of Web Bluetooth in content/*/bluetooth and webkit/modules/bluetooth to use 'blocklist' instead of 'blacklist'. Code search [2][3] is a good start at finding all instances, likely with few if any false positives. [1] https://github.com/WebBluetoothCG/web-bluetooth/issues/327 [2] https://cs.chromium.org/search/?sq=package:chromium&type=cs&q=f:/bluetooth/+blacklist [3] https://cs.chromium.org/search/?q=WebBluetoothBlacklist&sq=package:chromium&type=cs
WIP at https://codereview.chromium.org/2488283003
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01135bffec64608e65c787ea0345691638831f5e commit 01135bffec64608e65c787ea0345691638831f5e Author: beaufort.francois <beaufort.francois@gmail.com> Date: Wed Nov 23 14:37:36 2016 bluetooth: web: Rename Blacklist to Blocklist BUG= 662106 Review-Url: https://codereview.chromium.org/2488283003 Cr-Commit-Position: refs/heads/master@{#434163} [modify] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/chrome/browser/chrome_content_browser_client.h [modify] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/chrome/browser/web_bluetooth_browsertest.cc [modify] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/content/browser/BUILD.gn [modify] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/content/browser/bluetooth/bluetooth_allowed_devices_map.cc [rename] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/content/browser/bluetooth/bluetooth_blocklist.cc [rename] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/content/browser/bluetooth/bluetooth_blocklist.h [rename] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/content/browser/bluetooth/bluetooth_blocklist_unittest.cc [modify] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/content/browser/bluetooth/bluetooth_device_chooser_controller.cc [modify] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/content/browser/bluetooth/bluetooth_device_chooser_controller.h [modify] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/content/browser/bluetooth/bluetooth_metrics.h [modify] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/content/browser/bluetooth/web_bluetooth_service_impl.cc [modify] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/content/public/browser/content_browser_client.cc [modify] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/content/public/browser/content_browser_client.h [modify] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc [modify] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h [modify] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/content/test/BUILD.gn [modify] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/testing/variations/fieldtrial_testing_config.json [rename] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/third_party/WebKit/LayoutTests/bluetooth/getCharacteristic/blocklisted-characteristic.html [rename] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/blocklisted-characteristics-with-uuid.html [rename] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/blocklisted-characteristics.html [rename] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/blocklisted-services-with-uuid.html [rename] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/blocklisted-services.html [rename] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/third_party/WebKit/LayoutTests/bluetooth/readValue/blocklisted-characteristic.html [rename] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/third_party/WebKit/LayoutTests/bluetooth/requestDevice/blocklisted-service-in-filter.html [rename] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/third_party/WebKit/LayoutTests/bluetooth/requestDevice/blocklisted-service-in-optionalServices.html [rename] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/third_party/WebKit/LayoutTests/bluetooth/writeValue/blocklisted-characteristic.html [add] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/third_party/WebKit/LayoutTests/imported/wpt/bluetooth/bluetooth-helpers.js [modify] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js [modify] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp [modify] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/wbt_fakes.py [modify] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom [modify] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/tools/metrics/histograms/histograms.xml [rename] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/tools/web_bluetooth/compact_blocklist.py [rename] https://crrev.com/01135bffec64608e65c787ea0345691638831f5e/tools/web_bluetooth/compact_blocklist_unittest.py
Your change meets the bar and is auto-approved for M56 (branch: 2924)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1210b726077a1522db654a2c027e7b466dc5257 commit d1210b726077a1522db654a2c027e7b466dc5257 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Wed Dec 07 04:48:26 2016 bluetooth: web: Rename Blacklist to Blocklist BUG= 662106 Review-Url: https://codereview.chromium.org/2488283003 Cr-Commit-Position: refs/heads/master@{#434163} (cherry picked from commit 01135bffec64608e65c787ea0345691638831f5e) Review URL: https://codereview.chromium.org/2554253002 . Cr-Commit-Position: refs/branch-heads/2924@{#372} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/chrome/browser/chrome_content_browser_client.h [modify] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/chrome/browser/web_bluetooth_browsertest.cc [modify] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/content/browser/BUILD.gn [modify] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/content/browser/bluetooth/bluetooth_allowed_devices_map.cc [rename] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/content/browser/bluetooth/bluetooth_blocklist.cc [rename] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/content/browser/bluetooth/bluetooth_blocklist.h [rename] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/content/browser/bluetooth/bluetooth_blocklist_unittest.cc [modify] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/content/browser/bluetooth/bluetooth_device_chooser_controller.cc [modify] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/content/browser/bluetooth/bluetooth_device_chooser_controller.h [modify] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/content/browser/bluetooth/bluetooth_metrics.h [modify] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/content/browser/bluetooth/web_bluetooth_service_impl.cc [modify] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/content/public/browser/content_browser_client.cc [modify] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/content/public/browser/content_browser_client.h [modify] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc [modify] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h [modify] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/content/test/BUILD.gn [modify] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/testing/variations/fieldtrial_testing_config.json [rename] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/third_party/WebKit/LayoutTests/bluetooth/getCharacteristic/blocklisted-characteristic.html [rename] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/blocklisted-characteristics-with-uuid.html [rename] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/blocklisted-characteristics.html [rename] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/blocklisted-services-with-uuid.html [rename] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/blocklisted-services.html [rename] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/third_party/WebKit/LayoutTests/bluetooth/readValue/blocklisted-characteristic.html [rename] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/third_party/WebKit/LayoutTests/bluetooth/requestDevice/blocklisted-service-in-filter.html [rename] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/third_party/WebKit/LayoutTests/bluetooth/requestDevice/blocklisted-service-in-optionalServices.html [rename] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/third_party/WebKit/LayoutTests/bluetooth/writeValue/blocklisted-characteristic.html [modify] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js [modify] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp [modify] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/wbt_fakes.py [modify] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom [modify] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/tools/metrics/histograms/histograms.xml [rename] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/tools/web_bluetooth/compact_blocklist.py [rename] https://crrev.com/d1210b726077a1522db654a2c027e7b466dc5257/tools/web_bluetooth/compact_blocklist_unittest.py
Comment 1 by scheib@chromium.org
, Nov 3 2016