Enable downloads UI for NTP-saved pages. |
|||||||
Issue descriptionToday, if the context menu for saving an NTP item for later is pressed, we will save the page but not display a notification or show it in the Downloads Home. This bug tracks enabling the download for offline context menu item on the NTP.
,
Nov 4 2016
,
Nov 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4f09d3d0165b9b5c8316b78d6186bcd7b6df8d4 commit d4f09d3d0165b9b5c8316b78d6186bcd7b6df8d4 Author: dewittj <dewittj@chromium.org> Date: Fri Nov 04 10:46:42 2016 Switch NTP to use the string for downloading a page. * before: Save linked page for later * after: Download link BUG= 662105 Review-Url: https://codereview.chromium.org/2480643002 Cr-Commit-Position: refs/heads/master@{#429848} [modify] https://crrev.com/d4f09d3d0165b9b5c8316b78d6186bcd7b6df8d4/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuHandler.java
,
Nov 4 2016
Merge request for the commits in #1 and #3
,
Nov 4 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Nov 4 2016
Waiting till Monday to proceed with Merge, to give the commits some time to bake on Canary.
,
Nov 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb84a1f6864dc62f8ed4fe48a64d111c1bbea774 commit bb84a1f6864dc62f8ed4fe48a64d111c1bbea774 Author: Justin DeWitt <dewittj@chromium.org> Date: Mon Nov 07 21:29:47 2016 Enable downloads UI for NTP-saved pages. This patch fixes 3 problems: * The NTP code is gated on a flag in offline pages that is only for testing. * The NTP namespace is marked as "Supported by Download", which allows the download home to show these pages, and the download notification to work for these pages. BUG= 662105 Review-Url: https://codereview.chromium.org/2473953006 Cr-Commit-Position: refs/heads/master@{#429727} (cherry picked from commit b637ece132d7e0a975f0780724f8354297552fcd) Review URL: https://codereview.chromium.org/2481343003 . Cr-Commit-Position: refs/branch-heads/2883@{#484} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/bb84a1f6864dc62f8ed4fe48a64d111c1bbea774/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java [modify] https://crrev.com/bb84a1f6864dc62f8ed4fe48a64d111c1bbea774/components/offline_pages/client_policy_controller.cc [modify] https://crrev.com/bb84a1f6864dc62f8ed4fe48a64d111c1bbea774/components/offline_pages/client_policy_controller_unittest.cc [modify] https://crrev.com/bb84a1f6864dc62f8ed4fe48a64d111c1bbea774/components/offline_pages/downloads/download_notifying_observer_unittest.cc
,
Nov 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e64ee0d637f04d3c11c5af6a74fb2bd74a7c3e1c commit e64ee0d637f04d3c11c5af6a74fb2bd74a7c3e1c Author: Justin DeWitt <dewittj@chromium.org> Date: Mon Nov 07 23:15:56 2016 Switch NTP to use the string for downloading a page. * before: Save linked page for later * after: Download link BUG= 662105 TBR=peconn@chromium.org Review-Url: https://codereview.chromium.org/2480643002 Cr-Commit-Position: refs/heads/master@{#429848} (cherry picked from commit d4f09d3d0165b9b5c8316b78d6186bcd7b6df8d4) Review URL: https://codereview.chromium.org/2485733002 . Cr-Commit-Position: refs/branch-heads/2883@{#487} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/e64ee0d637f04d3c11c5af6a74fb2bd74a7c3e1c/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
,
Nov 8 2016
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Nov 3 2016