New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 662102 link

Starred by 1 user
Status: Fixed
Owner:
█ xunji...@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
█ kapishnikov@chromium.org
mef@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Cannot cancel a cronet_bidirectional_stream during write.

Project Member Reported by mxyan@google.com, Nov 3 2016 
Version of Google Chrome (Wrench-> About Google Chrome): cronet_c_for_grpc 56.0.2907
Using group policy settings? N/A

When cronet_bidirectional_stream_cancel() is invoked after cronet_bidirectional_stream_write() but before on_write_completed() is issued, Cronet seems to emits  "Check failed: !write_pending_" at bidirectional_stream_spdy_impl.cc:(51).

Comment 1 by ligim...@chromium.org, Nov 3 2016

Cc: pbomm...@chromium.org gov...@chromium.org ligim...@chromium.org
Labels: -Type-Bug -Pri-3 ReleaseBlock-Stable M-55 Pri-1 Type-Bug-Regression
Owner: xunji...@chromium.org
Status: Assigned (was: Unconfirmed)
The part of the code at bidirectional_stream_spdy_impl.cc was modified by - https://chromium.googlesource.com/chromium/src/+/9ff75c568c5feb797f1dd2dec7bd74577f8e0212

Assigning the Owner for confirmation.

M54 is already in Stable, so please target for a fix in M55.

Comment 2 by gov...@chromium.org, Nov 3 2016

Cc: blumberg@chromium.org

Comment 3 by gov...@chromium.org, Nov 3 2016 

Is this bug applicable to any specific OS or all OSs?

Comment 4 by mxyan@google.com, Nov 3 2016 

Oh sorry I should have mentioned that this is discovered on iOS; I did not try other OS yet.

Comment 5 by gov...@chromium.org, Nov 3 2016

Cc: cma...@chromium.org
Labels: OS-iOS
Applying "iOS" label per comment #4. Please do update the bug if you see this issue on any other OSs. Thank you.

Comment 6 by xunji...@chromium.org, Nov 7 2016

Cc: -gov...@chromium.org -cma...@chromium.org -pbomm...@chromium.org -ligim...@chromium.org -blumberg@chromium.org kapishnikov@chromium.org mef@chromium.org
Components: -Enterprise Internals>Network>Library
Labels: -M-55 -ReleaseBlock-Stable M-56 OS-Android
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/196eed536c508fcbff652fa185a1d390c68761cc

commit 196eed536c508fcbff652fa185a1d390c68761cc
Author: xunjieli <xunjieli@chromium.org>
Date: Mon Nov 07 22:38:32 2016

Remove DCHECK(!write_pending_) in BidirectionalStreamSpdyImpl's destructor

When BidirectionalStreamSpdyImpl is being destroyed, we shouldn't
DCHECK on |write_pending_| because the destruction can be due to
cancellation at which point the embedder doesn't care about
pending write.

BUG= 662102 

Review-Url: https://codereview.chromium.org/2481353002
Cr-Commit-Position: refs/heads/master@{#430403}

[modify] https://crrev.com/196eed536c508fcbff652fa185a1d390c68761cc/net/spdy/bidirectional_stream_spdy_impl.cc

Comment 8 by xunji...@chromium.org, Nov 7 2016

Status: Fixed (was: Started)
►

Sign in to add a comment