New issue
Advanced search Search tips

Issue 662097 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 662079
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Window button layout is broken in Sierra RTL

Project Member Reported by lgrey@chromium.org, Nov 3 2016

Issue description

Sierra reverses the window buttons when launching programs in RTL mode. We calculate the size between window buttons based on the gap between the close and miniaturize buttons, but when the buttons are reversed this is incorrect. The result is a large gap between buttons, pushing one offscreen (see attached image).

 
Screen Shot 2016-11-02 at 4.42.03 PM.png
16.3 KB View Download

Comment 1 by lgrey@chromium.org, Nov 3 2016

Components: UI>Browser>Core

Comment 2 by lgrey@chromium.org, Nov 3 2016

Mergedinto: 662079
Status: Duplicate (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa5cecc6e5507dc0497b09a3295c9c467e0c64d5

commit fa5cecc6e5507dc0497b09a3295c9c467e0c64d5
Author: lgrey <lgrey@chromium.org>
Date: Thu Nov 03 20:15:41 2016

[Mac] Take Sierra RTL into account when laying out window buttons

Sierra reverses the window buttons when launching programs in RTL
mode. We calculate the size between window buttons based on the gap
between the close and miniaturize buttons, but when the buttons are
reversed this is incorrect. The result is a large gap between buttons,
pushing one offscreen (see image in bug.)

BUG= 662097 

Review-Url: https://codereview.chromium.org/2468373003
Cr-Commit-Position: refs/heads/master@{#429684}

[modify] https://crrev.com/fa5cecc6e5507dc0497b09a3295c9c467e0c64d5/chrome/browser/ui/cocoa/framed_browser_window.mm
[modify] https://crrev.com/fa5cecc6e5507dc0497b09a3295c9c467e0c64d5/chrome/browser/ui/cocoa/framed_browser_window_unittest.mm

Comment 4 by shrike@chromium.org, Nov 15 2016

Labels: Proj-MacRTL

Sign in to add a comment