[REGRESSION] DevTools: node.js breakpoints do not work on tip-of-tree chromium |
||
Issue descriptionChrome Version : 56 What steps will reproduce the problem? 1. Start node.js debugging 2. Set a breakpoint in node.js script in devtools front-end What is the expected result? DevTools stop on breakpoints. What happens instead of that? DevTools don't stop on breakpoints.
,
Nov 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f07ac873c3b8c70d31de57e15d5daac00ab95df7 commit f07ac873c3b8c70d31de57e15d5daac00ab95df7 Author: lushnikov <lushnikov@chromium.org> Date: Thu Nov 03 19:04:50 2016 DevTools: fix breakpoints in Node.js We assume that scripts either have a sane URL. As of today, node.js reports a file path instead of URL - which is not a URL. For this reason, when the script enters DevTools front-end, we convert the file path into URL (with a file:// protocol). This patch additionally starts converting file URLs back to script paths when necessary to support setBreakpointByURL protocol method. BUG= 662082 R=dgozman, kozyatinskiy Review-Url: https://codereview.chromium.org/2477483002 Cr-Commit-Position: refs/heads/master@{#429661} [add] https://crrev.com/f07ac873c3b8c70d31de57e15d5daac00ab95df7/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/nodejs-set-breakpoint-expected.txt [add] https://crrev.com/f07ac873c3b8c70d31de57e15d5daac00ab95df7/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/nodejs-set-breakpoint.html [modify] https://crrev.com/f07ac873c3b8c70d31de57e15d5daac00ab95df7/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
,
Nov 3 2016
The workarounds introduced here should be mitigated once the crbug.com/662204 is done. |
||
►
Sign in to add a comment |
||
Comment 1 by lushnikov@chromium.org
, Nov 3 2016