New issue
Advanced search Search tips

Issue 662081 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 657982



Sign in to add a comment

DevTools: Unify the Command Menu and Open File Dialog

Project Member Reported by einbinder@chromium.org, Nov 3 2016

Issue description

The Ctrl+P open file dialog box, the Ctrl+Shift+P command menu, and other similar dialog boxes should be combined into a single dialog that a user types a query into.
 
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3854543fdcea4ffd600b2a0fbef5ef59c4ba1388

commit 3854543fdcea4ffd600b2a0fbef5ef59c4ba1388
Author: einbinder <einbinder@chromium.org>
Date: Thu Mar 09 00:30:08 2017

DevTools: Convert FilteredListWidget to use an optional provider

Instead of a single required delegate, FilteredListWidget now uses a
provider that can be changed.

BUG= 662081 

Review-Url: https://codereview.chromium.org/2736853002
Cr-Commit-Position: refs/heads/master@{#455611}

[modify] https://crrev.com/3854543fdcea4ffd600b2a0fbef5ef59c4ba1388/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js
[add] https://crrev.com/3854543fdcea4ffd600b2a0fbef5ef59c4ba1388/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-list-widget-providers-expected.txt
[add] https://crrev.com/3854543fdcea4ffd600b2a0fbef5ef59c4ba1388/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-list-widget-providers.js
[modify] https://crrev.com/3854543fdcea4ffd600b2a0fbef5ef59c4ba1388/third_party/WebKit/LayoutTests/inspector/filtered-item-selection-dialog-rendering.html
[modify] https://crrev.com/3854543fdcea4ffd600b2a0fbef5ef59c4ba1388/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/3854543fdcea4ffd600b2a0fbef5ef59c4ba1388/third_party/WebKit/Source/devtools/front_end/quick_open/CommandMenu.js
[modify] https://crrev.com/3854543fdcea4ffd600b2a0fbef5ef59c4ba1388/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js
[rename] https://crrev.com/3854543fdcea4ffd600b2a0fbef5ef59c4ba1388/third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListProvider.js
[modify] https://crrev.com/3854543fdcea4ffd600b2a0fbef5ef59c4ba1388/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptOutlineDialog.js
[modify] https://crrev.com/3854543fdcea4ffd600b2a0fbef5ef59c4ba1388/third_party/WebKit/Source/devtools/front_end/sources/OpenResourceDialog.js
[modify] https://crrev.com/3854543fdcea4ffd600b2a0fbef5ef59c4ba1388/third_party/WebKit/Source/devtools/front_end/sources/StyleSheetOutlineDialog.js
[modify] https://crrev.com/3854543fdcea4ffd600b2a0fbef5ef59c4ba1388/third_party/WebKit/Source/devtools/front_end/sources/module.json

We should revert the monospace change...
Screenshot from 2017-03-10 15:10:10.png
77.1 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecd5bf7d2c6cfe70b3d968c526821387ca1911bc

commit ecd5bf7d2c6cfe70b3d968c526821387ca1911bc
Author: einbinder <einbinder@chromium.org>
Date: Wed Mar 15 08:26:20 2017

DevTools: Add monospace back to open file dialog

BUG= 662081 

Review-Url: https://codereview.chromium.org/2743253003
Cr-Commit-Position: refs/heads/master@{#457033}

[modify] https://crrev.com/ecd5bf7d2c6cfe70b3d968c526821387ca1911bc/third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListProvider.js

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64eeaf6fafdb64505f589a8f1391460362ea09af

commit 64eeaf6fafdb64505f589a8f1391460362ea09af
Author: einbinder <einbinder@chromium.org>
Date: Wed Mar 29 21:04:41 2017

DevTools: Create extensible QuickOpen control

GoToLineDialog and QuickOpen are spun off from OpenResourceDialog.
QuickOpen switches between GoToLineDialog and OpenResourceDialog depending on
whether the query starts with ':'.
QuickOpen loads delegates through the runtime system.

BUG= 662081 

Review-Url: https://codereview.chromium.org/2679483002
Cr-Commit-Position: refs/heads/master@{#460536}

[modify] https://crrev.com/64eeaf6fafdb64505f589a8f1391460362ea09af/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering-expected.txt
[modify] https://crrev.com/64eeaf6fafdb64505f589a8f1391460362ea09af/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js
[modify] https://crrev.com/64eeaf6fafdb64505f589a8f1391460362ea09af/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-go-to-file-dialog.html
[modify] https://crrev.com/64eeaf6fafdb64505f589a8f1391460362ea09af/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/64eeaf6fafdb64505f589a8f1391460362ea09af/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js
[add] https://crrev.com/64eeaf6fafdb64505f589a8f1391460362ea09af/third_party/WebKit/Source/devtools/front_end/quick_open/QuickOpen.js
[modify] https://crrev.com/64eeaf6fafdb64505f589a8f1391460362ea09af/third_party/WebKit/Source/devtools/front_end/quick_open/module.json
[modify] https://crrev.com/64eeaf6fafdb64505f589a8f1391460362ea09af/third_party/WebKit/Source/devtools/front_end/sources/FilteredUISourceCodeListProvider.js
[add] https://crrev.com/64eeaf6fafdb64505f589a8f1391460362ea09af/third_party/WebKit/Source/devtools/front_end/sources/GoToLineQuickOpen.js
[modify] https://crrev.com/64eeaf6fafdb64505f589a8f1391460362ea09af/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
[rename] https://crrev.com/64eeaf6fafdb64505f589a8f1391460362ea09af/third_party/WebKit/Source/devtools/front_end/sources/OpenFileQuickOpen.js
[modify] https://crrev.com/64eeaf6fafdb64505f589a8f1391460362ea09af/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
[modify] https://crrev.com/64eeaf6fafdb64505f589a8f1391460362ea09af/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
[modify] https://crrev.com/64eeaf6fafdb64505f589a8f1391460362ea09af/third_party/WebKit/Source/devtools/front_end/sources/module.json

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b638cb237c9a6a1ae7d360ec721b77381c4dbe3b

commit b638cb237c9a6a1ae7d360ec721b77381c4dbe3b
Author: einbinder <einbinder@chromium.org>
Date: Wed Apr 05 02:57:47 2017

DevTools: Only detach FilteredListWidget dialog after item is selected

The dialog was hidden, which caused the provider to detached. Then
selectItem was called on the provider, which was in a potentially
bad state.

BUG= 662081 

Review-Url: https://codereview.chromium.org/2799483003
Cr-Commit-Position: refs/heads/master@{#461959}

[modify] https://crrev.com/b638cb237c9a6a1ae7d360ec721b77381c4dbe3b/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4ad68a17ae6822adc2c4ed33b43712686198161

commit b4ad68a17ae6822adc2c4ed33b43712686198161
Author: einbinder <einbinder@chromium.org>
Date: Wed Apr 05 05:48:30 2017

DevTools: Move JavaScript and CSS outline into QuickOpen

This combines JavaScriptOutlineDialog and StyleSheetOutlineDialog into
a single QuickOpen provider.

BUG= 662081 

Review-Url: https://codereview.chromium.org/2783233005
Cr-Commit-Position: refs/heads/master@{#461988}

[modify] https://crrev.com/b4ad68a17ae6822adc2c4ed33b43712686198161/third_party/WebKit/LayoutTests/inspector/sources/css-outline-dialog.html
[modify] https://crrev.com/b4ad68a17ae6822adc2c4ed33b43712686198161/third_party/WebKit/LayoutTests/inspector/sources/javascript-outline-dialog.html
[modify] https://crrev.com/b4ad68a17ae6822adc2c4ed33b43712686198161/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/b4ad68a17ae6822adc2c4ed33b43712686198161/third_party/WebKit/Source/devtools/front_end/common/FormatterWorkerPool.js
[delete] https://crrev.com/375063584275c3558ab6e8ff65e701b223800f5b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptOutlineDialog.js
[add] https://crrev.com/b4ad68a17ae6822adc2c4ed33b43712686198161/third_party/WebKit/Source/devtools/front_end/sources/OutlineQuickOpen.js
[modify] https://crrev.com/b4ad68a17ae6822adc2c4ed33b43712686198161/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js
[delete] https://crrev.com/375063584275c3558ab6e8ff65e701b223800f5b/third_party/WebKit/Source/devtools/front_end/sources/StyleSheetOutlineDialog.js
[modify] https://crrev.com/b4ad68a17ae6822adc2c4ed33b43712686198161/third_party/WebKit/Source/devtools/front_end/sources/module.json

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8cdcf7426f5c765161a2ba97d69a10b55e8624f

commit d8cdcf7426f5c765161a2ba97d69a10b55e8624f
Author: einbinder <einbinder@chromium.org>
Date: Wed Apr 05 06:46:37 2017

DevTools: Update CommandMenuProvider on attach instead of construction

The CommandMenu was only updating avaiable actions on construction. This
could cause a scenario where actions from a stale context were visible.

BUG= 662081 

Review-Url: https://codereview.chromium.org/2793873002
Cr-Commit-Position: refs/heads/master@{#461993}

[modify] https://crrev.com/d8cdcf7426f5c765161a2ba97d69a10b55e8624f/third_party/WebKit/Source/devtools/front_end/quick_open/CommandMenu.js

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c6e07f9376fefa39f149b34ec8005581f4f2ff4

commit 0c6e07f9376fefa39f149b34ec8005581f4f2ff4
Author: einbinder <einbinder@chromium.org>
Date: Wed Apr 05 23:26:04 2017

DevTools: Preserve source selection when using Quick Open

BUG= 662081 

Review-Url: https://codereview.chromium.org/2799603004
Cr-Commit-Position: refs/heads/master@{#462268}

[modify] https://crrev.com/0c6e07f9376fefa39f149b34ec8005581f4f2ff4/third_party/WebKit/Source/devtools/front_end/sources/OpenFileQuickOpen.js

Status: Verified (was: Assigned)

Comment 15 by kayce@google.com, Apr 24 2017

Labels: DevTools-Release-Notes-60 DevTools-Release-Notes-Feature
Adding DevTools-Release-Notes-60 tag to remember to document the `?`, `!`, etc. commands

Sign in to add a comment