New issue
Advanced search Search tips

Issue 662078 link

Starred by 1 user
Status: Fixed
Owner:
boliu@chromium.org
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.android_webview.test.WebKitHitTestTest#testUnknownTypeUnrecognizedNode with {--webview-sandboxed-renderer}" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Nov 3 2016 
"org.chromium.android_webview.test.WebKitHitTestTest#testUnknownTypeUnrecognizedNode with {--webview-sandboxed-renderer}" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyggELEgVGbGFrZSJ3b3JnLmNocm9taXVtLmFuZHJvaWRfd2Vidmlldy50ZXN0LldlYktpdEhpdFRlc3RUZXN0I3Rlc3RVbmtub3duVHlwZVVucmVjb2duaXplZE5vZGUgd2l0aCB7LS13ZWJ2aWV3LXNhbmRib3hlZC1yZW5kZXJlcn0M.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by tapted@chromium.org, Nov 4 2016

Owner: boliu@chromium.org
Status: Assigned (was: Untriaged)
Times out.

https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/60857
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/173408
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/60407

org.chromium.android_webview.test.WebKitHitTestTest#testUnknownTypeUnrecognizedNode with {--webview-sandboxed-renderer} (run #1):
junit.framework.AssertionFailedError: Criteria not met in allotted time.
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:74)
	at org.chromium.android_webview.test.AwTestBase.pollInstrumentationThread(AwTestBase.java:523)
	at org.chromium.android_webview.test.AwTestBase.pollUiThread(AwTestBase.java:540)
	at org.chromium.android_webview.test.WebKitHitTestTest.testUnknownTypeUnrecognizedNode(WebKitHitTestTest.java:385)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efa32e62bfc2819121946de45bd42b95f7eae305

commit efa32e62bfc2819121946de45bd42b95f7eae305
Author: tapted <tapted@chromium.org>
Date: Fri Nov 04 04:45:17 2016

Disable Android WebKitHitTestTest#testUnknownTypeUnrecognizedNode

Times out.

BUG= 662078 
TBR=boliu@chromium.org

Review-Url: https://codereview.chromium.org/2474313002
Cr-Commit-Position: refs/heads/master@{#429783}

[modify] https://crrev.com/efa32e62bfc2819121946de45bd42b95f7eae305/android_webview/javatests/src/org/chromium/android_webview/test/WebKitHitTestTest.java

Comment 3 by tapted@chromium.org, Nov 4 2016

Labels: -Sheriff-Chromium
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e39ff7bb09b58c32541dcd08bba54dc928617f22

commit e39ff7bb09b58c32541dcd08bba54dc928617f22
Author: boliu <boliu@chromium.org>
Date: Mon Nov 07 18:12:06 2016

aw: Deflake testUnknownTypeUnrecognizedNode

The flake is probably due to the test server re-using the same url for
different test pages. Changed so that each test page gets a new url.

Then found out the test is still flaky because apparently onPageFinished
doesn't mean blink has committed the new page so it's hit-testable. So
also wait for the page commit signal. This replaces polling for title
in the test.

BUG= 662078 

Review-Url: https://codereview.chromium.org/2475163003
Cr-Commit-Position: refs/heads/master@{#430317}

[modify] https://crrev.com/e39ff7bb09b58c32541dcd08bba54dc928617f22/android_webview/javatests/src/org/chromium/android_webview/test/WebKitHitTestTest.java

Comment 5 by boliu@chromium.org, Nov 7 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment