New issue
Advanced search Search tips

Issue 662064 link

Starred by 1 user
Status: Fixed
Owner:
dmazz...@chromium.org
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Get rid of AXViewState

Project Member Reported by dmazzoni@google.com, Nov 3 2016 
For historical reasons, Views accessibility uses a struct, AXViewState, to represent the accessible state of a View. This was originally designed when Views accessibility shared little code with the rest of Chrome.

Today a lot more code is shared, and all of the places where AXViewState is consumed, it's first converted into the more general AXNodeData struct, which is used throughout Chrome.

We should replace the awkward set_value_callback in AXViewState with a virtual function on View that takes an AXActionData instead, that will allow even more future cleanups and streamlining.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13e5258f7ad40c6dee7bd64e92d72c1a3f683451

commit 13e5258f7ad40c6dee7bd64e92d72c1a3f683451
Author: dmazzoni <dmazzoni@chromium.org>
Date: Fri Nov 04 07:24:21 2016

Replace ui::AXViewState with AXNodeData and AXActionData

This is a refactoring change.

Originally AXViewState was created when Views accessibility
didn't share any code with the rest of Chrome. Now there's
a lot more overlap, and every place where AXViewState is
consumed, it's just converted into AXNodeData. This change
eliminates AXViewState and uses AXNodeData in Views directly,
allowing us to delete some conversion code.

To replace AXViewState::set_value_callback, which was rather
awkward, this change adds a virtual function to View that
takes an AXActionData, a general-purpose struct that encodes an
accessible action to take on an object. That provides a
cleaner solution for set_value_callback and allows for
more streamlining of code later.

I suggest reviewing Patch Set 4 first, as that includes
only the non-mechanical changes.

BUG= 662064 

Review-Url: https://codereview.chromium.org/2477463003
Cr-Commit-Position: refs/heads/master@{#429823}

[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/accelerators/exit_warning_handler.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/shelf/app_list_button.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/shelf/app_list_button.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/shelf/shelf_button.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/shelf/shelf_button.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/shelf/shelf_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/shelf/shelf_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/audio/volume_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/audio/volume_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/chromeos/ime_menu/ime_list_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/chromeos/network/tray_network.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/chromeos/power/power_status_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/chromeos/power/power_status_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/chromeos/power/tray_power.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/chromeos/tray_caps_lock.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/date/date_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/date/date_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/tray/actionable_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/tray/actionable_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/tray/hover_highlight_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/tray/hover_highlight_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/tray/tray_background_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/tray/tray_background_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/tray/tray_item_more.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/tray/tray_item_more.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/tray/tray_utils.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/user/button_from_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/user/button_from_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/user/tray_user_unittest.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/user/user_card_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/system/user/user_card_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/common/wm/window_cycle_list.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ash/system/chromeos/screen_layout_observer_unittest.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/chromeos/options/network_config_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/chromeos/options/network_config_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/chromeos/ui/idle_app_name_notification_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/aura/accessibility/ax_root_obj_wrapper.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/autofill/password_generation_popup_view_views.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/autofill/tooltip_icon.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/autofill/tooltip_icon.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/bookmarks/bookmark_bar_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/bookmarks/bookmark_editor_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/conflicting_module_view_win.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/conflicting_module_view_win.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/critical_notification_bubble_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/critical_notification_bubble_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/desktop_capture/desktop_media_list_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/desktop_capture/desktop_media_list_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/desktop_capture/desktop_media_source_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/desktop_capture/desktop_media_source_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/download/download_item_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/download/download_item_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/frame/opaque_browser_frame_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/infobars/infobar_container_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/infobars/infobar_container_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/infobars/infobar_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/infobars/infobar_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/location_bar/bubble_icon_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/location_bar/bubble_icon_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/location_bar/page_action_image_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/location_bar/page_action_image_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/location_bar/page_action_with_badge_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/location_bar/page_action_with_badge_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/location_bar/zoom_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/location_bar/zoom_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/omnibox/omnibox_result_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/omnibox/omnibox_view_views.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/tabs/tab.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/tabs/tab_controller.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/tabs/tab_strip.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/tabs/tab_unittest.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/toolbar/app_menu.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/toolbar/browser_actions_container.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/toolbar/browser_actions_container.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/toolbar/reload_button.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/toolbar/reload_button.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/toolbar/toolbar_action_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/toolbar/toolbar_action_view_unittest.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/toolbar/toolbar_button.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/toolbar/toolbar_button.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/toolbar/toolbar_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/chrome/browser/ui/views/website_settings/permission_selector_row.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/content/browser/accessibility/browser_accessibility_win_unittest.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/content/renderer/accessibility/render_accessibility_impl.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/accessibility/BUILD.gn
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/accessibility/ax_enums.idl
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/accessibility/ax_node_data.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/accessibility/ax_node_data.h
[delete] https://crrev.com/f85750693cce8a4320b18552bdb51c0bcae90a67/ui/accessibility/ax_view_state.cc
[delete] https://crrev.com/f85750693cce8a4320b18552bdb51c0bcae90a67/ui/accessibility/ax_view_state.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/accessibility/platform/ax_platform_node_mac.mm
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/app_list/views/app_list_folder_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/app_list/views/app_list_folder_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/app_list/views/app_list_item_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/app_list/views/start_page_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/message_center/views/bounded_label.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/message_center/views/bounded_label.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/message_center/views/message_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/message_center/views/message_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/message_center/views/notifier_settings_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/message_center/views/notifier_settings_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/message_center/views/toast_contents_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/message_center/views/toast_contents_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/accessibility/ax_view_obj_wrapper.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/accessibility/native_view_accessibility.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/accessibility/native_view_accessibility_unittest.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/accessibility/native_view_accessibility_win.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/accessible_pane_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/accessible_pane_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/bubble/bubble_dialog_delegate.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/bubble/tray_bubble_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/bubble/tray_bubble_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/button/button.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/button/button.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/button/checkbox.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/button/checkbox.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/button/custom_button.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/button/custom_button.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/button/image_button.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/button/image_button.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/button/label_button_unittest.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/button/menu_button.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/button/menu_button.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/button/radio_button.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/button/radio_button.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/combobox/combobox.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/combobox/combobox.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/image_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/image_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/label.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/label.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/label_unittest.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/link.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/link.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/menu/menu_item_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/menu/menu_item_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/menu/menu_scroll_view_container.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/menu/menu_scroll_view_container.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/menu/submenu_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/menu/submenu_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/message_box_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/message_box_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/progress_bar.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/progress_bar.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/progress_bar_unittest.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/resize_area.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/resize_area.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/scrollbar/scroll_bar.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/scrollbar/scroll_bar.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/separator.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/separator.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/slider.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/slider.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/tabbed_pane/tabbed_pane.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/tabbed_pane/tabbed_pane.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/table/table_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/table/table_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/textfield/textfield.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/textfield/textfield.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/textfield/textfield_unittest.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/tree/tree_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/tree/tree_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/webview/webview.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/controls/webview/webview.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/widget/native_widget_mac_accessibility_unittest.mm
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/widget/root_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/widget/root_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/window/client_view.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/window/client_view.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/window/dialog_delegate.cc
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72c1a3f683451/ui/views/window/dialog_delegate.h
[modify] https://crrev.com/13e5258f7ad40c6dee7bd64e92d72

Comment 2 by dmazz...@chromium.org, Nov 7 2016

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37cefec501173e1a3c144910f74d17c99c79d5df

commit 37cefec501173e1a3c144910f74d17c99c79d5df
Author: patricialor <patricialor@chromium.org>
Date: Tue Nov 22 00:51:29 2016

MacViews/a11y: Implement AccessibilityPerformAction for NativeViewAccessibility.

Refactor AXPlatformNodeMac and NativeViewAccessibility to use AXActionData for
all possible accessibility actions. To support 'unfocusing' a control, also add
a new ui::AX_ACTION_BLUR to accompany the existing ui::AX_ACTION_SET_FOCUS.
Existing accessibility actions which previously had their own methods on
AXPlatformNodeDelegate are now consolidated into AccessibilityPerformAction.

This follows up r426221, which did the same thing for accessibility actions
inside the web contents area. To be consistent, use the same
AccessibilityPerformAction method signature.

BUG= 662064 

Review-Url: https://codereview.chromium.org/2474363002
Cr-Commit-Position: refs/heads/master@{#433717}

[modify] https://crrev.com/37cefec501173e1a3c144910f74d17c99c79d5df/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/37cefec501173e1a3c144910f74d17c99c79d5df/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/37cefec501173e1a3c144910f74d17c99c79d5df/content/browser/accessibility/browser_accessibility_manager.cc
[modify] https://crrev.com/37cefec501173e1a3c144910f74d17c99c79d5df/content/renderer/accessibility/render_accessibility_impl.cc
[modify] https://crrev.com/37cefec501173e1a3c144910f74d17c99c79d5df/ui/accessibility/ax_enums.idl
[modify] https://crrev.com/37cefec501173e1a3c144910f74d17c99c79d5df/ui/accessibility/platform/ax_platform_node_delegate.h
[modify] https://crrev.com/37cefec501173e1a3c144910f74d17c99c79d5df/ui/accessibility/platform/ax_platform_node_mac.mm
[modify] https://crrev.com/37cefec501173e1a3c144910f74d17c99c79d5df/ui/accessibility/platform/ax_platform_node_win.cc
[modify] https://crrev.com/37cefec501173e1a3c144910f74d17c99c79d5df/ui/accessibility/platform/test_ax_node_wrapper.cc
[modify] https://crrev.com/37cefec501173e1a3c144910f74d17c99c79d5df/ui/accessibility/platform/test_ax_node_wrapper.h
[modify] https://crrev.com/37cefec501173e1a3c144910f74d17c99c79d5df/ui/views/accessibility/native_view_accessibility.cc
[modify] https://crrev.com/37cefec501173e1a3c144910f74d17c99c79d5df/ui/views/accessibility/native_view_accessibility.h
[modify] https://crrev.com/37cefec501173e1a3c144910f74d17c99c79d5df/ui/views/accessibility/native_view_accessibility_auralinux.cc
►

Sign in to add a comment