Add scoped clipboard support to TaskScheduler |
|||||
Issue descriptionRequired to redirect FILE thread on Windows: https://cs.chromium.org/chromium/src/content/browser/browser_main_loop.cc?type=cs&q=file:browser_main_loop.cc+ui::Clipboard::SetAllowedThreads&sq=package:chromium&l=1359
,
Nov 18 2016
,
Nov 22 2016
The CQ dry run passes when clipboard is disabled on the FILE thread https://codereview.chromium.org/2518363002/ Shall I use DumpWithoutCrashing() to find out if we really need clipboard on the FILE thread?
,
Nov 22 2016
Is usage of the API even that frequent or can we do a manual code survey?
,
Nov 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1e683e0e48535837caf622ae70b14fa57e7a392 commit d1e683e0e48535837caf622ae70b14fa57e7a392 Author: fdoray <fdoray@chromium.org> Date: Wed Nov 23 16:21:05 2016 Disable ui::Clipboard on the FILE thread. We found no evidence that ui::Clipboard is used on the FILE thread. This CL disallows usage of ui::Clipboard on the FILE thread and adds a DumpWithoutCrashing() call to detect when it's used on unauthorized threads. Disallowing usage of ui::Clipboard on the FILE thread will facilitate its migration to TaskScheduler. BUG= 662055 Review-Url: https://codereview.chromium.org/2518363002 Cr-Commit-Position: refs/heads/master@{#434178} [modify] https://crrev.com/d1e683e0e48535837caf622ae70b14fa57e7a392/content/browser/browser_main_loop.cc [modify] https://crrev.com/d1e683e0e48535837caf622ae70b14fa57e7a392/ui/base/clipboard/clipboard.cc
,
Nov 23 2016
Awesome, thanks. WontFix this for TaskScheduler then :)
,
Feb 21 2017
Hi, I'm trying to rationalize DumpWithoutCrashing calls. Can I delete the associated code here? https://cs.chromium.org/chromium/src/ui/base/clipboard/clipboard.cc?rcl=625ed7b577525cfa4ca367841d25152133485a28&l=153 Alternately if it's useful I can wrap it in #if DCHECK, or change the DumpWithoutCrashing() to a CHECK.
,
Feb 21 2017
,
Feb 22 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by gab@chromium.org
, Nov 7 2016