New issue
Advanced search Search tips

Issue 662055 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 694688
issue 653916



Sign in to add a comment

Add scoped clipboard support to TaskScheduler

Project Member Reported by gab@chromium.org, Nov 3 2016

Issue description

Comment 1 by gab@chromium.org, Nov 7 2016

Components: Internals>TaskScheduler

Comment 2 by gab@chromium.org, Nov 18 2016

Labels: -M-56 M-57

Comment 3 by fdoray@chromium.org, Nov 22 2016

The CQ dry run passes when clipboard is disabled on the FILE thread https://codereview.chromium.org/2518363002/

Shall I use DumpWithoutCrashing() to find out if we really need clipboard on the FILE thread?

Comment 4 by gab@chromium.org, Nov 22 2016

Is usage of the API even that frequent or can we do a manual code survey?
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1e683e0e48535837caf622ae70b14fa57e7a392

commit d1e683e0e48535837caf622ae70b14fa57e7a392
Author: fdoray <fdoray@chromium.org>
Date: Wed Nov 23 16:21:05 2016

Disable ui::Clipboard on the FILE thread.

We found no evidence that ui::Clipboard is used on the
FILE thread. This CL disallows usage of ui::Clipboard on
the FILE thread and adds a DumpWithoutCrashing() call to
detect when it's used on unauthorized threads.

Disallowing usage of ui::Clipboard on the FILE thread
will facilitate its migration to TaskScheduler.

BUG= 662055 

Review-Url: https://codereview.chromium.org/2518363002
Cr-Commit-Position: refs/heads/master@{#434178}

[modify] https://crrev.com/d1e683e0e48535837caf622ae70b14fa57e7a392/content/browser/browser_main_loop.cc
[modify] https://crrev.com/d1e683e0e48535837caf622ae70b14fa57e7a392/ui/base/clipboard/clipboard.cc

Comment 6 by gab@chromium.org, Nov 23 2016

Cc: -fdoray@chromium.org gab@chromium.org
Owner: fdoray@chromium.org
Status: WontFix (was: Untriaged)
Awesome, thanks.

WontFix this for TaskScheduler then :)
Hi, I'm trying to rationalize DumpWithoutCrashing calls. Can I delete the associated code here? https://cs.chromium.org/chromium/src/ui/base/clipboard/clipboard.cc?rcl=625ed7b577525cfa4ca367841d25152133485a28&l=153

Alternately if it's useful I can wrap it in #if DCHECK, or change the DumpWithoutCrashing() to a CHECK.
Cc: scottmg@chromium.org
Blocking: 694688

Sign in to add a comment