New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662053 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocked on:
issue 645196
issue 662052

Blocking:
issue 665588



Sign in to add a comment

Enable TaskScheduler by default in the browser process

Project Member Reported by gab@chromium.org, Nov 3 2016

Issue description

It's currently behind a field trial. Metrics are looking healthy. This issue is meant to track remaining blockers before making it always on in the browser process.
 

Comment 1 by gab@chromium.org, Nov 3 2016

Blockedon: 645196

Comment 2 by gab@chromium.org, Nov 7 2016

Components: Internals>TaskScheduler

Comment 3 by gab@chromium.org, Nov 15 2016

Cc: gab@chromium.org
Labels: OS-All
Owner: robliao@chromium.org
Status: Started (was: Assigned)

Comment 4 by gab@chromium.org, Nov 15 2016

To anyone following this bug, here's the approval from launch review to proceed with making this default on trunk: https://groups.google.com/a/google.com/d/topic/chrome-launch-review/9Ub8euoKGdc/discussion

Comment 5 by gab@chromium.org, Nov 15 2016

Blocking: 665588

Comment 7 by gab@chromium.org, Nov 21 2016

Labels: Merge-Request-56
Status: Fixed (was: Started)
Hi TPMs, r433057 unintentionally barely made the M56 cut. Since it's useless at best and mildly bad at worse without its follow-up CLs we'd like to revert it on M56 branch.

CL up @ https://codereview.chromium.org/2521653002 pending your merge approval (not really a merge, just a harmless revert on branch..).

Comment 8 by dimu@chromium.org, Nov 21 2016

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
[Automated comment] DEPS changes referenced in bugdroid comments, needs manual review.

Comment 9 by gab@chromium.org, Nov 28 2016

Cc: bustamante@chromium.org
Labels: M-57
Status: Started (was: Fixed)
+bustamante: this feature is for M57, we're looking to revert its first unintentional commit on M56 branch as described in #7, ok? It's possible to avoid touching strings/DEPS if that matters.

Comment 10 by gab@chromium.org, Nov 28 2016

Status: Fixed (was: Started)
Labels: -Merge-Review-56 Merge-Approved-56
Yeah sounds good, approving for merge into M56 so it can get reverted.  Thanks!
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 29 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9b5f3f09b0ac69f9ef4541abaa8d1fa891e35a0

commit d9b5f3f09b0ac69f9ef4541abaa8d1fa891e35a0
Author: Gabriel Charette <gab@chromium.org>
Date: Tue Nov 29 15:09:09 2016

[M56] Revert "Enable Initialization of the Task Scheduler by Default in the Browser Process"

This reverts commit 35980e3860cd6bb4241e9b4a6213048dcd6920e4 on M56 branch.

It unintentionally barely made the M56 cut and is useless without its follow-up CLs.

BUG= 662053 
TBR=robliao@chromium.org

Review URL: https://codereview.chromium.org/2521653002 .

Cr-Commit-Position: refs/branch-heads/2924@{#154}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/d9b5f3f09b0ac69f9ef4541abaa8d1fa891e35a0/chrome/app/generated_resources.grd
[modify] https://crrev.com/d9b5f3f09b0ac69f9ef4541abaa8d1fa891e35a0/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/d9b5f3f09b0ac69f9ef4541abaa8d1fa891e35a0/components/task_scheduler_util/BUILD.gn
[delete] https://crrev.com/146e4c96e3e45a0edb5d04f6b76d44e86cdb24f7/components/task_scheduler_util/DEPS
[modify] https://crrev.com/d9b5f3f09b0ac69f9ef4541abaa8d1fa891e35a0/components/task_scheduler_util/initialization_util.cc
[modify] https://crrev.com/d9b5f3f09b0ac69f9ef4541abaa8d1fa891e35a0/components/task_scheduler_util/initialization_util.h
[modify] https://crrev.com/d9b5f3f09b0ac69f9ef4541abaa8d1fa891e35a0/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/d9b5f3f09b0ac69f9ef4541abaa8d1fa891e35a0/ios/chrome/browser/ios_chrome_main_parts.mm

Comment 13 by gab@chromium.org, Jan 11 2017

Labels: -Type-Bug Type-Feature

Sign in to add a comment