md-settings: navigate chrome://help to chrome://settings doesn't update url
Reported by
vanantwe...@gmail.com,
Nov 3 2016
|
||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2906.0 Safari/537.36 Steps to reproduce the problem: 1. Go to chrome://help 2. Go to 'People' 3. What is the expected behavior? What went wrong? URI in the omnibar ain't updated to chrome://settings Did this work before? Yes Before md-settings Chrome version: 56.0.2906.0 Channel: dev OS Version: Ubuntu 14.04 Flash Version: N/A
,
Nov 9 2016
this sounds like an existing virtual URLs thing, maybe?
,
Nov 9 2016
,
Nov 18 2016
,
Jan 10 2017
,
Jan 26 2017
I sent an email about this, but I'll comment on this bug too: I recommend we just make chrome://help 301 redirect to chrome://settings/help. The old Options page had some tricky URL rewriting to be able to update the URL hostname without reloading the page. Now that we just have Settings and About, IMO it's just not worth it. Making About live at chrome://settings/help seems sensible to me.
,
Jan 31 2017
,
Jan 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0844eead6025c71d51db860f4a0290ea32f7aea9 commit 0844eead6025c71d51db860f4a0290ea32f7aea9 Author: tommycli <tommycli@chromium.org> Date: Tue Jan 31 18:45:24 2017 MD Settings: Redirect chrome://help and chrome://chrome to About page. This CL redirects chrome://help and chrome://chrome to chrome://settings/help. This already worked before, but did not update the virtual URL displayed in the Omnibox. This caused navigation problems when the user navigated within Settings (i.e. went to chrome://help, navigate to People section, and the displayed URL would stay on chrome://help). This CL sets chrome://settings/help as the canonical About location. BUG= 638722 , 662028 Review-Url: https://codereview.chromium.org/2664063002 Cr-Commit-Position: refs/heads/master@{#447280} [modify] https://crrev.com/0844eead6025c71d51db860f4a0290ea32f7aea9/chrome/browser/browser_about_handler.cc [modify] https://crrev.com/0844eead6025c71d51db860f4a0290ea32f7aea9/chrome/browser/browser_about_handler_unittest.cc [modify] https://crrev.com/0844eead6025c71d51db860f4a0290ea32f7aea9/chrome/browser/chrome_content_browser_client.cc
,
Jan 31 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by hdodda@chromium.org
, Nov 4 2016Components: -UI UI>Settings
Labels: Proj-MaterialDesign-WebUI OS-Mac OS-Windows
Status: Untriaged (was: Unconfirmed)