New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662028 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression

Blocking:
issue 671375



Sign in to add a comment

md-settings: navigate chrome://help to chrome://settings doesn't update url

Reported by vanantwe...@gmail.com, Nov 3 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2906.0 Safari/537.36

Steps to reproduce the problem:
1. Go to chrome://help
2. Go to 'People'
3. 

What is the expected behavior?

What went wrong?
URI in the omnibar ain't updated to chrome://settings

Did this work before? Yes Before md-settings

Chrome version: 56.0.2906.0  Channel: dev
OS Version: Ubuntu 14.04
Flash Version: N/A
 
Cc: hdodda@chromium.org
Components: -UI UI>Settings
Labels: Proj-MaterialDesign-WebUI OS-Mac OS-Windows
Status: Untriaged (was: Unconfirmed)
Tested on Linux 14.04 , Mac OS 10.11.6 and Windows 10 using chrome canary M56 #56.0.2909.0.

Confirming the issue and Untraiging , so that it get addressed.

Requesting someone from MD-settings team to look into it. 

Thanks !

Comment 2 by dbeam@chromium.org, Nov 9 2016

Cc: creis@chromium.org dpa...@chromium.org
this sounds like an existing virtual URLs thing, maybe?

Comment 3 by dbeam@chromium.org, Nov 9 2016

Status: Available (was: Untriaged)
Cc: tommycli@chromium.org
Blocking: 671375
Labels: Hotlist-MD-Settings-Navigation
Cc: dbeam@chromium.org bettes@chromium.org tbuck...@chromium.org
I sent an email about this, but I'll comment on this bug too:

I recommend we just make chrome://help 301 redirect to chrome://settings/help.

The old Options page had some tricky URL rewriting to be able to update the URL hostname without reloading the page.

Now that we just have Settings and About, IMO it's just not worth it. Making About live at chrome://settings/help seems sensible to me.
Owner: tommycli@chromium.org
Status: Started (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0844eead6025c71d51db860f4a0290ea32f7aea9

commit 0844eead6025c71d51db860f4a0290ea32f7aea9
Author: tommycli <tommycli@chromium.org>
Date: Tue Jan 31 18:45:24 2017

MD Settings: Redirect chrome://help and chrome://chrome to About page.

This CL redirects chrome://help and chrome://chrome to
chrome://settings/help. This already worked before, but did not update
the virtual URL displayed in the Omnibox.

This caused navigation problems when the user navigated within
Settings (i.e. went to chrome://help, navigate to People section, and
the displayed URL would stay on chrome://help).

This CL sets chrome://settings/help as the canonical About location.

BUG= 638722 , 662028 

Review-Url: https://codereview.chromium.org/2664063002
Cr-Commit-Position: refs/heads/master@{#447280}

[modify] https://crrev.com/0844eead6025c71d51db860f4a0290ea32f7aea9/chrome/browser/browser_about_handler.cc
[modify] https://crrev.com/0844eead6025c71d51db860f4a0290ea32f7aea9/chrome/browser/browser_about_handler_unittest.cc
[modify] https://crrev.com/0844eead6025c71d51db860f4a0290ea32f7aea9/chrome/browser/chrome_content_browser_client.cc

Status: Fixed (was: Started)

Sign in to add a comment