New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 662025 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug

Blocking:
issue 671375



Sign in to add a comment

md-settings: Sync summary shows "Sync everything" with only some sync data types selected

Reported by vanantwe...@gmail.com, Nov 3 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2906.0 Safari/537.36

Steps to reproduce the problem:
1. Go to chrome://help
2. Navigate to settings
3. Have sync settings which sync all except for bookmarks
4. Check the text: On -  sync everything

What is the expected behavior?

What went wrong?
It shows: On - sync everything
I would expect something like: On - sync partial

Did this work before? N/A 

Chrome version: 56.0.2906.0  Channel: dev
OS Version: Ubuntu 14.04
Flash Version: N/A
 
Cc: hdodda@chromium.org
Components: -UI UI>Settings Services>Sync
Labels: Proj-MaterialDesign-WebUI M-56 OS-Mac OS-Windows
Status: Untriaged (was: Unconfirmed)
Tested on windows 10 using chrome canary M56 #56.0.2909.0 and issue is reproduced.

Confirming the issue and Untraiging , so that it get addressed.

Requesting someone from MD-settings team to look into it. 

Thanks !

Comment 2 by s...@chromium.org, Nov 7 2016

Labels: Sync-Triaged

Comment 3 by dbeam@chromium.org, Nov 9 2016

Cc: tommycli@chromium.org mahmadi@chromium.org
Summary: md-settings: Sync summary shows "Sync everything" with only some sync data types selected (was: md-settings: Sync field shows incorrect data)
I agree that the sync summary should not be "Sync everything" if ... only some things are being synced.

Comment 4 by dbeam@chromium.org, Nov 9 2016

Cc: ew...@chromium.org

Comment 5 by ew...@chromium.org, Nov 10 2016

Owner: bettes@chromium.org
Status: Assigned (was: Untriaged)
Seems like a very reasonable point :)

Alan - right now, the subtitle on the "Sync" row in MD settings is always "On - sync everything" if sync is on, working, and there's no error. We should probably update the subtitle if you have unchecked specific data types.

What do you think we should use as the subtitle? We could just go with "On." Or perhaps "On - choose what to sync" (which is the phrase we use in current settings advanced sync settings: https://screenshot.googleplex.com/0ytOEZaFwiR.png - though that is a slightly different context).
Blocking: 671375
Labels: -Pri-2 Hotlist-MD-Settings-People Pri-1
How about "On - sync some things"? :-)

My 2nd favorite would just be "On"

Comment 7 by ew...@chromium.org, Jan 10 2017

"On - sync some things" feels a little awkward to me. I would be happy with just "On."

Just waiting on Alan's input.

Comment 8 by ew...@chromium.org, Jan 10 2017

Or a slight variant of Tom's suggestion: "On - syncing some things"

Comment 9 by bettes@chromium.org, Jan 11 2017

Owner: ew...@chromium.org
How does "On - custom settings" sound? 

Comment 10 by ew...@chromium.org, Jan 11 2017

Owner: tommycli@chromium.org
"On - custom settings" SGTM

Re-assigning to Tommy for implementation.
SGTM with one clarification:

If the user unchecks the Sync everything toggle, but leaves all the data types still enabled, I highly recommend also displaying the "On - custom settings".

I suggest this because the sync prefs code keeps a separate flag for the default syncing everything state, and it would be smart to match the string to that flag. "On - custom settings" is still accurate to that state anyways.
Well here's the CL with the changes in c#11: https://codereview.chromium.org/2631803002/

I just sent it out for review.

Comment 13 by ew...@chromium.org, Jan 18 2017

Yep, the behavior described in #11 SGTM. Thanks Tommy :)
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/634697b5871cac5bee8850a965b97e23961fd8c8

commit 634697b5871cac5bee8850a965b97e23961fd8c8
Author: tommycli <tommycli@chromium.org>
Date: Wed Jan 18 17:24:58 2017

MD Settings People: Display "On - custom settings" for custom data types

When the user has a custom data types synced, display
"On - custom settings" instead of "On - sync everything".

BUG= 662025 

Review-Url: https://codereview.chromium.org/2631803002
Cr-Commit-Position: refs/heads/master@{#444409}

[modify] https://crrev.com/634697b5871cac5bee8850a965b97e23961fd8c8/chrome/app/generated_resources.grd
[modify] https://crrev.com/634697b5871cac5bee8850a965b97e23961fd8c8/chrome/browser/sync/sync_ui_util.cc

Status: Fixed (was: Assigned)
Fixed. Please verify.
Verified

Google Chrome	57.0.2986.0 (Official Build) dev (64-bit)
Revision	12c8d70173fc1a04fa588b75be71ab5e80655c60-refs/heads/master@{#444600}

Sign in to add a comment