md-settings: Sync summary shows "Sync everything" with only some sync data types selected
Reported by
vanantwe...@gmail.com,
Nov 3 2016
|
|||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2906.0 Safari/537.36 Steps to reproduce the problem: 1. Go to chrome://help 2. Navigate to settings 3. Have sync settings which sync all except for bookmarks 4. Check the text: On - sync everything What is the expected behavior? What went wrong? It shows: On - sync everything I would expect something like: On - sync partial Did this work before? N/A Chrome version: 56.0.2906.0 Channel: dev OS Version: Ubuntu 14.04 Flash Version: N/A
,
Nov 7 2016
,
Nov 9 2016
I agree that the sync summary should not be "Sync everything" if ... only some things are being synced.
,
Nov 9 2016
,
Nov 10 2016
Seems like a very reasonable point :) Alan - right now, the subtitle on the "Sync" row in MD settings is always "On - sync everything" if sync is on, working, and there's no error. We should probably update the subtitle if you have unchecked specific data types. What do you think we should use as the subtitle? We could just go with "On." Or perhaps "On - choose what to sync" (which is the phrase we use in current settings advanced sync settings: https://screenshot.googleplex.com/0ytOEZaFwiR.png - though that is a slightly different context).
,
Jan 10 2017
How about "On - sync some things"? :-) My 2nd favorite would just be "On"
,
Jan 10 2017
"On - sync some things" feels a little awkward to me. I would be happy with just "On." Just waiting on Alan's input.
,
Jan 10 2017
Or a slight variant of Tom's suggestion: "On - syncing some things"
,
Jan 11 2017
How does "On - custom settings" sound?
,
Jan 11 2017
"On - custom settings" SGTM Re-assigning to Tommy for implementation.
,
Jan 13 2017
SGTM with one clarification: If the user unchecks the Sync everything toggle, but leaves all the data types still enabled, I highly recommend also displaying the "On - custom settings". I suggest this because the sync prefs code keeps a separate flag for the default syncing everything state, and it would be smart to match the string to that flag. "On - custom settings" is still accurate to that state anyways.
,
Jan 13 2017
Well here's the CL with the changes in c#11: https://codereview.chromium.org/2631803002/ I just sent it out for review.
,
Jan 18 2017
Yep, the behavior described in #11 SGTM. Thanks Tommy :)
,
Jan 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/634697b5871cac5bee8850a965b97e23961fd8c8 commit 634697b5871cac5bee8850a965b97e23961fd8c8 Author: tommycli <tommycli@chromium.org> Date: Wed Jan 18 17:24:58 2017 MD Settings People: Display "On - custom settings" for custom data types When the user has a custom data types synced, display "On - custom settings" instead of "On - sync everything". BUG= 662025 Review-Url: https://codereview.chromium.org/2631803002 Cr-Commit-Position: refs/heads/master@{#444409} [modify] https://crrev.com/634697b5871cac5bee8850a965b97e23961fd8c8/chrome/app/generated_resources.grd [modify] https://crrev.com/634697b5871cac5bee8850a965b97e23961fd8c8/chrome/browser/sync/sync_ui_util.cc
,
Jan 18 2017
Fixed. Please verify.
,
Jan 21 2017
Verified Google Chrome 57.0.2986.0 (Official Build) dev (64-bit) Revision 12c8d70173fc1a04fa588b75be71ab5e80655c60-refs/heads/master@{#444600} |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by hdodda@chromium.org
, Nov 4 2016Components: -UI UI>Settings Services>Sync
Labels: Proj-MaterialDesign-WebUI M-56 OS-Mac OS-Windows
Status: Untriaged (was: Unconfirmed)