Issue metadata
Sign in to add a comment
|
2.3%-100% regression in webrtc_perf_tests at 14815:14821 |
||||||||||||||||||||
Issue descriptionLooks like the level controller tests have regressed to a new level. The graphs are a bit noisy, and maybe these tests are bit too sensitive? Commit positions 15-21 or so are implied, and this gives us this blamelist: https://chromium.googlesource.com/external/webrtc/+log/48dfab5..c4b9b9419e441e188 c4b9b94 Revert of Replace FileWrapper with File (in audio_device) (patchset #3 id:40001 of https://codereview.webrtc.org/2386963003/ ) by terelius · 6 days ago 6ceab08 GN: New conventions, default target and refactorings by kjellander · 6 days ago 9f4a4a0 Add empty residual echo detector. by ivoc · 6 days ago a9a1ac2 Moved rtc::Base64 to base approved. by philipel · 6 days ago 02ba211 Move RTCStatsCollector helper functions to anonymous namespace. by hbos · 6 days ago f005a00 Added calling of the stream_analog_level api in audioproc_f by peah · 6 days ago 6d6762c Add UINavigationController and settings bar button to AppRTCMobile. by denicija · 6 days ago 5da65f2 Revert of Change ViEEncoder to not reconfigure the encoder until the video resolution is known. (patchset #4 id:60001 of https://codereview.webrtc.org/2455063002/ ) by perkj · 6 days ago
,
Nov 3 2016
Similar to https://bugs.chromium.org/p/chromium/issues/detail?id=659767. ... And they're just on a single bot, which lowers confidence in these results. If they're true, this regression looks to be mac only.
,
Nov 3 2016
cc:ing authors in the blame range.
,
Nov 3 2016
I filed several perf bugs last week for level controller metrics, so I think this may be a continuation of those... I'm quite sure my GN refactoring is innocent.
,
Nov 10 2016
It does not make sense that these regressions occur from this CL. I think it is an issue with the test and I have filed a webrtc bug for this (https://bugs.chromium.org/p/webrtc/issues/detail?id=6685) I will close this issue, as the absolute size of the regressions is small. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by phoglund@chromium.org
, Nov 3 2016