Regression: [MD settings]Page does not navigate to 'People' section from 'Content Settings'.
Reported by
jshan...@etouch.net,
Nov 3 2016
|
||||||||
Issue descriptionChrome Version : 56.0.2908.0 (Official Build) e8eaccd054223465b7eb83989b161b9f5574387b-refs/heads/master@{#429486} 32/64-bit OS : Mac(10.10.5, 10.11.4, 10.11.5), Windows(7,8,8.1,10), Linux (14.04 LTS) Steps: 1. Launch Chrome and navigate to chrome://md-settings 2. Click on 'Advanced', then click on 'Content Settings' 3. Now click on 'Main menu' icon, then click on 'People' and observe Actual: Page does not navigate to 'People' section from 'Content Settings' after clicking on it. Expected: Page should navigate to 'People' section from 'Content Settings' section after clicking on it. This is a regression issue broken in M-55, will soon update bisect info Good build : 55.0.2879.0 Bad build : 55.0.2880.0
,
Nov 3 2016
not great
,
Nov 3 2016
,
Nov 4 2016
Using the per-revision bisect providing the bisect results, Good build: 55.0.2879.0 (Revision: 422347). Bad build: 55.0.2880.0 (Revision: 422654). You are probably looking for a change made after 422624 (known good), but no later than 422625 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/4b442abfbfcd93afdd00d7dd106e71bddbaf19ac..6dabb5a5dcefa2d2a775bd5abdf64f87e8aa2621 @michaelpg -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Thank You.
,
Nov 15 2016
Fun, a race condition. <settings-basic-page> calls |currentSection.scrollIntoView()| before <settings-advanced-page> calls |section.animateCollapse()|.
,
Nov 22 2016
Just to to update the latest behavior of the bug, Issue is still observed on chrome latest Canary M57-57.0.2926.0 michaelpg@ Could you please let us know is there any recent update available on this issue? Thanks!
,
Nov 22 2016
,
Nov 23 2016
,
Dec 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5c56bfabcf3c9bb97e1893deba3f61c982b6ef5 commit c5c56bfabcf3c9bb97e1893deba3f61c982b6ef5 Author: michaelpg <michaelpg@chromium.org> Date: Thu Dec 15 04:29:09 2016 MD Settings: Move settings-advanced-page into settings-basic-page Merges settings-basic-page and settings-advanced-page by into one element. This simplifies a lot of behavior (we no longer have two MainPageBehavior instances trying to scroll #mainContainter at the same time) which fixes some bugs for free. Functionality in settings-main that was specific to the settings pages has been moved into settings-basic page, simplifying settings-main. Unfortunately, settings-main still shares an annoying amount with setting-basic-page, namely inSearchMode and advancedToggleExpanded. The main bug this fixes is issue 662004 : tapping a Basic page section from an Advanced page sub-page (or vice versa) would fail to scroll to the new section. Minor bugs that this fixes: * after opening a subpage, tapping a section in the nav menu closed the subpage but only jumped to the new section after an awkward delay * after loading a subpage URL, tapping the back icon button caused the page to jump to the top, then back down * navigating from a Basic subpage to an Advanced subpage, or vice versa, would have hidden one of the main pages while transitioning Note: settings-basic-page should be renamed now that "basic" is meaningless, but unfortunately every conceivable alternative name is already taken, except for settings-settings-page which is horrible for reasons too numerous to mention. BUG= 662004 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2518233004 Cr-Commit-Position: refs/heads/master@{#438738} [delete] https://crrev.com/4b39f0247b96125c94a71dd3323ea16b8deac182/chrome/browser/resources/settings/advanced_page/advanced_page.html [delete] https://crrev.com/4b39f0247b96125c94a71dd3323ea16b8deac182/chrome/browser/resources/settings/advanced_page/advanced_page.js [delete] https://crrev.com/4b39f0247b96125c94a71dd3323ea16b8deac182/chrome/browser/resources/settings/advanced_page/compiled_resources2.gyp [modify] https://crrev.com/c5c56bfabcf3c9bb97e1893deba3f61c982b6ef5/chrome/browser/resources/settings/basic_page/basic_page.html [modify] https://crrev.com/c5c56bfabcf3c9bb97e1893deba3f61c982b6ef5/chrome/browser/resources/settings/basic_page/basic_page.js [modify] https://crrev.com/c5c56bfabcf3c9bb97e1893deba3f61c982b6ef5/chrome/browser/resources/settings/basic_page/compiled_resources2.gyp [modify] https://crrev.com/c5c56bfabcf3c9bb97e1893deba3f61c982b6ef5/chrome/browser/resources/settings/compiled_resources2.gyp [modify] https://crrev.com/c5c56bfabcf3c9bb97e1893deba3f61c982b6ef5/chrome/browser/resources/settings/search_settings.js [modify] https://crrev.com/c5c56bfabcf3c9bb97e1893deba3f61c982b6ef5/chrome/browser/resources/settings/settings_main/compiled_resources2.gyp [modify] https://crrev.com/c5c56bfabcf3c9bb97e1893deba3f61c982b6ef5/chrome/browser/resources/settings/settings_main/settings_main.html [modify] https://crrev.com/c5c56bfabcf3c9bb97e1893deba3f61c982b6ef5/chrome/browser/resources/settings/settings_main/settings_main.js [modify] https://crrev.com/c5c56bfabcf3c9bb97e1893deba3f61c982b6ef5/chrome/browser/resources/settings/settings_page/main_page_behavior.js [modify] https://crrev.com/c5c56bfabcf3c9bb97e1893deba3f61c982b6ef5/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/c5c56bfabcf3c9bb97e1893deba3f61c982b6ef5/chrome/test/data/webui/settings/advanced_page_browsertest.js [modify] https://crrev.com/c5c56bfabcf3c9bb97e1893deba3f61c982b6ef5/chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js [modify] https://crrev.com/c5c56bfabcf3c9bb97e1893deba3f61c982b6ef5/chrome/test/data/webui/settings/languages_page_browsertest.js [modify] https://crrev.com/c5c56bfabcf3c9bb97e1893deba3f61c982b6ef5/chrome/test/data/webui/settings/settings_main_test.js [modify] https://crrev.com/c5c56bfabcf3c9bb97e1893deba3f61c982b6ef5/chrome/test/data/webui/settings/settings_page_browsertest.js [modify] https://crrev.com/c5c56bfabcf3c9bb97e1893deba3f61c982b6ef5/chrome/test/data/webui/settings/settings_subpage_browsertest.js
,
Dec 17 2016
,
Dec 21 2016
Verified on ChromeOS 9107.0.0, 57.0.2957.0 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by shrike@chromium.org
, Nov 3 2016