☂ Address performance concerns in [TabModel sessionForSaving] |
||||||||||||||||
Issue descriptionSee todo in tab_model.mm. The original todo was: // Build the array of sessions. Copy the session objects as the saving will // be done on a separate thread. // TODO(pinkerton): This could get expensive especially since this window // may never be saved (if another call comes in before the delay). ⛆ |
|
|
,
Nov 3 2016
I haven't noticed any performance issues, but I tend to not use many Tabs. We could add some synchronization code to prevent doing this work twice, but I don't think we have any evidence that this is an issue.
,
Nov 3 2016
Stepan, should we just cleanup that TODO?
,
Nov 3 2016
I don't remember the original issue very well, but I imagine I was just flagging the potential for slowness that needed vetting further. It's probably ok to just ignore it.
,
Mar 30 2017
,
May 23 2017
,
May 23 2017
,
May 23 2017
,
May 23 2017
,
May 24 2017
,
May 24 2017
,
May 24 2017
,
Jun 2 2017
,
Nov 10 2017
,
Jun 11 2018
,
Sep 20
|
|||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by eugene...@chromium.org
, Nov 3 2016Labels: -Type-Bug Type-Feature
Status: Available (was: Unconfirmed)