Once more of the navigation state has moved into WC, replace "this" with WCO |
|||||||||
Issue descriptionSee todo in tab_model.h. The original todo was: // TODO(stuartmorgan): once more of the navigation state has moved into WC, // replace this with WCO. - (void)navigationCommittedInTab:(Tab*)tab; I couldn't decrypt what WCO is, and I guess the WC is WebController?
,
Nov 4 2016
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/573bd7b3152aba99ff74ad02ae1aa846ad32a448 commit 573bd7b3152aba99ff74ad02ae1aa846ad32a448 Author: sdefresne <sdefresne@chromium.org> Date: Fri Mar 03 00:12:49 2017 Remove NavigationManager::GetPreviousItem(). The only location interested in the previous navigation item was a callback that received the index of the item via its parameter so use the parameter to access the navigation item and remove the obsolete method. Add some helper methods to CRWSessionController to avoid creating and then destroying std::vector<> everytime the list of navigation items was queried. BUG= 661983 Review-Url: https://codereview.chromium.org/2724073005 Cr-Commit-Position: refs/heads/master@{#454450} [modify] https://crrev.com/573bd7b3152aba99ff74ad02ae1aa846ad32a448/ios/chrome/browser/tabs/tab.mm [modify] https://crrev.com/573bd7b3152aba99ff74ad02ae1aa846ad32a448/ios/chrome/browser/tabs/tab_model.h [modify] https://crrev.com/573bd7b3152aba99ff74ad02ae1aa846ad32a448/ios/chrome/browser/tabs/tab_model.mm [modify] https://crrev.com/573bd7b3152aba99ff74ad02ae1aa846ad32a448/ios/web/navigation/crw_session_controller.h [modify] https://crrev.com/573bd7b3152aba99ff74ad02ae1aa846ad32a448/ios/web/navigation/crw_session_controller.mm [modify] https://crrev.com/573bd7b3152aba99ff74ad02ae1aa846ad32a448/ios/web/navigation/navigation_manager_impl.h [modify] https://crrev.com/573bd7b3152aba99ff74ad02ae1aa846ad32a448/ios/web/navigation/navigation_manager_impl.mm [modify] https://crrev.com/573bd7b3152aba99ff74ad02ae1aa846ad32a448/ios/web/navigation/navigation_manager_impl_unittest.mm
,
Mar 30 2017
,
Mar 30 2017
,
Apr 13 2017
,
Jul 11 2017
,
Jul 12
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 12
,
Jan 4
,
Jan 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b117c3202ed77ed13e450819e608b647da6fc4b1 commit b117c3202ed77ed13e450819e608b647da6fc4b1 Author: Eugene But <eugenebut@google.com> Date: Mon Jan 07 21:00:28 2019 Remove -[TabModel navigationCommittedInTab:previousItem:]. The body of the method was simplified and merged into the caller. Most of the old code was related to calculation of "is in-page navigation" boolean flag, which is actually present in LoadCommittedDetails. New code simply uses LoadCommittedDetails.is_in_page flag. The motivation for the change is to eventually replace didCommitNavigationWithDetails with didFinishNavigation. didFinishNavigation does not provide "previous navigation item" pointer, which was used in the old code. Bug: 661983 Change-Id: Ida8ffa4c1127a2750be642e29bb86e90d42dfad9 Reviewed-on: https://chromium-review.googlesource.com/c/1396451 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#620466} [modify] https://crrev.com/b117c3202ed77ed13e450819e608b647da6fc4b1/ios/chrome/browser/tabs/tab_model.h [modify] https://crrev.com/b117c3202ed77ed13e450819e608b647da6fc4b1/ios/chrome/browser/tabs/tab_model.mm
,
Jan 7
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by eugene...@chromium.org
, Nov 3 2016Labels: -Type-Bug Type-Feature
Owner: ----
Status: Available (was: Unconfirmed)