New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 661969 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

view-source does not work

Reported by giol...@gmail.com, Nov 3 2016

Issue description

Chrome Version       : 54.0.2840.87 m
URLs (if applicable) : view-source:
Other browsers tested:
 Opera 	41.0.2353.46, same problem


What steps will reproduce the problem?
(1) Page source code is less than 4 symbols
(2) if page source code is 1,2 or 3 sybmbols  view-source will show no info

 
2016-11-03_15-37-00.png
7.0 KB View Download
2016-11-03_15-37-08.png
8.0 KB View Download
Cc: krajshree@chromium.org
Components: Blink>ViewSource
Labels: Needs-Feedback
giolaza@ - Could you please provide a sample html file to test this issue. Also please provide the expected and actual behavior of the issue.

Thanks...!!

Comment 2 by giol...@gmail.com, Nov 4 2016

Test result:
  file sampleUTF8.html, encoding UFT-8 with BOM
  I open this file in chrome, after open view-source://this file link  (hotkey CTRL+U) - its all ok.

  file sampleASCII.html, encoding ASCII
  I open this file in chrome, after open view-source://this file link - and source code is empty. 
  Test shows that if source code length is less than 4, view-source://  (hotkey CTRL+U) will show an empty result.

  file sampleUTF8withoutBOM.html, encoding UFT-8 without BOM
  I open this file in chrome, after open view-source://this file link - and source code is empty. 
  Test shows that if source code length is less than 4, view-source://  (hotkey CTRL+U) will show an empty result.

Result: if source file code is 1, 2 or 3 symbols page source (hotkey CTRL+U) will show an empty result that is not good.


  

sampleUTF8.html
6 bytes View Download
sampleASCII.html
3 bytes View Download
sampleUTF8withoutBOM.html
3 bytes View Download

Comment 3 by giol...@gmail.com, Nov 4 2016

Second test: this files in host:
http://crypcode.com/google/sampleUTF8.html
http://crypcode.com/google/sampleASCII.html
http://crypcode.com/google/sampleUTF8withoutBOM.html


test result is same.

Third result: check same code with php headers
http://crypcode.com/google/sampleUTF8.php
http://crypcode.com/google/sampleASCII.php
http://crypcode.com/google/sampleUTF8withoutBOM.php

Result is same.


sampleUTF8.php
66 bytes View Download
sampleASCII.php
63 bytes View Download
sampleUTF8withoutBOM.php
63 bytes View Download

Comment 4 by giol...@gmail.com, Nov 4 2016

My system is Windows 7 x64
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 11 2016

Labels: -Needs-Feedback Needs-Review
Owner: krajshree@chromium.org
Thank you for providing more feedback. Adding requester "krajshree@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Type-Bug -Pri-3 -Needs-Review hasbisect-per-revision M-56 OS-Linux OS-Mac OS-Windows Pri-1 Type-Bug-Regression
Owner: tzik@chromium.org
Status: Assigned (was: Unconfirmed)
giolaza@ - Sorry for late reply.

Able to reproduce the issue on Windows 10, Ubuntu 14.04, Mac OS 10.11.6 using reported version #54.0.2840.87 and latest canary #57.0.2934.0.

Bisect Information:
=====================
Good build: 54.0.2823.0  Revision(410278)
Bad Build : 54.0.2824.0  Revision(410520)

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/9ff5d04a4b2c1359b2d02bf038534fb57371f0cf..c792d1ca228e3fd8fc254c9a8f3a51e5e5d76832

From the above change log suspecting below change

Review-Url: https://codereview.chromium.org/2212393003

tzik@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks...!!

Comment 7 by giol...@gmail.com, Nov 29 2016

I checked on Windows 10 x64 pro eng
Chrome version #54.0.2840.99 m
Same problem

Comment 8 by giol...@gmail.com, Nov 29 2016

Unfortunately, I have no #54.0.2840.87.
Now On win 7 my vers is 54.0.2840.99 m, same on Win 10

Labels: -M-56 M-54
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1dc6c96302f6607d3ecc2a230ecf05521bff1066

commit 1dc6c96302f6607d3ecc2a230ecf05521bff1066
Author: tzik <tzik@chromium.org>
Date: Fri Dec 02 08:44:16 2016

Flush HTMLViewSourceParser on the end of document

Undecoded bytes may be left in the TextResourceDecoder on view-source
mode document.

BUG= 661969 

Review-Url: https://codereview.chromium.org/2542393002
Cr-Commit-Position: refs/heads/master@{#435888}

[modify] https://crrev.com/1dc6c96302f6607d3ecc2a230ecf05521bff1066/third_party/WebKit/Source/core/html/parser/HTMLViewSourceParser.cpp

Comment 11 by tzik@chromium.org, Jan 17 2017

Status: Fixed (was: Assigned)

Comment 12 by tzik@chromium.org, Jan 17 2017

Cc: tzik@chromium.org kkaluri@chromium.org
 Issue 681429  has been merged into this issue.

Sign in to add a comment