New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 661965 link

Starred by 2 users
Status: Fixed
Owner:
tommycli@chromium.org
Closed: Nov 2016
Cc:
nyerramilli@chromium.org
dbeam@chromium.org
█ msrchandra@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : On navigating to chrome://md-settings/signOut URL, ‘Sign Out’ dialog box is seen even when the user is not signed in.

Reported by yfulgaon...@etouch.net, Nov 3 2016 
Chrome Version : 56.0.2908.0 (Official Build) e8eaccd054223465b7eb83989b161b9f5574387b-refs/heads/master@{#429486} 32/64-bit
OS : Mac(10.10.5, 10.11.4, 10.11.5), Windows(7,8,8.1,10), Linux (14.04 LTS)

What steps will reproduce the problem?
1. Launch Chrome and navigate to chrome://md-settings/signOut URL.
2. Observe the ‘Sign Out’ dialog box.

Actual : On navigating to chrome://md-settings/signOut URL, ‘Sign Out’ dialog box is seen even when the user is not signed in.
Expected : Instead, it should only redirect to ‘chrome://md-settings' page without displaying ’Sign Out’ dialog box.

This is a regression issue broken in ‘M-55’, below is the Manual Regression range and will soon update bisect info.
Good build : 55.0.2844.0
Bad build : 55.0.2845.0
Act_md-settings.png
98.7 KB View Download
Actual_md-settings.mov
3.0 MB Download
Expected_md-settings.mov
2.9 MB Download

Comment 1 by msrchandra@chromium.org, Nov 3 2016

Owner: tommycli@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 55.0.2844.0 (Revision: 415023).
Bad build: 55.0.2845.0 (Revision: 415522).

You are probably looking for a change made after 415327 (known good), but no later than 415328 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/07b17a8e40eb4af58b716e5dc1eba449f11ff920..bd5e51eb0cfaa6620b522ef52f549d7c1f158775

@tommycli -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Thank You.

Comment 2 by tommycli@chromium.org, Nov 3 2016 

Indeed you found the right person. It's not a super urgent bug, since this hasn't shipped to users yet, but I'll get to it eventually.

Comment 3 by tommycli@chromium.org, Nov 3 2016

Cc: dbeam@chromium.org
And thanks for the bug report!

Comment 4 by manoranj...@chromium.org, Nov 3 2016

Labels: hasbisect-per-revision

Comment 5 by dpa...@chromium.org, Nov 15 2016

Labels: Proj-MaterialDesign-WebUI
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be82f91e1f87efcdb4328cb463db5359accb7e73

commit be82f91e1f87efcdb4328cb463db5359accb7e73
Author: tommycli <tommycli@chromium.org>
Date: Tue Nov 15 19:49:26 2016

MD Settings: Suppress the signout dialog if user is not signed in.

Recently we added the /signOut route for the navigable sign out dialog.

This created problems, since the user can navigate there by URL
(or have the URL in history) even if the user is not signed in.

This CL adds logic to exit the sign out dialog route if the user is not
signed in.

BUG= 661965 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2498013003
Cr-Commit-Position: refs/heads/master@{#432236}

[modify] https://crrev.com/be82f91e1f87efcdb4328cb463db5359accb7e73/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/be82f91e1f87efcdb4328cb463db5359accb7e73/chrome/test/data/webui/settings/people_page_test.js

Comment 7 by tommycli@chromium.org, Nov 16 2016

Labels: -M-55
Status: Fixed (was: Assigned)
►

Sign in to add a comment