https://codereview.chromium.org/2472973002/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7187fe2ac3d98d0219268914aeddf4eb03c5f42b

commit 7187fe2ac3d98d0219268914aeddf4eb03c5f42b
Author: rune <rune@opera.com>
Date: Fri Nov 04 13:42:20 2016

Link stylesheets in shadow trees do not belong to document scope.

We have incorrectly kept DCHECKs checking that stylesheets in shadow
trees come from style elements. That is no longer true, and modifying
link elements in shadow trees would trigger some of these DCHECKs.

Also, we simply used Document as the TreeScope handling link elements.
Always use the treeScope() from the associated node instead. Using the
wrong TreeScope in these cases would cause missing updates of active
stylesheets in ShadowTreeStyleSheetCollections for AnalyzedStyleUpdate.
I have not been able to find a triggering test case for this.

R=hayato@chromium.org,kochi@chromium.org
BUG= 661914 

Review-Url: https://codereview.chromium.org/2472973002
Cr-Commit-Position: refs/heads/master@{#429877}

[add] https://crrev.com/7187fe2ac3d98d0219268914aeddf4eb03c5f42b/third_party/WebKit/LayoutTests/shadow-dom/crashes/link-style-change-href-assert.html
[modify] https://crrev.com/7187fe2ac3d98d0219268914aeddf4eb03c5f42b/third_party/WebKit/Source/core/dom/StyleEngine.cpp

Merge to 55 required for the merge of fix for  issue 659596  to 55 to have full effect.

Your change meets the bar and is auto-approved for M55 (branch: 2883)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e5e70acdb5e1946af50c8565fdc9728529f84f1

commit 0e5e70acdb5e1946af50c8565fdc9728529f84f1
Author: Rune Lillesveen <rune@opera.com>
Date: Fri Nov 11 14:57:54 2016

Link stylesheets in shadow trees do not belong to document scope.

We have incorrectly kept DCHECKs checking that stylesheets in shadow
trees come from style elements. That is no longer true, and modifying
link elements in shadow trees would trigger some of these DCHECKs.

Also, we simply used Document as the TreeScope handling link elements.
Always use the treeScope() from the associated node instead. Using the
wrong TreeScope in these cases would cause missing updates of active
stylesheets in ShadowTreeStyleSheetCollections for AnalyzedStyleUpdate.
I have not been able to find a triggering test case for this.

R=hayato@chromium.org,kochi@chromium.org
BUG= 661914 

Review-Url: https://codereview.chromium.org/2472973002
Cr-Commit-Position: refs/heads/master@{#429877}
(cherry picked from commit 7187fe2ac3d98d0219268914aeddf4eb03c5f42b)

Review URL: https://codereview.chromium.org/2500513002 .

Cr-Commit-Position: refs/branch-heads/2883@{#538}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[add] https://crrev.com/0e5e70acdb5e1946af50c8565fdc9728529f84f1/third_party/WebKit/LayoutTests/shadow-dom/crashes/link-style-change-href-assert.html
[modify] https://crrev.com/0e5e70acdb5e1946af50c8565fdc9728529f84f1/third_party/WebKit/Source/core/dom/StyleEngine.cpp

Tested the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.11.6 using chrome version 55.0.2883.52 with the link-assert.html.
Observed that the text is not red.Please find the attached screen shot for the same.

Hence adding TE-Verified label. 

Thanks,

Deleted: 661914.png 58.7 KB

	661914.png 58.7 KB View Download