trunksd: when cr50_onboard is set, trunks didn't add chromeos-base/chromeos-cr50 into runtime dependency. |
|||||||||
Issue descriptionVersion: 8853+ OS: Chrome What steps will reproduce the problem? (1) build_image factory_install (2) Boot the image What is the expected output? Boot to menu What do you see instead? Stuck in Upstart, system-services can't enter "started" state. The change https://chromium-review.googlesource.com/#/c/375960/ introduced a new trunksd.conf.cr50 to be installed if use flag cr50_onboard is set. It has such rule: start on stopped cr50-result and started dbus However, cr50-result is installed by chromeos-base/chromeos-cr50, which is pulled into image only in virtual/target-chromium-os/target-chromium-os . That means, any targets that pulled in trunksd and is not a complete chromiumos image will fail - for example, factory shim (build_image factory_install). From the package dependency perspective, I believe trunksd ebuild should include chromeos-cr50 in RDEPEND if cr50_onboard useflag is set.
,
Nov 3 2016
Or, I think maybe we should rewrite the rule to trunksd.conf start on starting system-services cr50-update.conf start on starting trunksd
,
Nov 3 2016
trunksd should not run before cr50-update finished, that's the purpose of the init dependency. I agree that adding chromeos-cr50 RDEPEND to trunksd conditional on cr50_onboard is the right fix. Hung-Te, can you please try it? I don't build factory image regularly and this is just a one line change easy to try...
,
Nov 3 2016
Re#3: I thought job B as "start on starting A" would block the execution of A (the real command is executed in 'started', not 'starting') until B is finished, but I may be wrong - well, seems like there must be other rule to block it, and that's what happened in our current init. If you agree with the proposal (add right depend) I can do it.
,
Nov 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/cc6518585cac67b816060b6f3481f6dc29202a72 commit cc6518585cac67b816060b6f3481f6dc29202a72 Author: Hung-Te Lin <hungte@chromium.org> Date: Thu Nov 03 15:40:16 2016 chromeos-base/trunks: Add chromeos-cr50 if cr50_onboard is set. When cr50_onboard is set, trunksd.conf will need cr50-result job to finish, which is installed by package chromeos-base/chromeos-cr50. BUG= chromium:661883 TEST=./build_packages --board gru; ./build_image --board gru factory_install Change-Id: I632ee91c2c7d9a1ee573442140d70e4f06e20537 Reviewed-on: https://chromium-review.googlesource.com/406748 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Vadim Bendebury <vbendeb@chromium.org> [modify] https://crrev.com/cc6518585cac67b816060b6f3481f6dc29202a72/chromeos-base/trunks/trunks-9999.ebuild
,
Nov 4 2016
,
Nov 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5afaee349970d5075d91592b30bf4c8ccd69112f commit 5afaee349970d5075d91592b30bf4c8ccd69112f Author: Hung-Te Lin <hungte@chromium.org> Date: Thu Nov 03 15:40:16 2016 chromeos-base/trunks: Add chromeos-cr50 if cr50_onboard is set. When cr50_onboard is set, trunksd.conf will need cr50-result job to finish, which is installed by package chromeos-base/chromeos-cr50. BUG= chromium:661883 TEST=./build_packages --board gru; ./build_image --board gru factory_install Change-Id: I632ee91c2c7d9a1ee573442140d70e4f06e20537 Reviewed-on: https://chromium-review.googlesource.com/406748 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Vadim Bendebury <vbendeb@chromium.org> (cherry picked from commit cc6518585cac67b816060b6f3481f6dc29202a72) Reviewed-on: https://chromium-review.googlesource.com/414650 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Queue: Hung-Te Lin <hungte@chromium.org> Trybot-Ready: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/5afaee349970d5075d91592b30bf4c8ccd69112f/chromeos-base/trunks/trunks-9999.ebuild
,
Jan 21 2017
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by hungte@chromium.org
, Nov 3 2016