New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 661882 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Grouped history searches by month always search to current day

Project Member Reported by calamity@chromium.org, Nov 3 2016

Issue description

When using grouped history, navigating through months always leaves the end-time at the current day. i.e all months query from the start date til now, rather than just a single month.
 

Comment 1 by dbeam@chromium.org, Nov 9 2016

Cc: tbuck...@chromium.org
so just to double-check what you expect:

on Nov 15, when you click "Month" you expect roughly Oct 15 - Nov 15 rather than Nov 1 - Nov 15 (which is what's happening now)?  is that correct?

this is how week works (just the last 7 days), so we should probably be consistent.  we might want to double-check this isn't intentional, though.
It's more than that: In the old UI, the end date for the month view is always today.

When I switch to month view and click the left arrow to go back in time, I get:

Tuesday, November 1, 2016 to Today - Thursday, November 10, 2016
Saturday, October 1, 2016 to Today - Thursday, November 10, 2016
Thursday, September 1, 2016 to Today - Thursday, November 10, 2016

In effect, it's not grouping by "one month at a time", but "all history entries from n months ago until now"
FwpYFM35dRz.png
69.5 KB View Download

Comment 3 by dbeam@chromium.org, Nov 9 2016

ah, yeah, ok
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e33a4d2c2d2add03be4ddfcb9647781d947b516

commit 2e33a4d2c2d2add03be4ddfcb9647781d947b516
Author: calamity <calamity@chromium.org>
Date: Thu Nov 17 09:14:08 2016

Fix grouped history query range for months.

This CL fixes an issue where the end times for grouped history queries
were not being set and adds tests to prevent regressions.

BUG= 661882 

Review-Url: https://codereview.chromium.org/2464323004
Cr-Commit-Position: refs/heads/master@{#432824}

[modify] https://crrev.com/2e33a4d2c2d2add03be4ddfcb9647781d947b516/chrome/browser/ui/webui/browsing_history_handler.cc
[modify] https://crrev.com/2e33a4d2c2d2add03be4ddfcb9647781d947b516/chrome/browser/ui/webui/browsing_history_handler.h
[modify] https://crrev.com/2e33a4d2c2d2add03be4ddfcb9647781d947b516/chrome/browser/ui/webui/browsing_history_handler_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment