New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 661865 link

Starred by 4 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

gn's "all" target should probably build all targets in the default toolchain and only targets reachable from those in other toolchains

Project Member Reported by thakis@chromium.org, Nov 3 2016

Issue description

https://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroid%20x64?numbuilds=200 builds 'all' to check that all targets build fine. It looks like this currently means "build all targets, with all toolchains".  The x64 Android build has a 64-bit and a 32-bit build, and has host and target toolchains -- as a result, the bot builds 71372 edges in a build (it's a clobber bot).  Before I switched it to building 'all', it build only "many" test binaries, which required 32997 edges. (Most edges of the host toolchains aren't needed, for example.)

I think 'all' shouldn't build all the targets with e.g. a host toolchain -- it makes more sense to me that 'all' should build everything with the default toolchain, and include all targets depended on explicitly in different toolchains (?)
 
"all" is supposed to work the way you describe. Can you provide examples of things that you think shouldn't be building?
Status: WontFix (was: Untriaged)
You're right, I didn't read the build output carefully enough. Sorry! Thanks for explaining.

(The big increase in build targets is due to edges starting "CXX android_clang_x86"; I guess building the 32-bit version of the build isn't depended on by anything by default.)
Yup, I'd expect the "fat binary" aspect of the android builds w/ monochrome make the build a lot larger.

Sign in to add a comment