gn's "all" target should probably build all targets in the default toolchain and only targets reachable from those in other toolchains |
||
Issue descriptionhttps://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroid%20x64?numbuilds=200 builds 'all' to check that all targets build fine. It looks like this currently means "build all targets, with all toolchains". The x64 Android build has a 64-bit and a 32-bit build, and has host and target toolchains -- as a result, the bot builds 71372 edges in a build (it's a clobber bot). Before I switched it to building 'all', it build only "many" test binaries, which required 32997 edges. (Most edges of the host toolchains aren't needed, for example.) I think 'all' shouldn't build all the targets with e.g. a host toolchain -- it makes more sense to me that 'all' should build everything with the default toolchain, and include all targets depended on explicitly in different toolchains (?)
,
Nov 3 2016
,
Nov 3 2016
You're right, I didn't read the build output carefully enough. Sorry! Thanks for explaining. (The big increase in build targets is due to edges starting "CXX android_clang_x86"; I guess building the 32-bit version of the build isn't depended on by anything by default.)
,
Nov 3 2016
Yup, I'd expect the "fat binary" aspect of the android builds w/ monochrome make the build a lot larger. |
||
►
Sign in to add a comment |
||
Comment 1 by dpranke@chromium.org
, Nov 3 2016