New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 661864 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Add histograms for ArcGVDA in Chrome and ask QA to veiryify them when testing apps.

Project Member Reported by owenlin@chromium.org, Nov 3 2016

Issue description

We would like to make sure HW decoded is used for popular video apps. such as YouTube, Play Movies, Netflix.

We plan to add a new histogram into chrome so that QA or test can easily verify the HW codec is used on ARC++

 
Cc: owenlin@chromium.org
Components: OS>Kernel>Video
Labels: -Pri-3 M-57 Pri-2
Owner: johnylin@chromium.org
Load balancing.
Just noticed this one. I would ask Owen for more details then.
https://codereview.chromium.org/2506363003/
CL is waiting for the review of the owner of histograms.xml. Didn't hear from him for a couple days (Thanksgiving maybe), will ping him today.
Johny. Does histograms.xml have another OWNER you can add?
I have added another owner to review also.

Comment 6 by vsu...@chromium.org, Nov 29 2016

Cc: vsu...@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9448e050e5d0ba0862b23438b8ebcd61c756dac2

commit 9448e050e5d0ba0862b23438b8ebcd61c756dac2
Author: johnylin <johnylin@chromium.org>
Date: Tue Nov 29 03:55:43 2016

Add Media.ArcGpuVideoDecodeAccelerator.InitializeResult to histograms

This enum result is recorded for verifying HW codec is used on ARC++,
or if there is any initialization error.

BUG= 661864 
TEST=test it on Elm and make sure the flag shows correct value in
chrome://histograms/Media.ArcGpuVideoDecodeAccelerator.InitializeResult

Review-Url: https://codereview.chromium.org/2506363003
Cr-Commit-Position: refs/heads/master@{#434880}

[modify] https://crrev.com/9448e050e5d0ba0862b23438b8ebcd61c756dac2/chrome/gpu/arc_gpu_video_decode_accelerator.cc
[modify] https://crrev.com/9448e050e5d0ba0862b23438b8ebcd61c756dac2/chrome/gpu/arc_gpu_video_decode_accelerator.h
[modify] https://crrev.com/9448e050e5d0ba0862b23438b8ebcd61c756dac2/chrome/gpu/arc_video_accelerator.h
[modify] https://crrev.com/9448e050e5d0ba0862b23438b8ebcd61c756dac2/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c061a5e08bd5e9da0ec7911bc8efb06c4ac23610

commit c061a5e08bd5e9da0ec7911bc8efb06c4ac23610
Author: Owen Lin <owenlin@google.com>
Date: Fri Dec 30 06:46:29 2016

cros/video: Add constants for AGVDA histogram.

This entry is used to detect the HW video decoder is requested from
ARC containers and is successfully initialized.

Test=Run the cheets_mediaPlayerVideoHWDecodeUsed tests.
Bug= chromium:661864 

Change-Id: Ibe45525d0edc2232c017a75dbe9e5c59f36ccc49
Reviewed-on: https://chromium-review.googlesource.com/424514
Commit-Ready: Owen Lin <owenlin@chromium.org>
Tested-by: Owen Lin <owenlin@chromium.org>
Reviewed-by: Owen Lin <owenlin@chromium.org>

[modify] https://crrev.com/c061a5e08bd5e9da0ec7911bc8efb06c4ac23610/client/cros/video/constants.py

Labels: VerifyIn-61
Cc: avkodipelli@chromium.org allendam@chromium.org
While playing youtube video, we've observed "Media.ChromeArcVideoDecodeAccelerator.InitializeResult" in histogram list, But as per above CL, it is expecting to have "Media.ArcGpuVideoDecodeAccelerator.InitializeResult", 
Is there anything we're missing while testing the histogram.
Classes were refactored afterwards as well as histogram name.
Please see this CL:
https://codereview.chromium.org/2928343002/

Thanks
Status: Verified (was: Fixed)
Thanks!

Sign in to add a comment