New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 661862 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 604105



Sign in to add a comment

bluetooth: Chooser shouldn't close when permission prompt is shown

Project Member Reported by ortuno@chromium.org, Nov 3 2016

Issue description

http://crrev.com/2369673003 introduced code to close the chooser when the window looses focus. This works great for when the user switches apps but it sadly causes the chooser to get closed when the permission prompt opens up.
 

Comment 1 by juncai@chromium.org, Mar 15 2017

https://bugs.chromium.org/p/chromium/issues/detail?id=676639
With the above issue fixed, I think this issue is also fixed now since the user only need to click the "Turn on Bluetooth to allow pairing" once and there is no permission prompt shown. So I will mark this issue as WontFix.

What do you think?

Comment 2 by juncai@chromium.org, Mar 15 2017

Cc: -juncai@chromium.org
Owner: juncai@chromium.org

Comment 3 by juncai@chromium.org, Mar 21 2017

Cc: scheib@chromium.org

Comment 4 by scheib@chromium.org, Mar 22 2017

Location access still requires us to use an intent and show the system settings activity. That results in the chooser being closed when the user returns. So, this issue is still valid.

Comment 5 by juncai@chromium.org, Mar 22 2017

Status: Started (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/729ec70ac51077fad0c36dc88d8e8a425eb77032

commit 729ec70ac51077fad0c36dc88d8e8a425eb77032
Author: juncai <juncai@chromium.org>
Date: Thu Mar 23 20:18:44 2017

Keep WebBluetooth chooser open when permission prompt is shown on Android

On Android, when WebBluetooth chooser is shown and needs to open
permission prompt, the chooser will be closed. This CL uses similar idea
as:
https://codereview.chromium.org/2622123002/
to keep the chooser open when permission prompt is shown.

BUG= 661862 

Review-Url: https://codereview.chromium.org/2772453003
Cr-Commit-Position: refs/heads/master@{#459197}

[modify] https://crrev.com/729ec70ac51077fad0c36dc88d8e8a425eb77032/chrome/android/java/src/org/chromium/chrome/browser/BluetoothChooserDialog.java
[modify] https://crrev.com/729ec70ac51077fad0c36dc88d8e8a425eb77032/chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java
[modify] https://crrev.com/729ec70ac51077fad0c36dc88d8e8a425eb77032/chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java

Comment 7 by juncai@chromium.org, Mar 23 2017

Status: Fixed (was: Started)

Sign in to add a comment