New issue
Advanced search Search tips

Issue 661859 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 651762



Sign in to add a comment

failed web-platform-tests html/dom/documents/dom-tree-accessors/document.title-05.html

Project Member Reported by xing...@intel.com, Nov 3 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e27088bd97ee3aecb9d04c56743c629a43b7f621

commit e27088bd97ee3aecb9d04c56743c629a43b7f621
Author: xing.xu <xing.xu@intel.com>
Date: Tue Nov 08 03:44:06 2016

Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION

This fix is to align document title with FF(IE fails) and spec.

From the spec, "it must replace any sequence of one or more consecutive
space characters in that string with a single U+0020 SPACE character".
Here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION
(tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE
RETURN (CR)".
U+2028 LINE SEPARATOR/ U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION
are not listed and should be supported in title.

Note, for case fast/dom/Document/document-title-get.html there still exists
inconsistency among IE/FF(Win)/FF(Ubuntu).
IE:         FAIL document.title should be one\u000b\u000c
space. Was one space.
FF(Win):    FAIL document.title should be one\u000b\u000c
space. Was one\u000b space.
FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace.

Spec:
https://html.spec.whatwg.org/multipage/dom.html#document.title
https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse-whitespace
https://html.spec.whatwg.org/multipage/infrastructure.html#space-character

BUG= 661859 
TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html

Review-Url: https://codereview.chromium.org/2469983007
Cr-Commit-Position: refs/heads/master@{#430508}

[modify] https://crrev.com/e27088bd97ee3aecb9d04c56743c629a43b7f621/third_party/WebKit/LayoutTests/fast/dom/Document/document-title-get-expected.txt
[modify] https://crrev.com/e27088bd97ee3aecb9d04c56743c629a43b7f621/third_party/WebKit/LayoutTests/fast/dom/Document/script-tests/document-title-get.js
[delete] https://crrev.com/7809a5bc36d4730e9e41b4e4ca00b0b482fb5081/third_party/WebKit/LayoutTests/imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05-expected.txt
[modify] https://crrev.com/e27088bd97ee3aecb9d04c56743c629a43b7f621/third_party/WebKit/Source/core/dom/Document.cpp

Comment 2 by xing...@intel.com, Nov 8 2016

Status: Fixed (was: Untriaged)

Sign in to add a comment