New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 661848 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Pass identity provider in constructor of blimp client context.

Project Member Reported by xingliu@chromium.org, Nov 3 2016

Issue description

Identity source requires IdentityProvider in the constructor, currently IdentityProvider is created through BlimpClientContextDelegate.

Change it to pass the IdentityProvider in the constructor of BlimpClientContext. So we can avoid late initialization issue for both IdentitySource and its wrapper.

To make this change, also need to ensure the services are created in a correct sequence. (blimp, OAuth2 token service and sign in manager).
 
Build it in BlimpClientContextFactory::BuildServiceInstanceFor.
It might be helpful to figure out directly passing the delegate in the ctor of the context.
Status: WontFix (was: Untriaged)

Sign in to add a comment