New issue
Advanced search Search tips

Issue 661839 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Add offline previews navigations to the previews blacklist

Project Member Reported by ryansturm@chromium.org, Nov 3 2016

Issue description

Navigations using offline previews should report whether the user opted out of the preview or not to the PreviewsBlackList. This can be determined through the way the infobar is dismissed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/603474151d2ea47cbf53a54b87bf13786aa90cef

commit 603474151d2ea47cbf53a54b87bf13786aa90cef
Author: ryansturm <ryansturm@chromium.org>
Date: Wed Nov 09 22:52:42 2016

Adding offline navigations to the previews blacklist

This change adds previews navigation to the blacklist when the user
reloads original (passing true) or the infobar is dismissed by other
means (passing false) for offline previews. Lo-fi and weblite still use the existing mechanism for opt-outs, and will be transitioned to the shared black list later.

This changes the offline page tab helper fragment check to an IsSamePage check, so reloads that do not use the offline page do not have incorrect info in offline_info_.

BUG= 661839 

Review-Url: https://codereview.chromium.org/2472863002
Cr-Commit-Position: refs/heads/master@{#431066}

[modify] https://crrev.com/603474151d2ea47cbf53a54b87bf13786aa90cef/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
[modify] https://crrev.com/603474151d2ea47cbf53a54b87bf13786aa90cef/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
[modify] https://crrev.com/603474151d2ea47cbf53a54b87bf13786aa90cef/chrome/browser/previews/previews_infobar_delegate.cc
[modify] https://crrev.com/603474151d2ea47cbf53a54b87bf13786aa90cef/chrome/browser/previews/previews_infobar_delegate.h
[modify] https://crrev.com/603474151d2ea47cbf53a54b87bf13786aa90cef/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/603474151d2ea47cbf53a54b87bf13786aa90cef/chrome/browser/previews/previews_infobar_tab_helper.cc
[add] https://crrev.com/603474151d2ea47cbf53a54b87bf13786aa90cef/chrome/browser/previews/previews_service_browser_test.cc
[modify] https://crrev.com/603474151d2ea47cbf53a54b87bf13786aa90cef/chrome/test/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment