New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 661837 link

Starred by 1 user
Status: Fixed
Owner:
█ maxbogue@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[USS] Move ModelTypeStore write methods to WriteBatch

Project Member Reported by maxbogue@chromium.org, Nov 3 2016 
This way you don't need to awkwardly do store->(batch.get(), ...).

To make mocking for testing easier, we should leave the existing store write methods as protected on the store.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf7d159e836ddddfbfc290bd304cdedec80e61d2

commit bf7d159e836ddddfbfc290bd304cdedec80e61d2
Author: maxbogue <maxbogue@chromium.org>
Date: Wed Nov 09 01:20:46 2016

[Sync] Make all ModelTypeStore write methods go through WriteBatch.

This makes it semantically clearer that the changes are contained in the
WriteBatch, and hides all the write functions pertaining to metadata
from ModelTypeStore consumers.

BUG= 661837 

Review-Url: https://codereview.chromium.org/2489683002
Cr-Commit-Position: refs/heads/master@{#430805}

[modify] https://crrev.com/bf7d159e836ddddfbfc290bd304cdedec80e61d2/components/sync/device_info/device_info_sync_bridge.cc
[modify] https://crrev.com/bf7d159e836ddddfbfc290bd304cdedec80e61d2/components/sync/device_info/device_info_sync_bridge_unittest.cc
[modify] https://crrev.com/bf7d159e836ddddfbfc290bd304cdedec80e61d2/components/sync/model/mock_model_type_store.h
[modify] https://crrev.com/bf7d159e836ddddfbfc290bd304cdedec80e61d2/components/sync/model/model_type_store.cc
[modify] https://crrev.com/bf7d159e836ddddfbfc290bd304cdedec80e61d2/components/sync/model/model_type_store.h
[modify] https://crrev.com/bf7d159e836ddddfbfc290bd304cdedec80e61d2/components/sync/model_impl/model_type_store_impl.h
[modify] https://crrev.com/bf7d159e836ddddfbfc290bd304cdedec80e61d2/components/sync/model_impl/model_type_store_impl_unittest.cc

Comment 2 by maxbogue@chromium.org, Nov 9 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment