MD Settings: Handle case when going back to a subpage after a search |
||
Issue descriptionSearch URLs have landed in MD settings. There is still a case that is not handled well, described below. 1) Navigate to a subpage, like chrome://md-settings/searchEngines 2) Trigger a search via the textbox (for example "cookies"). 3) Click the "back" browser button (nothing happens). The bug is happening because in the code there is currently no way to differentiate between the following two distinct cases. a) Navigating from a highlighted top-level page to a highlighted subpageb (highlights should be preserved). b) Navigating from a highlighted top-level page back to a previously shown (highlighted or not) subpage. The code currently treats both a and b as a (which is a much more frequent case).
,
Nov 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6da08c5ddf401d99c58878e00726875ce72691ec commit 6da08c5ddf401d99c58878e00726875ce72691ec Author: dpapad <dpapad@chromium.org> Date: Thu Nov 10 02:53:48 2016 MD Settings: Preserve search URL param in subpages. BUG= 661835 , 663708 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2469393004 Cr-Commit-Position: refs/heads/master@{#431152} [modify] https://crrev.com/6da08c5ddf401d99c58878e00726875ce72691ec/chrome/browser/resources/settings/route.js [modify] https://crrev.com/6da08c5ddf401d99c58878e00726875ce72691ec/chrome/browser/resources/settings/settings_menu/settings_menu.html [modify] https://crrev.com/6da08c5ddf401d99c58878e00726875ce72691ec/chrome/browser/resources/settings/settings_menu/settings_menu.js [modify] https://crrev.com/6da08c5ddf401d99c58878e00726875ce72691ec/chrome/browser/resources/settings/settings_ui/settings_ui.js [modify] https://crrev.com/6da08c5ddf401d99c58878e00726875ce72691ec/chrome/test/data/webui/settings/route_tests.js [modify] https://crrev.com/6da08c5ddf401d99c58878e00726875ce72691ec/chrome/test/data/webui/settings/settings_menu_test.js [modify] https://crrev.com/6da08c5ddf401d99c58878e00726875ce72691ec/chrome/test/data/webui/settings/settings_ui_browsertest.js
,
Nov 10 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by dpa...@chromium.org
, Nov 4 2016Status: Started (was: Assigned)