Issue metadata
Sign in to add a comment
|
PlzNavigate: make all extensions_browsertests pass |
||||||||||||||||||||||
Issue descriptionFrom https://codereview.chromium.org/2474733003 currently failing are: AppViewTests_AppViewTest.TestAppViewMediaRequest_0 cache [logdog] AppViewTests_AppViewTest.TestAppViewMediaRequest_1 cache [logdog] WebViewAPITest.TestDeclarativeWebRequestAPI cache [logdog] WebViewAPITest.TestDeclarativeWebRequestAPISendMessage cache [logdog] WebViewAPITest.TestInlineScriptFromAccessibleResources cache [logdog] WebViewAPITest.TestLoadAbortChromeExtensionURLWrongPartition cache [logdog] WebViewAPITest.TestWebRequestAPI cache [logdog] WebViewAPITest.TestWebRequestAPIGoogleProperty cache [logdog] WebViewAPITest.TestWebRequestAPIWithHeaders cache [logdog]
,
Nov 4 2016
Per discussion, I'll look at these since they're similar to ones I already fixed.
,
Nov 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/039ca692b53631e5dd193bc40784baab3d6f9870 commit 039ca692b53631e5dd193bc40784baab3d6f9870 Author: jam <jam@chromium.org> Date: Fri Nov 04 17:36:16 2016 Add WebView PlzNavigate related fixes to extensions_browsertests harness. This fixes AppViewTests_AppViewTest.TestAppViewMediaRequest_0 AppViewTests_AppViewTest.TestAppViewMediaRequest_1 WebViewAPITest.TestDeclarativeWebRequestAPI WebViewAPITest.TestDeclarativeWebRequestAPISendMessage WebViewAPITest.TestInlineScriptFromAccessibleResources WebViewAPITest.TestLoadAbortChromeExtensionURLWrongPartition WebViewAPITest.TestWebRequestAPI WebViewAPITest.TestWebRequestAPIGoogleProperty WebViewAPITest.TestWebRequestAPIWithHeaders with PlzNavigate. BUG= 661812 Review-Url: https://codereview.chromium.org/2465253010 Cr-Commit-Position: refs/heads/master@{#429936} [modify] https://crrev.com/039ca692b53631e5dd193bc40784baab3d6f9870/extensions/shell/BUILD.gn [modify] https://crrev.com/039ca692b53631e5dd193bc40784baab3d6f9870/extensions/shell/browser/shell_content_browser_client.cc [modify] https://crrev.com/039ca692b53631e5dd193bc40784baab3d6f9870/extensions/shell/browser/shell_content_browser_client.h [modify] https://crrev.com/039ca692b53631e5dd193bc40784baab3d6f9870/extensions/shell/browser/shell_extensions_browser_client.cc [modify] https://crrev.com/039ca692b53631e5dd193bc40784baab3d6f9870/extensions/shell/browser/shell_extensions_browser_client.h [add] https://crrev.com/039ca692b53631e5dd193bc40784baab3d6f9870/extensions/shell/browser/shell_navigation_ui_data.cc [add] https://crrev.com/039ca692b53631e5dd193bc40784baab3d6f9870/extensions/shell/browser/shell_navigation_ui_data.h
,
Nov 4 2016
,
Nov 4 2016
Looks like WebViewAPITest.TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged crashed when trying to add extensions_browsertests to linux bot as plznav. Maybe flaky?
,
Nov 4 2016
you mean WebViewAPITest.TestNewWindow right? Yeah I was investigating that one.
,
Nov 4 2016
Oh, looks like WebViewAPITest.TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged flaked, but maybe it does that in non-PlzNav too. But yeah, WebViewAPITest.TestNewWindow seems like the reliable failure. [1104/122541:ERROR:kill_posix.cc(84)] Unable to terminate process group 5068: No such process [ RUN ] WebViewAPITest.TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged [5068:5068:1104/122541:14573892268:WARNING:audio_manager.cc(317)] Multiple instances of AudioManager detected [5068:5068:1104/122541:14573892329:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected Xlib: extension "RANDR" missing on display ":9". [5068:5068:1104/122541:14574283368:INFO:CONSOLE(721)] "1. Performing initial navigation.", source: chrome-extension://hbcpimgbfajkdbjnmiocfibjejelglmk/main.js (721) [5068:5068:1104/122541:14574373783:INFO:CONSOLE(693)] "2. Inject script to trigger a guest-initiated navigation.", source: chrome-extension://hbcpimgbfajkdbjnmiocfibjejelglmk/main.js (693) [5068:5068:1104/122541:14574379887:INFO:CONSOLE(700)] "3. Listening for the load that will be started as a result of 2.", source: chrome-extension://hbcpimgbfajkdbjnmiocfibjejelglmk/main.js (700) [5068:5068:1104/122541:14574401848:INFO:CONSOLE(704)] "4. Attempting to inject script into about:blank. This is expected to fail.", source: chrome-extension://hbcpimgbfajkdbjnmiocfibjejelglmk/main.js (704) [5068:5068:1104/122541:14574413005:INFO:CONSOLE(709)] "5. Verify that executeScript has, indeed, failed.", source: chrome-extension://hbcpimgbfajkdbjnmiocfibjejelglmk/main.js (709) [5068:5068:1104/122541:14574414354:INFO:CONSOLE(39)] "assertion failed: null != red", source: chrome-extension://hbcpimgbfajkdbjnmiocfibjejelglmk/main.js (39) ../../extensions/browser/guest_view/web_view/web_view_apitest.cc:177: Failure Value of: done_listener.WaitUntilSatisfied() Actual: false Expected: true [ FAILED ] WebViewAPITest.TestExecuteScriptIsAbortedWhenWebViewSourceIsChanged, where TypeParam = and GetParam() = (598 ms)
,
Nov 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2a5e683bf6562bd0eb86c2c8281a025a1aee5f0 commit d2a5e683bf6562bd0eb86c2c8281a025a1aee5f0 Author: jam <jam@chromium.org> Date: Sat Nov 05 00:15:51 2016 Ensure ShellExtensionSystem::Init() is called in all extensions_browsertests. This manifested in hangs in a test with PlzNavigate after r429936 now that NavigationUIData was being set. This correctly led to the WebRequest API code (ExtensionWebRequestEventRouter::ProcessDeclarativeRules) classifying a request as a webview one, and waiting for rules_registry->ready() to signal. That's signalled through ShellExtensionSystem::Init. This fixes WebViewAPITest.TestNewWindow with PlzNavigate. BUG= 661812 Review-Url: https://codereview.chromium.org/2482583002 Cr-Commit-Position: refs/heads/master@{#430075} [modify] https://crrev.com/d2a5e683bf6562bd0eb86c2c8281a025a1aee5f0/extensions/browser/guest_view/app_view/app_view_apitest.cc [modify] https://crrev.com/d2a5e683bf6562bd0eb86c2c8281a025a1aee5f0/extensions/shell/test/shell_test.cc
,
Nov 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/034fee44d74a88c2ac59235874bc4632f5d464bd commit 034fee44d74a88c2ac59235874bc4632f5d464bd Author: scottmg <scottmg@chromium.org> Date: Sat Nov 05 00:58:21 2016 Add extensions_browsertests --enable-browser-side-navigation to linux runs R=jam@chromium.org BUG= 661812 Review-Url: https://codereview.chromium.org/2474733003 Cr-Commit-Position: refs/heads/master@{#430106} [modify] https://crrev.com/034fee44d74a88c2ac59235874bc4632f5d464bd/testing/buildbot/chromium.linux.json
,
Dec 5 2016
,
Nov 7 2017
,
Nov 7 2017
Apologies, applied the wrong component in bulk. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by scottmg@chromium.org
, Nov 2 2016Status: Assigned (was: Unconfirmed)