New issue
Advanced search Search tips

Issue 661811 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 368813



Sign in to add a comment

PlzNavigate: make all interactive_ui_tests pass

Project Member Reported by scottmg@chromium.org, Nov 2 2016

Issue description

Currently failing, per https://codereview.chromium.org/2469093004:

WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_0 cache [logdog]
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_1 cache [logdog]
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_0 cache [logdog]
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_1 cache [logdog]
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_0 cache [logdog]
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_1 cache [logdog]
 

Comment 1 by jam@chromium.org, Nov 4 2016

Blocking: 368813
Owner: jam@chromium.org
Status: Started (was: Assigned)
Per discussion, I'll look at these since they're similar to ones I already fixed.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/baaab3a22a5bf6d98be978a962361787d86aabdc

commit baaab3a22a5bf6d98be978a962361787d86aabdc
Author: jam <jam@chromium.org>
Date: Sat Nov 05 00:46:18 2016

Fix navigation requests starting too early and not getting associated with the <webview>.

The problem is for PlzNavigate, the ExtensionNavigationUIData is created when the NavigationHandle is created. We have to ensure it's not created before the relevant guestview structures are set up, which happens later for renderer created windows. So we have to wait until the RFH is ready (i.e. when it unblocks request through ResourceDispatcherHost) to create the NavigationHandle.

This fixes
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_1
with PlzNavigate.

BUG= 661811 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2472253002
Cr-Commit-Position: refs/heads/master@{#430099}

[modify] https://crrev.com/baaab3a22a5bf6d98be978a962361787d86aabdc/components/guest_view/browser/guest_view_message_filter.cc
[modify] https://crrev.com/baaab3a22a5bf6d98be978a962361787d86aabdc/content/browser/frame_host/frame_tree_node.cc
[modify] https://crrev.com/baaab3a22a5bf6d98be978a962361787d86aabdc/content/browser/frame_host/interstitial_page_impl.cc
[modify] https://crrev.com/baaab3a22a5bf6d98be978a962361787d86aabdc/content/browser/frame_host/render_frame_host_factory.cc
[modify] https://crrev.com/baaab3a22a5bf6d98be978a962361787d86aabdc/content/browser/frame_host/render_frame_host_factory.h
[modify] https://crrev.com/baaab3a22a5bf6d98be978a962361787d86aabdc/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/baaab3a22a5bf6d98be978a962361787d86aabdc/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/baaab3a22a5bf6d98be978a962361787d86aabdc/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/baaab3a22a5bf6d98be978a962361787d86aabdc/content/browser/frame_host/render_frame_host_manager.h
[modify] https://crrev.com/baaab3a22a5bf6d98be978a962361787d86aabdc/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/baaab3a22a5bf6d98be978a962361787d86aabdc/content/test/test_render_frame_host.cc
[modify] https://crrev.com/baaab3a22a5bf6d98be978a962361787d86aabdc/content/test/test_render_frame_host_factory.cc
[modify] https://crrev.com/baaab3a22a5bf6d98be978a962361787d86aabdc/content/test/test_render_frame_host_factory.h

Comment 3 by jam@chromium.org, Dec 5 2016

Status: Fixed (was: Started)

Comment 4 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 5 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Sign in to add a comment