IMO good to do, but not critical (won't happen often and only for a feature that someone has flagged-on.)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58b2585e2e7c567bcb23f919c8a4f2afafc18301

commit 58b2585e2e7c567bcb23f919c8a4f2afafc18301
Author: pkotwicz <pkotwicz@chromium.org>
Date: Thu Nov 10 23:14:53 2016

Disable WebAPK updates when "installation from unknown sources" is disabled

When a WebAPK tries to update itself and the user has "installation from
unknown sources" disabled, the Android system displays a prompt requesting that
the user enable "installation from unknown sources". The Android system prompt
does not indicate that it is for an "update" instead of for an "install". This
makes showing the prompt confusing in the update scenario.

Do not request updates if the user disabled "installation from unknown sources".

BUG= 661800 

Review-Url: https://codereview.chromium.org/2496443002
Cr-Commit-Position: refs/heads/master@{#431392}

[modify] https://crrev.com/58b2585e2e7c567bcb23f919c8a4f2afafc18301/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkUpdateManager.java
[modify] https://crrev.com/58b2585e2e7c567bcb23f919c8a4f2afafc18301/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerTest.java

Test steps for test team:
1) Enable testing WebAPK updates by following instructions in https://docs.google.com/a/google.com/document/d/1gHZ1YXO7QRZO6hgt11uqItNpl5WrZBJYxPYAnuJphXU/edit?usp=sharing
2) Navigate to https://webapk-test.appspot.com/generated.html?name=Update%20Test%20-%20Not%20Updated&short_name=Update%20Test%20-%20Not%20Updated&scope=%2F&display=standalone&orientation=&start_url=&theme_color=purple&background_color=teal&icons=icon_hexagon_256&icon_sizes=true&update=true&update_name=Update%20Test%20-%20Updated&update_short_name=Update%20Test%20-%20Updated&update_scope=%2F&update_display=standalone&update_orientation=&update_start_url=&update_theme_color=purple&update_background_color=teal&update_icons=icon_hexagon_256&update_icon_sizes=true&seed=443
3) Install WebAPK by selecting "Add to Home screen" from app menu
4) In Android Settings > Security, disable "Installation from Unknown Sources"
5) Launch WebAPK
6) Tap the "Update" button on the Web page
7) Relaunch the WebAPK
8) Wait 5 minutes. Check that Android does not show an alert dialog similar to the one in the attached screenshot

Deleted: Screenshot_20161106-143637.png 74.7 KB

	Screenshot_20161106-143637.png 74.7 KB View Download