Three places for the main UI code (general, Views, Mac), as well as iOS and Android [1]. [1] https://crrev.com/2366103002
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58888263da6438b3aa9a68fdec7144c37ca8e73b commit 58888263da6438b3aa9a68fdec7144c37ca8e73b Author: lgarron <lgarron@chromium.org> Date: Tue Mar 14 07:45:56 2017 Move cross-platform Page Info UI code to its own folder. Includes the following changes: - Forks OWNERS file. - Updates the COMPONENT in both OWNERS files: - website_settings: UI>Browser>Permissions>Prompts - page_info: UI>Browser>Bubbles>PageInfo - Automatically updates filenames across the project using `tools/git/mass-rename.py` Followup work that is NOT part of this change: - Add lgarron@ as an owner ( crbug.com/661797 ) - Move permission prompt UI code into a permission_bubble folder ( crbug.com/700581 ) - Rename classes and corresponding leaf file names ( crbug.com/571506 ) - Functional cleanup changes ( crbug.com/571533 ) BUG= 661796 TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2744823004 Cr-Commit-Position: refs/heads/master@{#456647} [modify] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/BUILD.gn [modify] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/android/page_info/connection_info_popup_android.cc [modify] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/android/page_info/connection_info_popup_android.h [modify] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/android/page_info/website_settings_popup_android.cc [modify] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/android/page_info/website_settings_popup_android.h [modify] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm [modify] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/cocoa/website_settings/permission_selector_button.h [modify] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/cocoa/website_settings/permission_selector_button.mm [modify] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/cocoa/website_settings/permission_selector_button_unittest.mm [modify] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h [modify] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm [add] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/page_info/OWNERS [rename] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/page_info/permission_menu_model.cc [rename] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/page_info/permission_menu_model.h [rename] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/page_info/permission_menu_model_unittest.cc [rename] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/page_info/website_settings.cc [rename] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/page_info/website_settings.h [rename] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/page_info/website_settings_infobar_delegate.cc [rename] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/page_info/website_settings_infobar_delegate.h [rename] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/page_info/website_settings_ui.cc [rename] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/page_info/website_settings_ui.h [rename] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/page_info/website_settings_unittest.cc [modify] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/views/website_settings/chosen_object_row.h [modify] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/views/website_settings/chosen_object_row_observer.h [modify] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/views/website_settings/permission_selector_row.cc [modify] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/views/website_settings/permission_selector_row.h [modify] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/views/website_settings/permission_selector_row_observer.h [modify] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc [modify] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/views/website_settings/website_settings_popup_view.h [modify] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/browser/ui/website_settings/OWNERS [modify] https://crrev.com/58888263da6438b3aa9a68fdec7144c37ca8e73b/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50ba5edf101710e6ad6f2b03d5f7d3f71d83ddaf commit 50ba5edf101710e6ad6f2b03d5f7d3f71d83ddaf Author: lgarron <lgarron@chromium.org> Date: Tue Mar 14 22:57:29 2017 Move Cocoa Page Info UI code to its own folder. Includes the following changes: - Forks OWNERS file. - Updates the COMPONENT in both OWNERS files: - website_settings: UI>Browser>Permissions>Prompts - page_info: UI>Browser>Bubbles>PageInfo - Automatically updates filenames across the project using `tools/git/mass-rename.py` Followup work that is NOT part of this change: - Add lgarron@ as an owner ( crbug.com/661797 ) - Move permission prompt UI code into a permission_bubble folder ( crbug.com/700581 ) - Rename classes and corresponding leaf file names ( crbug.com/571506 ) - Functional cleanup changes ( crbug.com/571533 ) BUG= 661796 Review-Url: https://codereview.chromium.org/2741933003 Cr-Commit-Position: refs/heads/master@{#456877} [modify] https://crrev.com/50ba5edf101710e6ad6f2b03d5f7d3f71d83ddaf/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/50ba5edf101710e6ad6f2b03d5f7d3f71d83ddaf/chrome/browser/ui/cocoa/browser_window_cocoa.mm [add] https://crrev.com/50ba5edf101710e6ad6f2b03d5f7d3f71d83ddaf/chrome/browser/ui/cocoa/page_info/OWNERS [rename] https://crrev.com/50ba5edf101710e6ad6f2b03d5f7d3f71d83ddaf/chrome/browser/ui/cocoa/page_info/permission_selector_button.h [rename] https://crrev.com/50ba5edf101710e6ad6f2b03d5f7d3f71d83ddaf/chrome/browser/ui/cocoa/page_info/permission_selector_button.mm [rename] https://crrev.com/50ba5edf101710e6ad6f2b03d5f7d3f71d83ddaf/chrome/browser/ui/cocoa/page_info/permission_selector_button_unittest.mm [rename] https://crrev.com/50ba5edf101710e6ad6f2b03d5f7d3f71d83ddaf/chrome/browser/ui/cocoa/page_info/split_block_button.h [rename] https://crrev.com/50ba5edf101710e6ad6f2b03d5f7d3f71d83ddaf/chrome/browser/ui/cocoa/page_info/split_block_button.mm [rename] https://crrev.com/50ba5edf101710e6ad6f2b03d5f7d3f71d83ddaf/chrome/browser/ui/cocoa/page_info/website_settings_bubble_controller.h [rename] https://crrev.com/50ba5edf101710e6ad6f2b03d5f7d3f71d83ddaf/chrome/browser/ui/cocoa/page_info/website_settings_bubble_controller.mm [rename] https://crrev.com/50ba5edf101710e6ad6f2b03d5f7d3f71d83ddaf/chrome/browser/ui/cocoa/page_info/website_settings_bubble_controller_unittest.mm [add] https://crrev.com/50ba5edf101710e6ad6f2b03d5f7d3f71d83ddaf/chrome/browser/ui/cocoa/page_info/website_settings_utils_cocoa.h [rename] https://crrev.com/50ba5edf101710e6ad6f2b03d5f7d3f71d83ddaf/chrome/browser/ui/cocoa/page_info/website_settings_utils_cocoa.mm [modify] https://crrev.com/50ba5edf101710e6ad6f2b03d5f7d3f71d83ddaf/chrome/browser/ui/cocoa/website_settings/OWNERS [modify] https://crrev.com/50ba5edf101710e6ad6f2b03d5f7d3f71d83ddaf/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm [modify] https://crrev.com/50ba5edf101710e6ad6f2b03d5f7d3f71d83ddaf/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller_unittest.mm [delete] https://crrev.com/f50d8d33c5da873242189cf73176d78a48549762/chrome/browser/ui/cocoa/website_settings/website_settings_utils_cocoa.h [modify] https://crrev.com/50ba5edf101710e6ad6f2b03d5f7d3f71d83ddaf/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/040aad2ebc166c48c8c5bee6582d1d0ad226c7fe commit 040aad2ebc166c48c8c5bee6582d1d0ad226c7fe Author: lgarron <lgarron@chromium.org> Date: Wed Mar 15 03:07:19 2017 Move Views Page Info UI code to its own folder. Includes the following changes: - Forks OWNERS file. - Updates the COMPONENT in both OWNERS files: - website_settings: UI>Browser>Permissions>Prompts - page_info: UI>Browser>Bubbles>PageInfo - Automatically updates filenames across the project using `tools/git/mass-rename.py` Followup work that is NOT part of this change: - Add lgarron@ as an owner ( crbug.com/661797 ) - Move permission prompt UI code into a permission_bubble folder ( crbug.com/700581 ) - Rename classes and corresponding leaf file names ( crbug.com/571506 ) - Functional cleanup changes ( crbug.com/571533 ) BUG= 661796 TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2744933002 Cr-Commit-Position: refs/heads/master@{#456974} [modify] https://crrev.com/040aad2ebc166c48c8c5bee6582d1d0ad226c7fe/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/040aad2ebc166c48c8c5bee6582d1d0ad226c7fe/chrome/browser/ui/views/browser_dialogs_views_mac.cc [modify] https://crrev.com/040aad2ebc166c48c8c5bee6582d1d0ad226c7fe/chrome/browser/ui/views/frame/browser_view.cc [modify] https://crrev.com/040aad2ebc166c48c8c5bee6582d1d0ad226c7fe/chrome/browser/ui/views/location_bar/location_icon_view.cc [modify] https://crrev.com/040aad2ebc166c48c8c5bee6582d1d0ad226c7fe/chrome/browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc [add] https://crrev.com/040aad2ebc166c48c8c5bee6582d1d0ad226c7fe/chrome/browser/ui/views/page_info/OWNERS [rename] https://crrev.com/040aad2ebc166c48c8c5bee6582d1d0ad226c7fe/chrome/browser/ui/views/page_info/chosen_object_row.cc [rename] https://crrev.com/040aad2ebc166c48c8c5bee6582d1d0ad226c7fe/chrome/browser/ui/views/page_info/chosen_object_row.h [rename] https://crrev.com/040aad2ebc166c48c8c5bee6582d1d0ad226c7fe/chrome/browser/ui/views/page_info/chosen_object_row_observer.h [rename] https://crrev.com/040aad2ebc166c48c8c5bee6582d1d0ad226c7fe/chrome/browser/ui/views/page_info/non_accessible_image_view.cc [rename] https://crrev.com/040aad2ebc166c48c8c5bee6582d1d0ad226c7fe/chrome/browser/ui/views/page_info/non_accessible_image_view.h [rename] https://crrev.com/040aad2ebc166c48c8c5bee6582d1d0ad226c7fe/chrome/browser/ui/views/page_info/permission_selector_row.cc [rename] https://crrev.com/040aad2ebc166c48c8c5bee6582d1d0ad226c7fe/chrome/browser/ui/views/page_info/permission_selector_row.h [rename] https://crrev.com/040aad2ebc166c48c8c5bee6582d1d0ad226c7fe/chrome/browser/ui/views/page_info/permission_selector_row_observer.h [rename] https://crrev.com/040aad2ebc166c48c8c5bee6582d1d0ad226c7fe/chrome/browser/ui/views/page_info/website_settings_popup_view.cc [rename] https://crrev.com/040aad2ebc166c48c8c5bee6582d1d0ad226c7fe/chrome/browser/ui/views/page_info/website_settings_popup_view.h [rename] https://crrev.com/040aad2ebc166c48c8c5bee6582d1d0ad226c7fe/chrome/browser/ui/views/page_info/website_settings_popup_view_interactive_uitest.cc [rename] https://crrev.com/040aad2ebc166c48c8c5bee6582d1d0ad226c7fe/chrome/browser/ui/views/page_info/website_settings_popup_view_unittest.cc [modify] https://crrev.com/040aad2ebc166c48c8c5bee6582d1d0ad226c7fe/chrome/browser/ui/views/website_settings/OWNERS [modify] https://crrev.com/040aad2ebc166c48c8c5bee6582d1d0ad226c7fe/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc [modify] https://crrev.com/040aad2ebc166c48c8c5bee6582d1d0ad226c7fe/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e25c740eaab6422e20ff84f4dc9990c6405a866 commit 9e25c740eaab6422e20ff84f4dc9990c6405a866 Author: lgarron <lgarron@chromium.org> Date: Wed Mar 15 04:03:11 2017 Make lgarron@ an owner of (desktop) Page Info UI code and create a page_info watchlist. BUG= 661797 , 661796 , 661799 Review-Url: https://codereview.chromium.org/2746663002 Cr-Commit-Position: refs/heads/master@{#456986} [modify] https://crrev.com/9e25c740eaab6422e20ff84f4dc9990c6405a866/WATCHLISTS [modify] https://crrev.com/9e25c740eaab6422e20ff84f4dc9990c6405a866/chrome/browser/ui/cocoa/page_info/OWNERS [modify] https://crrev.com/9e25c740eaab6422e20ff84f4dc9990c6405a866/chrome/browser/ui/page_info/OWNERS [modify] https://crrev.com/9e25c740eaab6422e20ff84f4dc9990c6405a866/chrome/browser/ui/views/page_info/OWNERS
🎉🎉🎉🎆🎇🎆 Now the real work begins.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3428b2d3e81169a97f933c7631b8194baf43d66b commit 3428b2d3e81169a97f933c7631b8194baf43d66b Author: lgarron <lgarron@chromium.org> Date: Tue Mar 21 18:35:19 2017 Rename Android Java pageinfo folder to page_info (matching other platforms). Also includes `git cl format`, per the presubmit. BUG= 571533 , 661796 Review-Url: https://codereview.chromium.org/2765733002 Cr-Commit-Position: refs/heads/master@{#458484} [modify] https://crrev.com/3428b2d3e81169a97f933c7631b8194baf43d66b/WATCHLISTS [modify] https://crrev.com/3428b2d3e81169a97f933c7631b8194baf43d66b/chrome/android/java/res/layout/website_settings.xml [modify] https://crrev.com/3428b2d3e81169a97f933c7631b8194baf43d66b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/3428b2d3e81169a97f933c7631b8194baf43d66b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java [modify] https://crrev.com/3428b2d3e81169a97f933c7631b8194baf43d66b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [rename] https://crrev.com/3428b2d3e81169a97f933c7631b8194baf43d66b/chrome/android/java/src/org/chromium/chrome/browser/page_info/CertificateChainHelper.java [rename] https://crrev.com/3428b2d3e81169a97f933c7631b8194baf43d66b/chrome/android/java/src/org/chromium/chrome/browser/page_info/CertificateViewer.java [rename] https://crrev.com/3428b2d3e81169a97f933c7631b8194baf43d66b/chrome/android/java/src/org/chromium/chrome/browser/page_info/ConnectionInfoPopup.java [rename] https://crrev.com/3428b2d3e81169a97f933c7631b8194baf43d66b/chrome/android/java/src/org/chromium/chrome/browser/page_info/WebsiteSettingsPopup.java [modify] https://crrev.com/3428b2d3e81169a97f933c7631b8194baf43d66b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/3428b2d3e81169a97f933c7631b8194baf43d66b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java [modify] https://crrev.com/3428b2d3e81169a97f933c7631b8194baf43d66b/chrome/android/java_sources.gni [modify] https://crrev.com/3428b2d3e81169a97f933c7631b8194baf43d66b/chrome/browser/BUILD.gn [modify] https://crrev.com/3428b2d3e81169a97f933c7631b8194baf43d66b/chrome/browser/ui/page_info/website_settings.h
Comment 1 by lgar...@chromium.org
, Nov 2 2016