Rolling crashpad complains about missing IPC review/OWNERS file for thread_log_messages.cc |
||
Issue descriptiongit cl upload complains: """ Found changes to IPC files without a security OWNER! *************** third_party\crashpad\crashpad\util\thread\OWNERS is missing the following lines: per-file *_messages.cc=set noparent per-file *_messages.cc=file://ipc/SECURITY_OWNERS for changed files: third_party\crashpad\crashpad\util\thread\thread_log_messages.cc *************** """ I think it's just a dumb presubmit that looks for "_messages", but doesn't exclude third_party. We could: - fix the check - rename that file - do nothing, as IPC will go away eventually when it's replaced by mojo
,
Nov 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a6ed5baee360f6521c8311a4dc5b1edba849679 commit 7a6ed5baee360f6521c8311a4dc5b1edba849679 Author: scottmg <scottmg@chromium.org> Date: Fri Nov 04 18:22:04 2016 Exclude third_party/crashpad from IPC presubmit Can't otherwise land https://codereview.chromium.org/2478633002/. R=dcheng@chromium.org, dpranke@chromium.org BUG= 661788 Review-Url: https://codereview.chromium.org/2477973002 Cr-Commit-Position: refs/heads/master@{#429954} [modify] https://crrev.com/7a6ed5baee360f6521c8311a4dc5b1edba849679/PRESUBMIT.py
,
Nov 4 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by scottmg@chromium.org
, Nov 2 2016