New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 661777 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Retesting the reference range is broken.

Project Member Reported by robert...@chromium.org, Nov 2 2016

Issue description

https://build.chromium.org/p/tryserver.chromium.perf/builders/staging_mac_10_10_perf_bisect/builds/24

In the bisect above, the reference range did not produce any values, yet the bisection continued, testing revisions willy-nilly without producing values.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/d7af4f01660860d2e2faf7662b8084caef6eb440

commit d7af4f01660860d2e2faf7662b8084caef6eb440
Author: robertocn <robertocn@chromium.org>
Date: Wed Nov 02 22:51:58 2016

Retesting reference range based on the same criteria as other revisions.

I am removing the timeout approach to be consistent with how other
revisions are re-tested. Basically delegating the logic to
compare_samples, but having a maximum number of tests to be run to avoid
the infinite loop.

Also, I am cleaning up the structure of nested steps.

R=dtu@chromium.org
BUG= 661777 

Review-Url: https://codereview.chromium.org/2471323002

[modify] https://crrev.com/d7af4f01660860d2e2faf7662b8084caef6eb440/scripts/slave/recipe_modules/auto_bisect_staging/bisector.py
[modify] https://crrev.com/d7af4f01660860d2e2faf7662b8084caef6eb440/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/retest_bisect.json
[modify] https://crrev.com/d7af4f01660860d2e2faf7662b8084caef6eb440/scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_basic_device.json
[modify] https://crrev.com/d7af4f01660860d2e2faf7662b8084caef6eb440/scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_disconnected_device.json
[modify] https://crrev.com/d7af4f01660860d2e2faf7662b8084caef6eb440/scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_failed_device.json

Cc: robert...@chromium.org
 Issue 659407  has been merged into this issue.
 Issue 660439  has been merged into this issue.
Status: Fixed (was: Started)
Components: Speed>Bisection

Sign in to add a comment