New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 661769 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

fast/images/png-suite/test.html is flaky

Project Member Reported by rouslan@chromium.org, Nov 2 2016

Issue description

fast/images/png-suite/test.html has started to fail intermittently after some PNG code changes and a rebaseline.

Bot:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29
 
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/373093497c9ebca029a707a8d9fee5e57e3d2af6

commit 373093497c9ebca029a707a8d9fee5e57e3d2af6
Author: msarett <msarett@google.com>
Date: Mon Nov 07 14:45:30 2016

Replace flaky PNG smoke test

The removed test is a bit slow, which I suspect is
causing flaky behavior on Android.  The test that
is replacing it provides coverage of png decoding
and color correction.

BUG= 657839 
BUG= 661769 

Review-Url: https://codereview.chromium.org/2477013003
Cr-Commit-Position: refs/heads/master@{#430270}

[modify] https://crrev.com/373093497c9ebca029a707a8d9fee5e57e3d2af6/third_party/WebKit/LayoutTests/SmokeTests
[modify] https://crrev.com/373093497c9ebca029a707a8d9fee5e57e3d2af6/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/375372bceae5a843cf14bd02ae5354c3ed2019ab

commit 375372bceae5a843cf14bd02ae5354c3ed2019ab
Author: msarett <msarett@google.com>
Date: Mon Nov 07 16:32:43 2016

Revert of Replace flaky smoke test (patchset #1 id:1 of https://codereview.chromium.org/2477013003/ )

Reason for revert:
Still breaking the Android bot

Original issue's description:
> Replace flaky PNG smoke test
>
> The removed test is a bit slow, which I suspect is
> causing flaky behavior on Android.  The test that
> is replacing it provides coverage of png decoding
> and color correction.
>
> BUG= 657839 
> BUG= 661769 
>
> Committed: https://crrev.com/373093497c9ebca029a707a8d9fee5e57e3d2af6
> Cr-Commit-Position: refs/heads/master@{#430270}

TBR=dpranke@chromium.org,msarett@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 657839 

Review-Url: https://codereview.chromium.org/2479253002
Cr-Commit-Position: refs/heads/master@{#430291}

[modify] https://crrev.com/375372bceae5a843cf14bd02ae5354c3ed2019ab/third_party/WebKit/LayoutTests/SmokeTests
[modify] https://crrev.com/375372bceae5a843cf14bd02ae5354c3ed2019ab/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a735030f7123aa550409b6dcdd58fee3faa0d5f9

commit a735030f7123aa550409b6dcdd58fee3faa0d5f9
Author: msarett <msarett@google.com>
Date: Tue Nov 08 16:18:42 2016

Replace flaky PNG smoke test

The removed test is a bit slow, which I suspect is
causing flaky behavior on Android.  The test that
is replacing it provides coverage of png decoding
and color correction.

BUG= 657839 
BUG= 661769 

Committed: https://crrev.com/373093497c9ebca029a707a8d9fee5e57e3d2af6
Review-Url: https://codereview.chromium.org/2477013003
Cr-Original-Commit-Position: refs/heads/master@{#430270}
Cr-Commit-Position: refs/heads/master@{#430627}

[modify] https://crrev.com/a735030f7123aa550409b6dcdd58fee3faa0d5f9/third_party/WebKit/LayoutTests/SmokeTests
[modify] https://crrev.com/a735030f7123aa550409b6dcdd58fee3faa0d5f9/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)

Sign in to add a comment