New issue
Advanced search Search tips

Issue 661764 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

turn fast/text/international/thai-line-breaks.html to a ref test

Project Member Reported by rouslan@chromium.org, Nov 2 2016

Issue description

fast/text/international/thai-line-breaks.html started failing after ICU roll.

Builder:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10

Suspected CL:
https://codereview.chromium.org/2447513002

 

Comment 1 by js...@chromium.org, Nov 2 2016

Hmm... I rebaselined Windows expected results as a part of that CL. (there's virtually no difference except for a slight change in rasterization, which is strange). That test had better be a ref-test. 

Anyway, I'll rebaseline. 
The root cause is bug 657646 (font smoothing settings are different on different trybots, which explains why I can't see any different in terms of line-breaking while I see slight differences in text rendering between two expected images) . See https://bugs.chromium.org/p/chromium/issues/detail?id=657646#c76

A better fix would be to turn this test to a ref test so that it's independent of font smoothing (and other factors nothing to do with line-breaking). 

Comment 3 by js...@chromium.org, Nov 3 2016

Blockedon: 657646

Comment 4 by js...@chromium.org, Nov 15 2016

Blockedon: -657646
Components: -Blink>JavaScript>Internationalization Blink>Layout
Status: Started (was: Assigned)
Summary: turn fast/text/international/thai-line-breaks.html to a ref test (was: fast/text/international/thai-line-breaks.html failing)
I'm turning it to a ref test. See https://codereview.chromium.org/2498013004 

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4595e6bb1e424666f1718486a90f42a37253c35a

commit 4595e6bb1e424666f1718486a90f42a37253c35a
Author: jshin <jshin@chromium.org>
Date: Tue Nov 15 19:27:21 2016

Convert thai-line-breaks to a ref test

ICU was used to generate the expected result.
(see http://paste.lisp.org/display/331567 ).

Update TestExpectations. This test should always pass on all platforms.

BUG= 661764 
TEST=fast/text/international/thai-line-breaks

Review-Url: https://codereview.chromium.org/2498013004
Cr-Commit-Position: refs/heads/master@{#432234}

[modify] https://crrev.com/4595e6bb1e424666f1718486a90f42a37253c35a/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/4595e6bb1e424666f1718486a90f42a37253c35a/third_party/WebKit/LayoutTests/fast/text/international/thai-line-breaks-expected.html
[modify] https://crrev.com/4595e6bb1e424666f1718486a90f42a37253c35a/third_party/WebKit/LayoutTests/fast/text/international/thai-line-breaks.html
[delete] https://crrev.com/57f2867d3c8804984fd0c35ff8d3ea92fdfb4d4b/third_party/WebKit/LayoutTests/platform/android/fast/text/international/thai-line-breaks-expected.png
[delete] https://crrev.com/57f2867d3c8804984fd0c35ff8d3ea92fdfb4d4b/third_party/WebKit/LayoutTests/platform/android/fast/text/international/thai-line-breaks-expected.txt
[delete] https://crrev.com/57f2867d3c8804984fd0c35ff8d3ea92fdfb4d4b/third_party/WebKit/LayoutTests/platform/linux/fast/text/international/thai-line-breaks-expected.png
[delete] https://crrev.com/57f2867d3c8804984fd0c35ff8d3ea92fdfb4d4b/third_party/WebKit/LayoutTests/platform/linux/fast/text/international/thai-line-breaks-expected.txt
[delete] https://crrev.com/57f2867d3c8804984fd0c35ff8d3ea92fdfb4d4b/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/international/thai-line-breaks-expected.png
[delete] https://crrev.com/57f2867d3c8804984fd0c35ff8d3ea92fdfb4d4b/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/international/thai-line-breaks-expected.png
[delete] https://crrev.com/57f2867d3c8804984fd0c35ff8d3ea92fdfb4d4b/third_party/WebKit/LayoutTests/platform/mac/fast/text/international/thai-line-breaks-expected.png
[delete] https://crrev.com/57f2867d3c8804984fd0c35ff8d3ea92fdfb4d4b/third_party/WebKit/LayoutTests/platform/mac/fast/text/international/thai-line-breaks-expected.txt
[delete] https://crrev.com/57f2867d3c8804984fd0c35ff8d3ea92fdfb4d4b/third_party/WebKit/LayoutTests/platform/win/fast/text/international/thai-line-breaks-expected.png
[delete] https://crrev.com/57f2867d3c8804984fd0c35ff8d3ea92fdfb4d4b/third_party/WebKit/LayoutTests/platform/win/fast/text/international/thai-line-breaks-expected.txt
[delete] https://crrev.com/57f2867d3c8804984fd0c35ff8d3ea92fdfb4d4b/third_party/WebKit/LayoutTests/platform/win7/fast/text/international/thai-line-breaks-expected.png

Comment 6 by js...@chromium.org, Nov 15 2016

Status: Fixed (was: Started)

Sign in to add a comment