Add more unit tests for both WebVR and VR Shell |
||||||||||
Issue descriptionRight now 21 vr shell unit tests are running on FYI bot https://build.chromium.org/p/chromium.fyi/builders/Android%20VR%20Tests/builds/1877/steps/vr_shell_unittests/logs/stdio https://cs.chromium.org/chromium/src/chrome/browser/android/vr_shell/BUILD.gn?type=cs&q=vr_shell_unittests&sq=package:chromium&l=77 It will be nice to add more unit tests and enable them on main waterfall and CQ.
,
Nov 4 2016
This bug is for unit tests which are supposed to be running in Commit queue. Layout tests are like integration tests, we don't run layout tests in our Commit queue, since it is time consuming and unstable. But it will be nice to add WebKit Layout Tests for WebVR. Do you plan to add layout tests in Chromium repository or web-platform-tests GitHub(https://github.com/w3c/web-platform-tests)? BTW, layout tests don't work with Chrome on Android L+, chrome infrastructure team are working on it(https://bugs.chromium.org/p/chromium/issues/detail?id=567947).
,
Nov 7 2016
Yes, I plan to add layout tests in chromium repository
,
Nov 8 2016
Hi Shaobo, Could you cc me and bsheedy@chromium.org in your patch to add layout tests? We are also working on layout tests for WebVR APIs, just want to make sure we don't duplicate efforts.
,
Nov 15 2016
Hi, leilei Sorry for late reply, since this issue doesn't cc to me.... Sure, there is no patch set updated now since I've landed mojo simplification work last week. I'll raise a patch this week in plan. If you have any patch now, pls cc me :) BR, Yan,Shaobo
,
Nov 30 2016
,
Dec 8 2016
,
Apr 26 2017
,
Apr 26 2017
,
Apr 26 2017
,
May 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/458c5bc259563201f122ce96d612fe89ff305748 commit 458c5bc259563201f122ce96d612fe89ff305748 Author: amp <amp@chromium.org> Date: Wed May 24 05:34:44 2017 Update fullscreen ux, make floor and ceiling visible. BUG=643434, 661762 Review-Url: https://codereview.chromium.org/2887773008 Cr-Commit-Position: refs/heads/master@{#474172} [modify] https://crrev.com/458c5bc259563201f122ce96d612fe89ff305748/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java [modify] https://crrev.com/458c5bc259563201f122ce96d612fe89ff305748/chrome/browser/android/vr_shell/ui_elements/ui_element_debug_id.h [modify] https://crrev.com/458c5bc259563201f122ce96d612fe89ff305748/chrome/browser/android/vr_shell/ui_scene_manager.cc [modify] https://crrev.com/458c5bc259563201f122ce96d612fe89ff305748/chrome/browser/android/vr_shell/ui_scene_manager.h [modify] https://crrev.com/458c5bc259563201f122ce96d612fe89ff305748/chrome/browser/android/vr_shell/ui_scene_manager_unittest.cc
,
Jun 24 2017
leilei and bsheedy: We have more unit tests now, but I don't know how sufficient they are. Do we need this bug or should we close it and file new issues for specific gaps? More tests should be added as part of the refactoring as well.
,
Jun 26 2017
Closing and filing specific bugs SGTM. I'm not sure off hand whether the current C++ unittests coverage is suficient, but I know ymalick@ wanted to add some Java unittests for things that can't be covered in C++ such as VrShellDelegate.
,
Jun 26 2017
I think we can close it and file new issues for specific gaps if needed. This issue was used to track the generic unit test coverage.
,
Jun 26 2017
Close it, since we have more unit tests and will open new issues if needed.
,
Jul 4
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by shaobo....@intel.com
, Nov 3 2016