New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 661762 link

Starred by 3 users

Issue metadata

Status: Verified
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Proj-XR
Proj-XR-VR


Participants' hotlists:
VR-Automated-Tests


Sign in to add a comment

Add more unit tests for both WebVR and VR Shell

Project Member Reported by leilei@chromium.org, Nov 2 2016

Issue description

Hi, leilei,
I've planed to add WebKit Layout tests related to latest mojo WebVR refactory. Maybe this is related to this issue?
p.s. mojo simplified patch https://codereview.chromium.org/2420743003/
Cc: bsheedy@chromium.org
This bug is for unit tests which are supposed to be running in Commit queue. Layout tests are like integration tests, we don't run layout tests in our Commit queue, since it is time consuming and unstable.

But it will be nice to add WebKit Layout Tests for WebVR. Do you plan to add layout tests in Chromium repository or web-platform-tests GitHub(https://github.com/w3c/web-platform-tests)? 

BTW, layout tests don't work with Chrome on Android L+, chrome infrastructure team are working on it(https://bugs.chromium.org/p/chromium/issues/detail?id=567947).
Yes, I plan to add layout tests in chromium repository
Hi Shaobo,

Could you cc me and bsheedy@chromium.org in your patch to add layout tests? We are also working on layout tests for WebVR APIs, just want to make sure we don't duplicate efforts.
Hi, leilei
Sorry for late reply, since this issue doesn't cc to me....
Sure, there is no patch set updated now since I've landed mojo simplification work last week. I'll raise a patch this week in plan. If you have any patch now, pls cc me :)

BR,
Yan,Shaobo 
Labels: Proj-VR
Labels: VR-Test
Status: Available (was: Untriaged)
Labels: VR-BBB
Labels: hotlist-initial-vr-browser
Labels: -hotlist-initial-vr-browser
Cc: vollick@chromium.org cjgrant@chromium.org amp@chromium.org
leilei and bsheedy: We have more unit tests now, but I don't know how sufficient they are. Do we need this bug or should we close it and file new issues for specific gaps? More tests should be added as part of the refactoring as well.
Closing and filing specific bugs SGTM. I'm not sure off hand whether the current C++ unittests coverage is suficient, but I know ymalick@ wanted to add some Java unittests for things that can't be covered in C++  such as VrShellDelegate.
I think we can close it and file new issues for specific gaps if needed. This issue was used to track the generic unit test coverage.
Status: Verified (was: Available)
Close it, since we have more unit tests and will open new issues if needed.
Components: Blink>WebXR

Sign in to add a comment