New issue
Advanced search Search tips

Issue 661694 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Oct 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[MD Settings] Route URLs should be synced between JavaScript and C++

Project Member Reported by tommycli@chromium.org, Nov 2 2016

Issue description

A continuation of this bug: https://bugs.chromium.org/p/chromium/issues/detail?id=623587#c15

There were issues because the URL constants are duplicated between route.js and url_constants.cc.

Best guess is to use loadTimeData, but it's not a dev blocker anymore...
 

Comment 1 by dbeam@chromium.org, Nov 9 2016

Owner: tommycli@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by dbeam@chromium.org, Feb 6 2017

Labels: -Pri-2 Hotlist-MD-Settings-General Pri-3
Owner: ----
Status: Available (was: Assigned)
I'm un-assigning myself, because my version of the cure (https://codereview.chromium.org/2477453002/) seemed worse than the disease.

I'll let someone else take a crack at it.
For the record:

When dbeam and I discussed this months back, we agreed that the ideal fix would be a canonical source (probably mojo or idl) that generated the URL path constants on both the C++ and JavaScript side so they could never fall out of sync.
Project Member

Comment 5 by sheriffbot@chromium.org, May 17 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: Untriaged)
Marking this as WontFix, since there is no concrete plan on addressing this any time soon (perhaps if/when Mojo is the go-to way for Settings).

Sign in to add a comment