Compile failure in Ozone Linux builder |
||
Issue descriptionSee the log output here: https://build.chromium.org/p/chromium.fyi/builders/Ozone%20Linux/builds/75/steps/compile/logs/stdio It looks like We're calling things in OsCryptMockerLinux when "defined(USE_LIBSECRET) || defined(USE_KEYRING) || defined(USE_KWALLET)", but we're only including the necessary file when "defined(USE_LIBSECRET)". cfroussios@ PTAL?
,
Nov 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6be9170d75ff0ce95a3cd163fe0a0ab693ae8fc6 commit 6be9170d75ff0ce95a3cd163fe0a0ab693ae8fc6 Author: cfroussios <cfroussios@chromium.org> Date: Wed Nov 02 20:01:19 2016 Fix inconsistency between included headers and calls. The call to OSCryptMockerLinux was guarded by a different precompiler condition than the inclusion of its header. BUG= 661693 Review-Url: https://codereview.chromium.org/2475503002 Cr-Commit-Position: refs/heads/master@{#429377} [modify] https://crrev.com/6be9170d75ff0ce95a3cd163fe0a0ab693ae8fc6/components/os_crypt/os_crypt_mocker.cc
,
Nov 3 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by cfroussios@chromium.org
, Nov 2 2016