New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 661682 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Refactor "chromium_*" recipe modules and the recipes that use them.

Project Member Reported by d...@chromium.org, Nov 2 2016

Issue description

The most core Chromium recipes import and use the "chromium", "chromium_android", and "chromium_tests" recipe modules to checkout, build, and test Chromium. These recipe modules have grown organically, and have proven to be unwieldy and confusing for people, especially those who are not familiar with them, to work with.

Part of the Chromium crossover effort will be to improve the usability of these recipes by refactoring them. The specific approach still needs to be worked out, but an overview of the effort will be:

- Split the modules into Infrastructure- and Chromium-specific components.
- Identify Chromium team members who will own the Chromium side of these components.
- Design and implement refactoring of these respective modules.
 
Cc: dpranke@chromium.org iannucci@chromium.org
Owner: d...@chromium.org
Status: Assigned (was: Untriaged)
The way I'm thinking about the recipes these days (and the responsibilities of the infra sub-teams), I don't think there is a "Chromium side" of the recipes per se that would be owned solely by chromium devs. I think the right place to draw the line is in the src-side interfaces (the *.json files, the Test step APIs, the MB configs, etc.). 

I mostly want infra folks (either foundation or crossover) to own all the recipe-side code.

I think this is consistent with what we've discussed recently. Agree?
Cc: andyb...@chromium.org
Owner: dpranke@chromium.org
I'm going to reassign this to me for now ...
Labels: cit-pm-11
Labels: Infra-Failures
why is this a postmortem-related thing?

Comment 7 by iannu...@google.com, Dec 16 2016

Just flying by, but in light of the current team organization, I think the owners in  comment #0 would be "foundation" and "crossover", not "infra" and "chromium".
I think actually that the answer is "all crossover", but maybe there's some stuff that we can pull out of the chromium recipes and modules that we'd want to share for non-chromium teams, like a new steps api and logic to handle retrying w/o patches. I'm not sure ...

Comment 9 by mar...@chromium.org, Dec 16 2016

Labels: cit-pm
@dnj - let's talk about this when you have some time. I'd like to make sure my current thinking about this stuff lines up with yours.
Status: WontFix (was: Assigned)
We talked about this, but I didn't update the bug. Our conclusion was that this CL as it stands is a bit vague, and we don't really want to think of things as "crossover" or not.

However, we should clean up these recipes and see if we can make them as generic as possible, with clean declarative APIs for repo-side configuration.

I'm closing this bug; we'll work on that cleanup elsewhere in other tasks.
Labels: Hotlist-Infra-Failures

Sign in to add a comment