It needs to be updated to work correctly with the default repo codereview site.
As long as this doesn't break in the mean time, this is only blocking turning off Rietveld, not turning on Gerrit for Chromium. As such, Afterglow.
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/336791e79014e09940f41fdebc87a345f5188d1d commit 336791e79014e09940f41fdebc87a345f5188d1d Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org> Date: Wed Feb 22 10:27:03 2017 recipe_autoroller: disable git cache It's not needed anyway because we use persistent checkouts. This will make it easier to stop forcing Rietveld. BUG= 661680 Change-Id: I1493d10298453c757b9d8a008c46f769bbd1df52 Reviewed-on: https://chromium-review.googlesource.com/446097 Reviewed-by: Emma Söderberg <emso@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> [modify] https://crrev.com/336791e79014e09940f41fdebc87a345f5188d1d/recipes/recipes/recipe_autoroller.expected/basic.json [modify] https://crrev.com/336791e79014e09940f41fdebc87a345f5188d1d/recipes/recipes/recipe_autoroller.expected/failed_upload.json [modify] https://crrev.com/336791e79014e09940f41fdebc87a345f5188d1d/recipes/recipes/recipe_autoroller.expected/nontrivial.json [modify] https://crrev.com/336791e79014e09940f41fdebc87a345f5188d1d/recipes/recipes/recipe_autoroller.expected/repo_data_nontrivial_open_stale.json [modify] https://crrev.com/336791e79014e09940f41fdebc87a345f5188d1d/recipes/recipes/recipe_autoroller.expected/with_auth.json [modify] https://crrev.com/336791e79014e09940f41fdebc87a345f5188d1d/recipes/recipes/recipe_autoroller.expected/repo_data_trivial_closed.json [modify] https://crrev.com/336791e79014e09940f41fdebc87a345f5188d1d/recipes/recipes/recipe_autoroller.expected/failure.json [modify] https://crrev.com/336791e79014e09940f41fdebc87a345f5188d1d/recipes/recipes/recipe_autoroller.expected/repo_data_nontrivial_open.json [modify] https://crrev.com/336791e79014e09940f41fdebc87a345f5188d1d/recipes/recipes/recipe_autoroller.expected/repo_data_trivial_cq_stale.json [modify] https://crrev.com/336791e79014e09940f41fdebc87a345f5188d1d/recipes/recipes/recipe_autoroller.expected/empty.json [modify] https://crrev.com/336791e79014e09940f41fdebc87a345f5188d1d/recipes/recipe_modules/recipe_autoroller/api.py [modify] https://crrev.com/336791e79014e09940f41fdebc87a345f5188d1d/recipes/recipes/recipe_autoroller.expected/repo_data_trivial_cq.json
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/f2872bb816e2e1db37acd5e982e39027c165f7ec commit f2872bb816e2e1db37acd5e982e39027c165f7ec Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org> Date: Wed Feb 22 11:10:11 2017 recipe_autoroller: stop forcing rietveld This will use Gerrit for the repos that enable it. BUG= 661680 Change-Id: I7844bb6d4881f7e5f61ae3f3f0946e865627295d Reviewed-on: https://chromium-review.googlesource.com/446356 Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> [modify] https://crrev.com/f2872bb816e2e1db37acd5e982e39027c165f7ec/recipes/recipes/recipe_autoroller.expected/basic.json [modify] https://crrev.com/f2872bb816e2e1db37acd5e982e39027c165f7ec/recipes/recipes/recipe_autoroller.expected/failed_upload.json [modify] https://crrev.com/f2872bb816e2e1db37acd5e982e39027c165f7ec/recipes/recipes/recipe_autoroller.expected/nontrivial.json [modify] https://crrev.com/f2872bb816e2e1db37acd5e982e39027c165f7ec/recipes/recipes/recipe_autoroller.expected/repo_data_nontrivial_open_stale.json [modify] https://crrev.com/f2872bb816e2e1db37acd5e982e39027c165f7ec/recipes/recipes/recipe_autoroller.expected/with_auth.json [modify] https://crrev.com/f2872bb816e2e1db37acd5e982e39027c165f7ec/recipes/recipes/recipe_autoroller.expected/repo_data_trivial_closed.json [modify] https://crrev.com/f2872bb816e2e1db37acd5e982e39027c165f7ec/recipes/recipes/recipe_autoroller.expected/repo_data_nontrivial_open.json [modify] https://crrev.com/f2872bb816e2e1db37acd5e982e39027c165f7ec/recipes/recipes/recipe_autoroller.expected/repo_data_trivial_cq_stale.json [modify] https://crrev.com/f2872bb816e2e1db37acd5e982e39027c165f7ec/recipes/recipe_modules/recipe_autoroller/api.py [modify] https://crrev.com/f2872bb816e2e1db37acd5e982e39027c165f7ec/recipes/recipes/recipe_autoroller.expected/repo_data_trivial_cq.json
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/26efb49f7eea0694ea8b8a7bae4b338dc3f93d3f commit 26efb49f7eea0694ea8b8a7bae4b338dc3f93d3f Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org> Date: Wed Feb 22 11:58:30 2017 recipe_autoroller: explicitly pass --gerrit to git cl commands It's needed for git cl status --issue, and we keep it with other commands for consistency. Otherwise the following error is generated: Usage: git cl status [options] git cl: error: --issue must be specified with either --rietveld or --gerrit BUG= 661680 Change-Id: I35e3d2e456430e61532c85cc5a1809c2e32bc10b Reviewed-on: https://chromium-review.googlesource.com/445878 Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> [modify] https://crrev.com/26efb49f7eea0694ea8b8a7bae4b338dc3f93d3f/recipes/recipes/recipe_autoroller.expected/basic.json [modify] https://crrev.com/26efb49f7eea0694ea8b8a7bae4b338dc3f93d3f/recipes/recipes/recipe_autoroller.expected/failed_upload.json [modify] https://crrev.com/26efb49f7eea0694ea8b8a7bae4b338dc3f93d3f/recipes/recipes/recipe_autoroller.expected/nontrivial.json [modify] https://crrev.com/26efb49f7eea0694ea8b8a7bae4b338dc3f93d3f/recipes/recipes/recipe_autoroller.expected/repo_data_nontrivial_open_stale.json [modify] https://crrev.com/26efb49f7eea0694ea8b8a7bae4b338dc3f93d3f/recipes/recipes/recipe_autoroller.expected/with_auth.json [modify] https://crrev.com/26efb49f7eea0694ea8b8a7bae4b338dc3f93d3f/recipes/recipes/recipe_autoroller.expected/repo_data_trivial_closed.json [modify] https://crrev.com/26efb49f7eea0694ea8b8a7bae4b338dc3f93d3f/recipes/recipes/recipe_autoroller.expected/repo_data_nontrivial_open.json [modify] https://crrev.com/26efb49f7eea0694ea8b8a7bae4b338dc3f93d3f/recipes/recipes/recipe_autoroller.expected/repo_data_trivial_cq_stale.json [modify] https://crrev.com/26efb49f7eea0694ea8b8a7bae4b338dc3f93d3f/recipes/recipe_modules/recipe_autoroller/api.py [modify] https://crrev.com/26efb49f7eea0694ea8b8a7bae4b338dc3f93d3f/recipes/recipes/recipe_autoroller.expected/repo_data_trivial_cq.json
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/8a849ba4405499585ba6f85b3c7956b9eb3dbcdc commit 8a849ba4405499585ba6f85b3c7956b9eb3dbcdc Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org> Date: Wed Feb 22 12:15:30 2017 recipe_autoroller: temporarily make git cl issue set-close failures OK Otherwise we hit the following errors because of switching to Gerrit: __main__.GerritChangeNotExists: change 2704393003 at https://chromium-review.googlesource.com does not exist or you have no access to it BUG= 661680 Change-Id: I7a4562f7defae0027790b4a3696e5fe0879ea246 Reviewed-on: https://chromium-review.googlesource.com/446377 Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> [modify] https://crrev.com/8a849ba4405499585ba6f85b3c7956b9eb3dbcdc/recipes/recipe_modules/recipe_autoroller/api.py
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/puppet/+/b5f9230da100d45bf2e2c154f85314e998b6b8fd commit b5f9230da100d45bf2e2c154f85314e998b6b8fd Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Wed Feb 22 13:44:37 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/b5e57debeaa829726f570902e945fab02fd09801 commit b5e57debeaa829726f570902e945fab02fd09801 Author: Paweł Hajdan, Jr <phajdan.jr@chromium.org> Date: Wed Feb 22 21:26:42 2017 Temporarily remove phajdan.jr from roller TBR emails For some reason uploading CLs fails with the following error: user "phajdan.jr@chromium.org" not found TBR=iannucci,martiniss BUG= 661680 Change-Id: If583f68371eebea68d387d8a12808a599031ea6b Reviewed-on: https://chromium-review.googlesource.com/446099 Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> [modify] https://crrev.com/b5e57debeaa829726f570902e945fab02fd09801/recipes/recipes/recipe_autoroller.expected/basic.json [modify] https://crrev.com/b5e57debeaa829726f570902e945fab02fd09801/recipes/recipes/recipe_autoroller.expected/failed_upload.json [modify] https://crrev.com/b5e57debeaa829726f570902e945fab02fd09801/recipes/recipe_modules/recipe_autoroller/api.py [modify] https://crrev.com/b5e57debeaa829726f570902e945fab02fd09801/recipes/recipes/recipe_autoroller.expected/with_auth.json [modify] https://crrev.com/b5e57debeaa829726f570902e945fab02fd09801/recipes/recipes/recipe_autoroller.expected/repo_data_trivial_closed.json
Comment 1 by iannucci@chromium.org
, Nov 2 2016