New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 661678 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocking:
issue 656511



Sign in to add a comment

Public Session whitelisting - Enable all URLs for webRequest API for regular extensions in PS

Project Member Reported by isandrk@chromium.org, Nov 2 2016

Issue description

webRequest API needs origin/url permissions, but that's currently blocked because of privacy/security in Public Sessions. Find a way to fix this.

 
Cc: sduraisamy@chromium.org krishna...@chromium.org
Blocking: 656511
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e7318b652b0fa22e68b3cb4de0e93cfef12f15c

commit 3e7318b652b0fa22e68b3cb4de0e93cfef12f15c
Author: isandrk <isandrk@chromium.org>
Date: Wed Nov 16 13:02:36 2016

Filter out privacy/security sensitive data from webRequests in Public Sessions.

Enable all URLs for webRequest for regular extensions in Public Sessions. Note: Origin/URL permissions are completely disabled in Public Sessions for privacy/security reasons so this is a workaround.

Doc explaining the changes to webRequest API in details go/webrequest-whitelisting.

BUG= 661678 

Review-Url: https://codereview.chromium.org/2455393002
Cr-Commit-Position: refs/heads/master@{#432469}

[modify] https://crrev.com/3e7318b652b0fa22e68b3cb4de0e93cfef12f15c/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc
[modify] https://crrev.com/3e7318b652b0fa22e68b3cb4de0e93cfef12f15c/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[add] https://crrev.com/3e7318b652b0fa22e68b3cb4de0e93cfef12f15c/chrome/browser/extensions/api/web_request/web_request_event_details_unittest.cc
[modify] https://crrev.com/3e7318b652b0fa22e68b3cb4de0e93cfef12f15c/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc
[modify] https://crrev.com/3e7318b652b0fa22e68b3cb4de0e93cfef12f15c/chrome/test/BUILD.gn
[add] https://crrev.com/3e7318b652b0fa22e68b3cb4de0e93cfef12f15c/chrome/test/data/extensions/api_test/webrequest_public_session/framework.js
[add] https://crrev.com/3e7318b652b0fa22e68b3cb4de0e93cfef12f15c/chrome/test/data/extensions/api_test/webrequest_public_session/manifest.json
[add] https://crrev.com/3e7318b652b0fa22e68b3cb4de0e93cfef12f15c/chrome/test/data/extensions/api_test/webrequest_public_session/res/a.html
[add] https://crrev.com/3e7318b652b0fa22e68b3cb4de0e93cfef12f15c/chrome/test/data/extensions/api_test/webrequest_public_session/res/b.html
[add] https://crrev.com/3e7318b652b0fa22e68b3cb4de0e93cfef12f15c/chrome/test/data/extensions/api_test/webrequest_public_session/test.html
[add] https://crrev.com/3e7318b652b0fa22e68b3cb4de0e93cfef12f15c/chrome/test/data/extensions/api_test/webrequest_public_session/test.js
[modify] https://crrev.com/3e7318b652b0fa22e68b3cb4de0e93cfef12f15c/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/3e7318b652b0fa22e68b3cb4de0e93cfef12f15c/extensions/browser/api/web_request/web_request_api_constants.cc
[modify] https://crrev.com/3e7318b652b0fa22e68b3cb4de0e93cfef12f15c/extensions/browser/api/web_request/web_request_api_constants.h
[modify] https://crrev.com/3e7318b652b0fa22e68b3cb4de0e93cfef12f15c/extensions/browser/api/web_request/web_request_event_details.cc
[modify] https://crrev.com/3e7318b652b0fa22e68b3cb4de0e93cfef12f15c/extensions/browser/api/web_request/web_request_event_details.h
[modify] https://crrev.com/3e7318b652b0fa22e68b3cb4de0e93cfef12f15c/extensions/browser/api/web_request/web_request_permissions.cc
[modify] https://crrev.com/3e7318b652b0fa22e68b3cb4de0e93cfef12f15c/extensions/browser/api/web_request/web_request_permissions.h

Status: Fixed (was: Started)

Comment 5 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment