New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 661676 link

Starred by 2 users
Status: Fixed
Owner:
█ spqc...@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Cc:
pinkerton@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Prevent default text editing controls from appearing in the Touch Bar when editing in the omnibox

Project Member Reported by shrike@chromium.org, Nov 2 2016 
Currently if you click in the omnibox the Touch Bar will display controls for changing the text style (font, color, etc.). We don't want this.

Ideally we would cherry-pick this back to M55 but I think we need to test it on actual hardware.

Comment 1 by pinkerton@chromium.org, Nov 2 2016

Cc: pinkerton@chromium.org

Comment 2 by rpop@chromium.org, Nov 17 2016 

Branch is today! What's the status of this? If it lands soon, we can try to merge.

Comment 3 by shrike@chromium.org, Nov 17 2016 

I talked to spqchan@ about this earlier this week - it's turning out to not be as simple to fix this as we had hoped.

Comment 4 by rpop@chromium.org, Nov 17 2016 

Ack.

Comment 5 by spqc...@chromium.org, Nov 17 2016 

Yes, it's not simple. It's easy to fix if it's a Textview, but Touchbar is weird for Textfields.

Comment 6 by pinkerton@chromium.org, Nov 18 2016 

Can we reverse-engineer what Safari does in their url bar?

Comment 7 by spqc...@chromium.org, Nov 18 2016 

Yep, that's what I'm currently investigating

Comment 8 by spqc...@chromium.org, Nov 23 2016 

TIL about the field editor in a NSTextField. That makes things super simple.
CL in review: https://codereview.chromium.org/2528793002/

Comment 9 by spqc...@chromium.org, Dec 6 2016

Components: UI>Browser
Labels: Merge-Request-56
Verified it on an actual device. Requesting merge

Comment 10 by dimu@chromium.org, Dec 7 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 7 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61dd2ff778ffff84aeecaec7213211f46e35bd79

commit 61dd2ff778ffff84aeecaec7213211f46e35bd79
Author: spqchan <spqchan@chromium.org>
Date: Wed Dec 07 00:09:55 2016

[Mac] Remove omnibox default touch bar items

BUG= 661676 

Review-Url: https://codereview.chromium.org/2528793002
Cr-Commit-Position: refs/heads/master@{#434700}
(cherry picked from commit 542e45d1534440fcb5b9f3d6864d6d13df293b9c)

Review URL: https://codereview.chromium.org/2554213002 .

Cr-Commit-Position: refs/branch-heads/2924@{#367}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/61dd2ff778ffff84aeecaec7213211f46e35bd79/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

Comment 12 by spqc...@chromium.org, Dec 7 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment